bpf: fix pointer cast warning
Subsystems (6)
PATCH 1/1 bpf: fix pointer cast warning
From: Arnd Bergmann <[email protected]>
kp->addr is a pointer, so it cannot be cast directly to a 'u64' when it gets interpreted as an integer value:
kernel/trace/bpf_trace.c: In function '____bpf_get_func_ip_kprobe':kernel/trace/bpf_trace.c:968:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
968 | return kp ? (u64) kp->addr : 0;
Use the uintptr_t type instead.
--- kernel/trace/bpf_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/trace/bpf_trace.c +1 -1
@@ -965,7 +965,7 @@ BPF_CALL_1(bpf_get_func_ip_kprobe, struct pt_regs *, regs) {struct kprobe *kp =kprobe_running (); -return kp ? (u64 ) kp->addr :0 ; +return kp ? (uintptr_t )kp->addr :0 ; }static const struct bpf_func_proto bpf_get_func_ip_proto_kprobe = {
Signature · 1 line
2.29.2
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
kp->addris a pointer, so it cannot be cast directly to a 'u64' when it gets interpreted as an integer value:
kernel/trace/bpf_trace.c: In function '____bpf_get_func_ip_kprobe':kernel/trace/bpf_trace.c:968:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
968 | return kp ? (u64)kp->addr: 0;
Quoted 5 lines
Use the
uintptr_ttype instead.Fixes 9ffd9f3ff719 ("bpf: Add bpf_get_func_ip helper for kprobe programs")Signed-off-by Arnd Bergmann <[email protected]>---
I'll take this through the bpf-next tree, if no one objects. Thanks for the fix!
Quoted 19 lines
kernel/trace/bpf_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/trace/bpf_trace.c +1
-2@@ -965,7 +965,7 @@ BPF_CALL_1(bpf_get_func_ip_kprobe, struct pt_regs *, regs) {struct kprobe *kp =kprobe_running (); -return kp ? (u64 ) kp->addr :0 ; +return kp ? (uintptr_t )kp->addr :0 ; }static const struct bpf_func_proto bpf_get_func_ip_proto_kprobe = { --2.29.2