Skip to contentSkip to conversation

soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR

PATCH In review Dmitry Osipenko 4 participants 6 messages Jul 21, 2021 – Aug 2, 2021 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR

The regulator coupler drivers now use regulator-driver API function that isn't available during compile-testing. Make regulator coupler drivers dependent on CONFIG_REGULATOR in Kconfig.

Fixes 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")

---

Changelog:

v2: - No changes. Re-sending to Arnd Bergmann and [email protected].

 drivers/soc/tegra/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/soc/tegra/Kconfig +4 -2
index db49075b1946..1224e1c8c2c9 100644
@@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA20_VOLTAGE_COUPLER
+	select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
@@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA30_VOLTAGE_COUPLER
+	select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra T30 processor family, based on the
@@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
 config SOC_TEGRA20_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra20 SoCs"
 	depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
+	depends on REGULATOR
 
 config SOC_TEGRA30_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra30 SoCs"
 	depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
+	depends on REGULATOR
Signature · 1 line
2.32.0
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 40 lines · Dmitry Osipenko

The regulator coupler drivers now use regulator-driver API function that isn't available during compile-testing. Make regulator coupler drivers dependent on CONFIG_REGULATOR in Kconfig.

Fixes 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")

---

Changelog:

v2: - No changes. Re-sending to Arnd Bergmann and [email protected].

 drivers/soc/tegra/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/soc/tegra/Kconfig +2 -2
index db49075b1946..1224e1c8c2c9 100644
@@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA20_VOLTAGE_COUPLER
+	select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
@@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA30_VOLTAGE_COUPLER
+	select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra T30 processor family, based on the

drivers/soc/tegra/Kconfig config SOC_TEGRA_POWERGATE_BPMP · line 162

Quoted 9 lines
drivers/soc/tegra/Kconfig +2 -0
@@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
 config SOC_TEGRA20_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra20 SoCs"
 	depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
+	depends on REGULATOR
 
 config SOC_TEGRA30_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra30 SoCs"
 	depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
+	depends on REGULATOR

Thanks!
Jon

Signature · 1 line
nvpublic
#2 lore raw
In reply to Dmitry Osipenko
Quoted 7 lines · Dmitry Osipenko

The regulator coupler drivers now use regulator-driver API function that isn't available during compile-testing. Make regulator coupler drivers dependent on CONFIG_REGULATOR in Kconfig.

Fixes 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
Quoted 8 lines

---

Changelog:

v2: - No changes. Re-sending to Arnd Bergmann and [email protected].

 drivers/soc/tegra/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Seeing that Arnd hasn't picked this up yet, I've now applied it to the Tegra tree and plan to send out a PR for v5.14 later this week.

Thierry

#3 lore raw
Quoted 13 lines · Thierry Reding
Quoted 11 lines · Dmitry Osipenko

The regulator coupler drivers now use regulator-driver API function that isn't available during compile-testing. Make regulator coupler drivers dependent on CONFIG_REGULATOR in Kconfig.

Fixes 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")

---

Changelog:

Quoted 7 lines
Quoted 4 lines

v2: - No changes. Re-sending to Arnd Bergmann and [email protected].

 drivers/soc/tegra/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Seeing that Arnd hasn't picked this up yet, I've now applied it to the Tegra tree and plan to send out a PR for v5.14 later this week.

Sorry about the mixup. In fact I have just picked it up two hours ago. If you have other fixes that are already in your fixes branch.

Arnd

#4 lore raw
Quoted 3 lines · Arnd Bergmann

On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <[email protected]> wrote:

If you have other fixes that are already in your fixes branch

... that you want to have in rc5, please send them soon, as I'm going to prepare that pull request in a few days.

I'll probably do another one for -rc6 though.

Arnd

#5 lore raw
Quoted 8 lines · Arnd Bergmann
Quoted 3 lines · Arnd Bergmann

On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <[email protected]> wrote:

If you have other fixes that are already in your fixes branch

... that you want to have in rc5, please send them soon, as I'm going to prepare that pull request in a few days.

I'll probably do another one for -rc6 though.

Okay, will do. Thanks.

Thierry