Skip to contentSkip to conversation

gpu: ipu-v3: use swap()

PATCH RESEND Superseded Salah Triki 2 participants 2 messages Jul 22, 2021 – Jul 23, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 gpu: ipu-v3: use swap()

Use swap() instead of implementing it in order to make code more clean.

---
 drivers/crypto/atmel-aes.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/crypto/atmel-aes.c +2 -6
index b1d286004295..60041022c4f5 100644
@@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd)
 	 * the order of the ciphered tweak bytes need to be reversed before
 	 * writing them into the ODATARx registers.
 	 */
-	for (i = 0; i < AES_BLOCK_SIZE/2; ++i) {
-		u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i];
-
-		tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i];
-		tweak_bytes[i] = tmp;
-	}
+	for (i = 0; i < AES_BLOCK_SIZE/2; ++i)
+		swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]);
 
 	/* Process the data. */
 	atmel_aes_write_ctrl(dd, use_dma, NULL);
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Wrong $subject then...

Quoted 29 lines · Salah Triki

Use swap() instead of implementing it in order to make code more clean.

---
  drivers/crypto/atmel-aes.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)
drivers/crypto/atmel-aes.c +2 -7
index b1d286004295..60041022c4f5 100644
@@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd)
          * the order of the ciphered tweak bytes need to be reversed before
          * writing them into the ODATARx registers.
          */
-       for (i = 0; i < AES_BLOCK_SIZE/2; ++i) {
-               u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i];
-
-               tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i];
-               tweak_bytes[i] = tmp;
-       }
+       for (i = 0; i < AES_BLOCK_SIZE/2; ++i)
+               swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]);
 
         /* Process the data. */
         atmel_aes_write_ctrl(dd, use_dma, NULL);
--

2.25.1

Signature · 1 line
Nicolas Ferre