ppc4xx: replace sscanf() by kstrtoul()
PATCH RESEND 1/1 ppc4xx: replace sscanf() by kstrtoul()
Fix the checkpatch.pl warning: "Prefer kstrto<type> to single variable sscanf".
Signed-off-by Salah Triki <[email protected]>
--- drivers/dma/ppc4xx/adma.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/dma/ppc4xx/adma.c +9 -3
@@ -4319,6 +4319,7 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf, size_t count) {unsigned long val; +int err;if (!count || count >11 )return -EINVAL ;
@@ -4327,7 +4328,10 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf,return -EFAULT ;/* Write a key */ -sscanf (buf,"%lx" , &val); + err =kstrtoul (buf,16 , &val); +if (err) +return err; +dcr_write (ppc440spe_mq_dcr_host,DCRN_MQ0_XORBA , val);isync ();
@@ -4368,7 +4372,7 @@ static ssize_t poly_store(struct device_driver *dev, const char *buf, size_t count) {unsigned long reg, val; - +int err;#ifdef CONFIG_440SP /* 440SP uses default 0x14D polynomial only */ return -EINVAL ;
@@ -4378,7 +4382,9 @@ static ssize_t poly_store(struct device_driver *dev, const char *buf,return -EINVAL ;/* e.g., 0x14D or 0x11D */ -sscanf (buf,"%lx" , &val); + err =kstrtoul (buf,16 , &val); +if (err) +return err;if (val & ~0x1FF )return -EINVAL ;
Signature · 1 line
2.25.1