Skip to contentSkip to conversation

Revert "Revert "libubootenv: inherit uboot-config""

PATCH In review Anuj Mittal 3 participants 4 messages Jul 23, 2021 – Jul 25, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "Revert "libubootenv: inherit uboot-config""

This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.

The original change was added to resolve build errors [1] for MACHINE values that don't have u-boot support. This recipe was, after that change, skipped in world builds for those MACHINEs.

But we should be able to build libubootenv with or without u-boot support [2] so the original solution to inherit uboot-config was not perfect. But until we have a better solution, revert this so builds don't fail for others.

[1] https://lists.openembedded.org/g/openembedded-core/message/153508
[2] https://lists.openembedded.org/g/openembedded-core/message/153614

---
 meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb +1 -1
index 6774290ea5..cb59dd3f1d 100644
@@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
 
 S = "${WORKDIR}/git"
 
-inherit cmake lib_package
+inherit uboot-config cmake lib_package
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
 
Signature · 1 line
2.31.1
#1 lore raw

I am against reverting it again. We discussed alternatives, which could solve the problem.

Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
<[email protected]> escreveu:

Quoted 39 lines

This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.

The original change was added to resolve build errors [1] for MACHINE values that don't have u-boot support. This recipe was, after that change, skipped in world builds for those MACHINEs.

But we should be able to build libubootenv with or without u-boot support [2] so the original solution to inherit uboot-config was not perfect. But until we have a better solution, revert this so builds don't fail for others.

[1] https://lists.openembedded.org/g/openembedded-core/message/153508
[2] https://lists.openembedded.org/g/openembedded-core/message/153614

---
 meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-bsp/u-boot/libubootenv_0.3.2.bb +1 -2
index 6774290ea5..cb59dd3f1d 100644
@@ -15,7 +15,7 @@ SRCREV = "ba7564f5006d09bec51058cf4f5ac90d4dc18b3c"
 
 S = "${WORKDIR}/git"
 
-inherit cmake lib_package
+inherit uboot-config cmake lib_package
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release"
 
--

2.31.1

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#2 lore raw
Quoted 20 lines · Otavio Salvador

I am against reverting it again. We discussed alternatives, which could solve the problem.

Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
<[email protected]> escreveu:

Quoted 15 lines

This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.

The original change was added to resolve build errors [1] for MACHINE values that don't have u-boot support. This recipe was, after that change, skipped in world builds for those MACHINEs.

But we should be able to build libubootenv with or without u-boot support [2] so the original solution to inherit uboot-config was not perfect. But until we have a better solution, revert this so builds don't fail for others.

[1] https://lists.openembedded.org/g/openembedded-core/message/153508
[2] https://lists.openembedded.org/g/openembedded-core/message/153614

Something needs to change. Perhaps the RRECOMMENDS should just be removed as that seems to be the cause of the problems?

Cheers,

Richard

#3 lore raw

Em sex., 23 de jul. de 2021 às 18:10, Richard Purdie <[email protected]> escreveu:

Quoted 18 lines · Otavio Salvador
Quoted 17 lines

I am against reverting it again. We discussed alternatives, which could solve the problem.

Em qui., 22 de jul. de 2021 às 21:19, Anuj Mittal
<[email protected]> escreveu:

Quoted 12 lines

This reverts commit be1cf223bf9c514ee81820ded5b13318458c0daf.

The original change was added to resolve build errors [1] for MACHINE values that don't have u-boot support. This recipe was, after that change, skipped in world builds for those MACHINEs.

But we should be able to build libubootenv with or without u-boot support [2] so the original solution to inherit uboot-config was not perfect. But until we have a better solution, revert this so builds don't fail for others.

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

[1] https://lists.openembedded.org/g/openembedded-core/message/153508
[2] https://lists.openembedded.org/g/openembedded-core/message/153614

Something needs to change. Perhaps the RRECOMMENDS should just be removed as that seems to be the cause of the problems?

I'd be fine in dropping it. This would be a better fix for sure.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750