tools/libxl: add missing blank in message
PATCH 1/1 tools/libxl: add missing blank in message
From: Alan Robinson <[email protected]>
Add trailing blank to first part of concatenated string giving "an emulated" instead of "anemulated".
--- tools/libs/light/libxl_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/libs/light/libxl_dm.c +2 -2
@@ -1893,7 +1893,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,if (format ==NULL ) {LOGD (WARN , guest_domid,"Unable to determine disk image format: %s\n" -"Disk will be available via PV drivers but not as an" +"Disk will be available via PV drivers but not as an " "emulated disk." , disks[i].vdev);continue ;
@@ -1905,7 +1905,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,if (!target_path) {LOGD (WARN , guest_domid,"No way to get local access disk to image: %s\n" -"Disk will be available via PV drivers but not as an" +"Disk will be available via PV drivers but not as an " "emulated disk." , disks[i].vdev);continue ;
Signature · 1 line
2.26.2
Quoted 15 lines · Alan Robinson
From: Alan Robinson <[email protected]>
Add trailing blank to first part of concatenated string giving "an emulated" instead of "anemulated".
Signed-off-by Alan Robinson <[email protected]>--- tools/libs/light/libxl_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/libs/light/libxl_dm.c +0
-0
tools/libs/light/libxl_dm.c static int libxl__build_device_model_args_new(libxl__gc *gc, · line 1897
Quoted 6 lines
tools/libs/light/libxl_dm.c +1
-1@@ -1893,7 +1893,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,if (format ==NULL ) { LOGD(WARN, guest_domid, "Unable to determine disk image format: %s\n" - "Disk will be available via PV drivers but not as an" + "Disk will be available via PV drivers but not as an " "emulated disk.",
I'd rather have a longer line without splitting the message (splitting after the '\n' is fine, of course). This will make it easier to find the coding emitting the message when searching for the whole printed line.
Juergen
Ian Jackson
Acked-byJuergen Gross writes ("Re: [PATCH] tools/libxl: add missing blank in message"):
Quoted 5 lines · Alan Robinson
Quoted 4 lines
From: Alan Robinson <[email protected]>
Add trailing blank to first part of concatenated string giving "an emulated" instead of "anemulated".
Alan, thanks:
and queued.
Quoted 7 lines
tools/libs/light/libxl_dm.c static int libxl__build_device_model_args_new(libxl__gc *gc, · line 1897
Quoted 3 lines
tools/libs/light/libxl_dm.c +1
-1-"Disk will be available via PV drivers but not as an" +"Disk will be available via PV drivers but not as an " "emulated disk.",I'd rather have a longer line without splitting the message (splitting after the '\n' is fine, of course). This will make it easier to find the coding emitting the message when searching for the whole printed line.
I would be fine with this, and I can see how it is an improvement. However, Alan's patch is a step in the right direction so should go in right away.
Ian.