Skip to contentSkip to conversation

package/bluez5_utils: fix mesh build with musl

PATCH Applied Michael Nosthoff via buildroot 2 participants 3 messages Jul 23, 2021 – Jul 24, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/bluez5_utils: fix mesh build with musl

when compiling with mesh support and musl toolchain the build fails due to a missing include of limits.h for PATH_MAX in mesh-cfgtest.c.

Patch submitted upstream:
https://lore.kernel.org/linux-bluetooth/[email protected]

Fixes:
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/

---
 ...-tools-mesh-cfgtest-include-limits.h.patch | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch
package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch new file +32 -0
new file mode 100644
index 0000000000..8f40a94873
@@ -0,0 +1,32 @@
+From 5158827fded7cb4daf550a5956aff0c74f6c38fc Mon Sep 17 00:00:00 2001
+From: Michael Nosthoff <[email protected]>
+Date: Thu, 22 Jul 2021 21:36:13 +0200
+Subject: [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
+
+mesh-cfgtest.c uses PATH_MAX so it should include limits.h.
+
+fixes compilation error when enabling mesh support with musl-based
+toolchains observed in buildroot autobuilders.
+
+http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
+http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/
+
+---
+ tools/mesh-cfgtest.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
+index fa0474faa..116ab7f16 100644
+--- a/tools/mesh-cfgtest.c
++++ b/tools/mesh-cfgtest.c
+@@ -21,6 +21,7 @@
+ #include <ftw.h>
+ #include <getopt.h>
+ #include <libgen.h>
++#include <limits.h>
+ #include <signal.h>
+ #include <stdio.h>
+ #include <time.h>
+-- 
+2.32.0
+
Signature · 6 lines
2.32.0

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw
Quoted 6 lines · Michael Nosthoff via buildroot

when compiling with mesh support and musl toolchain the build fails due to a missing include of limits.h for PATH_MAX in mesh-cfgtest.c.

Patch submitted upstream:
https://lore.kernel.org/linux-bluetooth/[email protected]

Quoted 6 lines

Fixes:
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/

---

Forgot to add a changelog.

v2 just has an updated description (patch and commit) because I mixed up PATH_MAX and MAX_PATH...

Regards,
Michael

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw
In reply to Michael Nosthoff via buildroot
Quoted 10 lines · On Fri, 23 Jul 2021 15:26:46 +0200 Michael Nosthoff via buildroot…

when compiling with mesh support and musl toolchain the build fails due to a missing include of limits.h for PATH_MAX in mesh-cfgtest.c.

Patch submitted upstream:
https://lore.kernel.org/linux-bluetooth/[email protected]

Fixes:
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/

Quoted 5 lines
---
 ...-tools-mesh-cfgtest-include-limits.h.patch | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/bluez5_utils/0001-tools-mesh-cfgtest-include-limits.h.patch

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot