ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells
Subsystems (4)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells
Since commit dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node") the following W=1 dtc warnings are seen:
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Remove the unnecessary mdio #address-cells/#size-cells to fix it.
---
Hi,
I am targetting net-next because this is where the offending patch was applied.
arch/arm/boot/dts/imx6q-novena.dts | 3 --- arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 3 --- arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi | 3 --- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 3 --- arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 3 --- arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 3 --- 6 files changed, 18 deletions(-)
arch/arm/boot/dts/imx6q-novena.dts +0 -3
@@ -227,9 +227,6 @@ &fec { status = "okay"; mdio { - #address-cells = <1>; - #size-cells = <0>; - ethphy: ethernet-phy { compatible = "ethernet-phy-ieee802.3-c22"; rxc-skew-ps = <3000>;
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi +0 -3
@@ -321,9 +321,6 @@ &fec { status = "okay"; mdio { - #address-cells = <1>; - #size-cells = <0>; - ethphy: ethernet-phy { compatible = "ethernet-phy-ieee802.3-c22"; txd0-skew-ps = <0>;
arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi +0 -3
@@ -198,9 +198,6 @@ &fec { status = "okay"; mdio { - #address-cells = <1>; - #size-cells = <0>; - ethphy: ethernet-phy { compatible = "ethernet-phy-ieee802.3-c22"; txen-skew-ps = <0>;
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +0 -3
@@ -340,9 +340,6 @@ &fec { status = "okay"; mdio { - #address-cells = <1>; - #size-cells = <0>; - ethphy: ethernet-phy { compatible = "ethernet-phy-ieee802.3-c22"; txen-skew-ps = <0>;
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi +0 -3
@@ -273,9 +273,6 @@ &fec { status = "okay"; mdio { - #address-cells = <1>; - #size-cells = <0>; - ethphy: ethernet-phy { compatible = "ethernet-phy-ieee802.3-c22"; txen-skew-ps = <0>;
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi +0 -3
@@ -329,9 +329,6 @@ &fec { status = "okay"; mdio { - #address-cells = <1>; - #size-cells = <0>; - ethphy: ethernet-phy { compatible = "ethernet-phy-ieee802.3-c22"; txen-skew-ps = <0>;
Signature · 1 line
2.25.1
Hi Fabio,
Quoted 10 lines · Fabio Estevam
Since commit
dabb5db17c06("ARM: dts: imx6qdl: move phy properties into phy device node") the following W=1 dtc warnings are seen:arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (
avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" propertyRemove the unnecessary mdio #address-cells/#size-cells to fix it.
Fixes dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")Signed-off-by Fabio Estevam <[email protected]>---
Are you actually sure this is the correct fix? If I look at mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If it did, then it wouldn't warn about #address-cells.
Fabio Estevam
reviewerHi Vladimr,
Quoted 4 lines · Vladimir Oltean
Are you actually sure this is the correct fix? If I look at
mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If it did, then it wouldn't warn about #address-cells.
Thanks for reviewing it.
After double-checking I realize that the correct fix would be to pass the phy address, like:
phy: ethernet-phy@1 {
reg = <1>;
Since the Ethernet PHY address is design dependant, I can not make the fix myself.
I will try to ping the board maintainers for passing the correct phy address.
Thanks
Quoted 17 lines · Fabio Estevam
Hi Vladimr,
Quoted 4 lines · Vladimir Oltean
Are you actually sure this is the correct fix? If I look at
mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If it did, then it wouldn't warn about #address-cells.Thanks for reviewing it.
After double-checking I realize that the correct fix would be to pass the phy address, like:
phy: ethernet-phy@1 {
reg = <1>;
Quoted 6 lines
Since the Ethernet PHY address is design dependant, I can not make the fix myself.
I will try to ping the board maintainers for passing the correct phy address.
Thanks
Normally you should have been able to make all PHY addresses be 0. That is the MDIO "broadcast address" and if there's a single PHY on the bus, it should respond to that.
Citation:
IEEE 802.3-2015:
22.2.4.5.5 PHYAD (PHY Address)
The PHY Address is five bits, allowing 32 unique PHY addresses. The first PHY address bit transmitted and received is the MSB of the address. A PHY that is connected to the station management entity via the mechanical interface defined in 22.6 shall always respond to transactions addressed to PHY Address zero <00000>. A station management entity that is attached to multiple PHYs must have prior knowledge of the appropriate PHY Address for each PHY.
However, if you google "MDIO broadcast address", you'll find all sorts of funny reports of buggy PHYs not adhering to that clause, under all sorts of pretexts...
Hi Fabio,
Quoted 27 lines
-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: 2021年7月23日 21:16
To: Vladimir Oltean <[email protected]>
Cc: David S. Miller <[email protected]>; Shawn Guo <[email protected]>; moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <[email protected]>; Joakim Zhang <[email protected]>; Rob Herring <[email protected]>; netdev <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>
Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cellsHi Vladimr,
Quoted 4 lines · Vladimir Oltean
Are you actually sure this is the correct fix? If I look at
mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If it did, then it wouldn't warn about #address-cells.Thanks for reviewing it.
After double-checking I realize that the correct fix would be to pass the phy address, like:
Quoted 7 lines
phy: ethernet-phy@1 {
reg = <1>;Since the Ethernet PHY address is design dependant, I can not make the fix myself.
I will try to ping the board maintainers for passing the correct phy address.
Thanks.
I prepare this patch to fix dtbs_check when convert fec binding into schema.
I realized that we need a "reg" under phy device node, but I also don't know how to add it since the phy is obviously not on board. And I check the phy code, it supports auto scan for PHYs with empty "reg" property.
Best Regards,
Joakim Zhang
Quoted 1 line
Thanks
Fabio Estevam
reviewerHi Joakim and Vladimir,
Quoted 4 lines · Joakim Zhang
I prepare this patch to fix
dtbs_checkwhen convert fec binding into schema.
I realized that we need a "reg" under phy device node, but I also don't know how to add it since the phy is obviously not on board. And I check the phy code, it supports auto scan for PHYs with empty "reg" property.
I looked in the U-Boot code for the nitrogenx6x board:
https://source.denx.de/u-boot/u-boot/-/blob/master/board/boundary/nitrogen6x/nitrogen6x.c#L343-356
and it scans for a range of Ethernet PHY addresses.
As we can't pass a reg property in the dts in this case, the patch I sent that removes the
#address-cells/#size-cells properties looks good, right?
What do you think?
Quoted 10 lines · Vladimir Oltean
Hi Fabio,
Quoted 7 lines · Fabio Estevam
Since commit
dabb5db17c06("ARM: dts: imx6qdl: move phy properties into phy device node") the following W=1 dtc warnings are seen:arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (
avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" propertyRemove the unnecessary mdio #address-cells/#size-cells to fix it.
Quoted 7 lines
Quoted 3 lines
Fixes dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")Signed-off-by Fabio Estevam <[email protected]>---
Are you actually sure this is the correct fix? If I look at
mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If
It is valid to omit the "reg" property of an Ethernet PHY which the kernel will then dynamically scan for. If you know the Ethernet PHY address it's obviously better to set it so you avoid scanning and the time spent in doing that. The boot loader could (should?) also provide that information to the kernel for the same reasons.
Signature · 1 line
Florian
Quoted 19 lines · Florian Fainelli
Quoted 10 lines · Vladimir Oltean
Hi Fabio,
Quoted 7 lines · Fabio Estevam
Since commit
dabb5db17c06("ARM: dts: imx6qdl: move phy properties into phy device node") the following W=1 dtc warnings are seen:arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (
avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" propertyRemove the unnecessary mdio #address-cells/#size-cells to fix it.
Quoted 7 lines
Quoted 3 lines
Fixes dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")Signed-off-by Fabio Estevam <[email protected]>---
Are you actually sure this is the correct fix? If I look at
mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. If
Quoted 5 lines
It is valid to omit the "reg" property of an Ethernet PHY which the kernel will then dynamically scan for. If you know the Ethernet PHY address it's obviously better to set it so you avoid scanning and the time spent in doing that. The boot loader could (should?) also provide that information to the kernel for the same reasons.
Interesting, but brittle I suppose (it only works reliably with a single PHY on a shared MDIO bus). NXP has "QDS" boards for internal development and these have multi-port riser cards with various PHYs for various SERDES protocols, and we have a really hard time describing the hardware in DT (we currently use overlays applied by U-Boot), so we would like some sort of auto-detection of PHYs if that was possible, but I think that for anything except the simplest of cases it isn't. For example what happens if you unbind and rebind two net devices in a different order - they will connect to a PHY at a different address, won't they?
Anyway, I was wrong, ok, but I think the point still stands that according to mdio.yaml this DT description is not valid. So after your explanation, it is the DT schema that we should update.
Quoted 26 lines · Vladimir Oltean
Quoted 19 lines · Florian Fainelli
Quoted 10 lines · Vladimir Oltean
Hi Fabio,
Quoted 7 lines · Fabio Estevam
Since commit
dabb5db17c06("ARM: dts: imx6qdl: move phy properties into phy device node") the following W=1 dtc warnings are seen:arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi:323.7-334.4: Warning (
avoid_unnecessary_addr_size): /soc/bus@2100000/ethernet@2188000/mdio: unnecessary #address-cells/#size-cells without "ranges" or child "reg" propertyRemove the unnecessary mdio #address-cells/#size-cells to fix it.
Quoted 7 lines
Quoted 3 lines
Fixes dabb5db17c06 ("ARM: dts: imx6qdl: move phy properties into phy device node")Signed-off-by Fabio Estevam <[email protected]>---
Are you actually sure this is the correct fix? If I look at
mdio.yaml, I think it is pretty clear that the "ethernet-phy" subnode of the MDIO controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. IfQuoted 5 lines
It is valid to omit the "reg" property of an Ethernet PHY which the kernel will then dynamically scan for. If you know the Ethernet PHY address it's obviously better to set it so you avoid scanning and the time spent in doing that. The boot loader could (should?) also provide that information to the kernel for the same reasons.
Quoted 9 lines
Interesting, but brittle I suppose (it only works reliably with a single PHY on a shared MDIO bus). NXP has "QDS" boards for internal development and these have multi-port riser cards with various PHYs for various SERDES protocols, and we have a really hard time describing the hardware in DT (we currently use overlays applied by U-Boot), so we would like some sort of auto-detection of PHYs if that was possible, but I think that for anything except the simplest of cases it isn't. For example what happens if you unbind and rebind two net devices in a different order - they will connect to a PHY at a different address, won't they?
Oh yes, it is fraught with peril in most cases, however for some simple cases like dedicated MDIO bus and single Ethernet PHY on the bus this works quite nicely. We have a bunch of reference boards that allow us to connect either a MTSIF or RGMII daughter card and we scan the MDIO bus in the boot loader if the networking stack is initialized (in which case the DT gets patched accordingly), else, we leave it to Linux to probe for the PHY.
Quoted 4 lines
Anyway, I was wrong, ok, but I think the point still stands that according to
mdio.yamlthis DT description is not valid. So after your explanation, it is the DT schema that we should update.
Yes, the "reg" property is technically optional, however #address-cells and #size-cells are not, or rather they only are useful if "reg" is provided so it can be checked accordingly, humm.
Signature · 1 line
Florian