Skip to contentSkip to conversation

reset: ast2600: Fix missing reference operator

PATCH In review Chia-Wei Wang 2 participants 2 messages Jul 20, 2021 – Jul 24, 2021 Reset controller framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: ast2600: Fix missing reference operator

Fix missing reference operator '&' to correctly get HW register addresses for writel().

---
 drivers/reset/reset-ast2600.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/reset/reset-ast2600.c +4 -4
index f64adaf74e..195ddd18e0 100644
@@ -41,9 +41,9 @@ static int ast2600_reset_assert(struct reset_ctl *reset_ctl)
 	debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
 
 	if (reset_ctl->id < 32)
-		writel(BIT(reset_ctl->id), scu->modrst_ctrl1);
+		writel(BIT(reset_ctl->id), &scu->modrst_ctrl1);
 	else
-		writel(BIT(reset_ctl->id - 32), scu->modrst_ctrl2);
+		writel(BIT(reset_ctl->id - 32), &scu->modrst_ctrl2);
 
 	return 0;
 }
@@ -56,9 +56,9 @@ static int ast2600_reset_deassert(struct reset_ctl *reset_ctl)
 	debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
 
 	if (reset_ctl->id < 32)
-		writel(BIT(reset_ctl->id), scu->modrst_clr1);
+		writel(BIT(reset_ctl->id), &scu->modrst_clr1);
 	else
-		writel(BIT(reset_ctl->id - 32), scu->modrst_clr2);
+		writel(BIT(reset_ctl->id - 32), &scu->modrst_clr2);
 
 	return 0;
 }
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Chia-Wei Wang

Fix missing reference operator '&' to correctly get HW register addresses for writel().

Applied to u-boot/master, thanks!

Signature · 1 line
Tom