arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Subsystems (2)
PATCH 1/4 arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +12 -0
@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; + +&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 2/4 arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config
Fix various MP5416 PMIC configurations:
- Update regulator names per dt-bindings
- ensure values fit among valid register values
- add required regulator-max-microamp property
- add regulator-always-on prop
--- .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++------- 1 file changed, 37 insertions(+), 19 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +37 -19
@@ -283,65 +283,83 @@ reg = <0x69>; regulators { + /* vdd_0p95: DRAM/GPU/VPU */ buck1 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <805000>; + regulator-name = "buck1"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2500000>; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_soc */ buck2 { - regulator-name = "vdd_soc"; - regulator-min-microvolt = <805000>; + regulator-name = "buck2"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; - regulator-max-microamp = <1000000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_arm */ buck3_reg: buck3 { - regulator-name = "vdd_arm"; - regulator-min-microvolt = <805000>; + regulator-name = "buck3"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2200000>; - regulator-boot-on; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; + regulator-always-on; }; + /* vdd_1p8 */ buck4 { - regulator-name = "vdd_1p8"; + regulator-name = "buck4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <500000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* nvcc_snvs_1p8 */ ldo1 { - regulator-name = "nvcc_snvs_1p8"; + regulator-name = "ldo1"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <300000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_snvs_0p8 */ ldo2 { - regulator-name = "vdd_snvs_0p8"; + regulator-name = "ldo2"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_0p9 */ ldo3 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <800000>; + regulator-name = "ldo3"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <900000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_1p8 */ ldo4 { - regulator-name = "vdd_1p8"; + regulator-name = "ldo4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; }; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 2/4] arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config
Quoted 120 lines · Tim Harvey
Fix various MP5416 PMIC configurations:
- Update regulator names per dt-bindings
- ensure values fit among valid register values
- add required regulator-max-microamp property
- add regulator-always-on propSigned-off-by Tim Harvey <[email protected]>--- .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++------- 1 file changed, 37 insertions(+), 19 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +37
-20@@ -283,65 +283,83 @@ reg = <0x69>; regulators { + /* vdd_0p95: DRAM/GPU/VPU */ buck1 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <805000>; + regulator-name = "buck1"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2500000>; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_soc */ buck2 { - regulator-name = "vdd_soc"; - regulator-min-microvolt = <805000>; + regulator-name = "buck2"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; - regulator-max-microamp = <1000000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_arm */ buck3_reg: buck3 { - regulator-name = "vdd_arm"; - regulator-min-microvolt = <805000>; + regulator-name = "buck3"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2200000>; - regulator-boot-on; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; + regulator-always-on; }; + /* vdd_1p8 */ buck4 { - regulator-name = "vdd_1p8"; + regulator-name = "buck4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <500000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* nvcc_snvs_1p8 */ ldo1 { - regulator-name = "nvcc_snvs_1p8"; + regulator-name = "ldo1"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <300000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_snvs_0p8 */ ldo2 { - regulator-name = "vdd_snvs_0p8"; + regulator-name = "ldo2"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_0p9 */ ldo3 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <800000>; + regulator-name = "ldo3"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <900000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_1p8 */ ldo4 { - regulator-name = "vdd_1p8"; + regulator-name = "ldo4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; }; }; --
Quoted 2 lines
2.17.1
Shawn,
Is there anything you want changed here?
Best regards,
Tim
Re: [PATCH 2/4] arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config
Quoted 126 lines · Tim Harvey
Quoted 120 lines · Tim Harvey
Fix various MP5416 PMIC configurations:
- Update regulator names per dt-bindings
- ensure values fit among valid register values
- add required regulator-max-microamp property
- add regulator-always-on propSigned-off-by Tim Harvey <[email protected]>--- .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++------- 1 file changed, 37 insertions(+), 19 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +37
-20@@ -283,65 +283,83 @@ reg = <0x69>; regulators { + /* vdd_0p95: DRAM/GPU/VPU */ buck1 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <805000>; + regulator-name = "buck1"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2500000>; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_soc */ buck2 { - regulator-name = "vdd_soc"; - regulator-min-microvolt = <805000>; + regulator-name = "buck2"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; - regulator-max-microamp = <1000000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_arm */ buck3_reg: buck3 { - regulator-name = "vdd_arm"; - regulator-min-microvolt = <805000>; + regulator-name = "buck3"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2200000>; - regulator-boot-on; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; + regulator-always-on; }; + /* vdd_1p8 */ buck4 { - regulator-name = "vdd_1p8"; + regulator-name = "buck4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <500000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* nvcc_snvs_1p8 */ ldo1 { - regulator-name = "nvcc_snvs_1p8"; + regulator-name = "ldo1"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <300000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_snvs_0p8 */ ldo2 { - regulator-name = "vdd_snvs_0p8"; + regulator-name = "ldo2"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_0p9 */ ldo3 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <800000>; + regulator-name = "ldo3"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <900000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_1p8 */ ldo4 { - regulator-name = "vdd_1p8"; + regulator-name = "ldo4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; }; }; --Quoted 2 lines
2.17.1
Shawn,
Quoted 1 line
Is there anything you want changed here?
Tim,
Could you resend the series? For some reason, I cannot find the original posting in my mailbox.
Shawn
Re: [PATCH 2/4] arm64: dts: imx8mm-venice-gw700x: fix mp5416 pmic config
Quoted 128 lines · Shawn Guo
Quoted 126 lines · Tim Harvey
Quoted 120 lines · Tim Harvey
Fix various MP5416 PMIC configurations:
- Update regulator names per dt-bindings
- ensure values fit among valid register values
- add required regulator-max-microamp property
- add regulator-always-on propSigned-off-by Tim Harvey <[email protected]>--- .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++------- 1 file changed, 37 insertions(+), 19 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +37
-20@@ -283,65 +283,83 @@ reg = <0x69>; regulators { + /* vdd_0p95: DRAM/GPU/VPU */ buck1 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <805000>; + regulator-name = "buck1"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2500000>; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_soc */ buck2 { - regulator-name = "vdd_soc"; - regulator-min-microvolt = <805000>; + regulator-name = "buck2"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <900000>; - regulator-max-microamp = <1000000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_arm */ buck3_reg: buck3 { - regulator-name = "vdd_arm"; - regulator-min-microvolt = <805000>; + regulator-name = "buck3"; + regulator-min-microvolt = <800000>; regulator-max-microvolt = <1000000>; - regulator-max-microamp = <2200000>; - regulator-boot-on; + regulator-min-microamp = <3800000>; + regulator-max-microamp = <6800000>; + regulator-always-on; }; + /* vdd_1p8 */ buck4 { - regulator-name = "vdd_1p8"; + regulator-name = "buck4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <500000>; + regulator-min-microamp = <2200000>; + regulator-max-microamp = <5200000>; regulator-boot-on; + regulator-always-on; }; + /* nvcc_snvs_1p8 */ ldo1 { - regulator-name = "nvcc_snvs_1p8"; + regulator-name = "ldo1"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-max-microamp = <300000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_snvs_0p8 */ ldo2 { - regulator-name = "vdd_snvs_0p8"; + regulator-name = "ldo2"; regulator-min-microvolt = <800000>; regulator-max-microvolt = <800000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_0p9 */ ldo3 { - regulator-name = "vdd_0p95"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <800000>; + regulator-name = "ldo3"; + regulator-min-microvolt = <900000>; + regulator-max-microvolt = <900000>; regulator-boot-on; + regulator-always-on; }; + /* vdd_1p8 */ ldo4 { - regulator-name = "vdd_1p8"; + regulator-name = "ldo4"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-boot-on; + regulator-always-on; }; }; }; --Quoted 2 lines
2.17.1
Shawn,
Quoted 8 lines
Quoted 1 line
Is there anything you want changed here?
Tim,
Could you resend the series? For some reason, I cannot find the original posting in my mailbox.
Shawn
Sure... probably better anyway as I was asking you to drop one of them from the series.
Tim
PATCH 3/4 arm64: dts: imx8mm-venice-gw7901: add support for USB hub subload
In reply to Tim HarveyThe USB hub has it's reset as GPIO4_IO17 but can be sub-loaded and VBUS provided by a VBUS regulator with GPIO4_IO2 as the enable and GPIO1_IO15 as the active-low over-current.
Enable pull-up for GPIO4_IO17 to keep hub out of reset and move VBUS enable to GPIO4_IO2. Additionally enable pull-up on GPIO1_IO15 so that if the hub is loaded it never over-currents.
This allows USB to work in both configurations without a device-tree change.
--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +4 -3
@@ -216,7 +216,7 @@ pinctrl-0 = <&pinctrl_reg_usb2>; compatible = "regulator-fixed"; regulator-name = "usb_usb2_vbus"; - gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>; + gpio = <&gpio4 2 GPIO_ACTIVE_HIGH>; enable-active-high; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>;
@@ -824,8 +824,9 @@ pinctrl_reg_usb2: regusb1grp { fsl,pins = < - MX8MM_IOMUXC_SAI1_TXD5_GPIO4_IO17 0x41 - MX8MM_IOMUXC_GPIO1_IO15_USB2_OTG_OC 0x41 + MX8MM_IOMUXC_SAI1_RXD0_GPIO4_IO2 0x41 + MX8MM_IOMUXC_SAI1_TXD5_GPIO4_IO17 0x140 + MX8MM_IOMUXC_GPIO1_IO15_USB2_OTG_OC 0x140 >; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 3/4] arm64: dts: imx8mm-venice-gw7901: add support for USB hub subload
Quoted 43 lines · Tim Harvey
The USB hub has it's reset as
GPIO4_IO17but can be sub-loaded and VBUS provided by a VBUS regulator withGPIO4_IO2as the enable andGPIO1_IO15as the active-low over-current.Enable pull-up for
GPIO4_IO17to keep hub out of reset and move VBUS enable toGPIO4_IO2. Additionally enable pull-up onGPIO1_IO15so that if the hub is loaded it never over-currents.This allows USB to work in both configurations without a device-tree change.
Signed-off-by Tim Harvey <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +4
-4@@ -216,7 +216,7 @@ pinctrl-0 = <&pinctrl_reg_usb2>; compatible = "regulator-fixed"; regulator-name = "usb_usb2_vbus"; - gpio = <&gpio4 17 GPIO_ACTIVE_HIGH>; + gpio = <&gpio4 2 GPIO_ACTIVE_HIGH>; enable-active-high; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>;@@ -824,8 +824,9 @@ pinctrl_reg_usb2: regusb1grp { fsl,pins = < - MX8MM_IOMUXC_SAI1_TXD5_GPIO4_IO17 0x41 - MX8MM_IOMUXC_GPIO1_IO15_USB2_OTG_OC 0x41 + MX8MM_IOMUXC_SAI1_RXD0_GPIO4_IO2 0x41 + MX8MM_IOMUXC_SAI1_TXD5_GPIO4_IO17 0x140 + MX8MM_IOMUXC_GPIO1_IO15_USB2_OTG_OC 0x140 >; }; --
Quoted 2 lines
2.17.1
Shawn,
Is there anything you want changed here?
Best regards,
Tim
PATCH 4/4 arm64: dts: imx8mm-venice-gw7901: enable pull-down on gpio outputs
In reply to Tim HarveyEnable internal pull-down on UART transceiver GPIO config pins.
--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +3 -3
@@ -877,9 +877,9 @@ pinctrl_uart3_gpio: uart3gpiogrp { fsl,pins = < - MX8MM_IOMUXC_SAI1_RXD4_GPIO4_IO6 0x40000041 /* RS232# */ - MX8MM_IOMUXC_SAI1_RXD5_GPIO4_IO7 0x40000041 /* RS422# */ - MX8MM_IOMUXC_SAI1_RXD6_GPIO4_IO8 0x40000041 /* RS485# */ + MX8MM_IOMUXC_SAI1_RXD4_GPIO4_IO6 0x40000110 /* RS232# */ + MX8MM_IOMUXC_SAI1_RXD5_GPIO4_IO7 0x40000110 /* RS422# */ + MX8MM_IOMUXC_SAI1_RXD6_GPIO4_IO8 0x40000110 /* RS485# */ >; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 4/4] arm64: dts: imx8mm-venice-gw7901: enable pull-down on gpio outputs
Quoted 26 lines · Tim Harvey
Enable internal pull-down on UART transceiver GPIO config pins.
Signed-off-by Tim Harvey <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +3
-4@@ -877,9 +877,9 @@ pinctrl_uart3_gpio: uart3gpiogrp { fsl,pins = < - MX8MM_IOMUXC_SAI1_RXD4_GPIO4_IO6 0x40000041 /* RS232# */ - MX8MM_IOMUXC_SAI1_RXD5_GPIO4_IO7 0x40000041 /* RS422# */ - MX8MM_IOMUXC_SAI1_RXD6_GPIO4_IO8 0x40000041 /* RS485# */ + MX8MM_IOMUXC_SAI1_RXD4_GPIO4_IO6 0x40000110 /* RS232# */ + MX8MM_IOMUXC_SAI1_RXD5_GPIO4_IO7 0x40000110 /* RS422# */ + MX8MM_IOMUXC_SAI1_RXD6_GPIO4_IO8 0x40000110 /* RS485# */ >; }; --
Quoted 2 lines
2.17.1
Shawn,
Is there anything you want changed here?
Best regards,
Tim
Quoted 18 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +2
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 {
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +10
-0+ temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; + +&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};
As this is not really board-specific, I think the proper way to handle this for all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 33 lines · Frieder Schrempf
Quoted 18 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +2
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 {arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +10
-0+ temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; + +&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Frieder,
Yes, I thought about adding that kind of support to imx8mm_thermal.c but the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Best regards,
Tim
Quoted 45 lines · Tim Harvey
Quoted 33 lines · Frieder Schrempf
Quoted 18 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +2
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 {arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +10
-0+ temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; + +&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?
Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
What if we just set the temperature property in the trip nodes in imx8mm.dtsi to zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.
I think this solution would be covering all needs.
Quoted 44 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 10 lines · Tim Harvey
Quoted 8 lines · Frieder Schrempf
Quoted 6 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12++++++++++++
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
1 file changed, 12 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +6
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +};Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +6
-0+ +&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for
all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Quoted 1 line
...
Quoted 17 lines
Quoted 9 lines
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
Quoted 7 lines
What if we just set the temperature property in the trip nodes in
imx8mm.dtsito zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.I think this solution would be covering all needs.
I thought to add the grading check in the imx8mm_thermal.c to dynamically set the trip points temp, but it seems hard to do it due to the fact of_thermal is used, as no helper API is exported by of_thermal, no better way to override the trip point temp.
glad to see any good suggestions.
BR
Jacky Bai
Quoted 68 lines · Jacky Bai
Quoted 44 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 10 lines · Tim Harvey
Quoted 8 lines · Frieder Schrempf
Quoted 6 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12++++++++++++
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
1 file changed, 12 insertions(+)arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +6
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +};Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +6
-0+ +&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for
all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Quoted 1 line
...
Quoted 23 lines
Quoted 9 lines
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
What if we just set the temperature property in the trip nodes in
imx8mm.dtsito zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.
Quoted 7 lines
Quoted 1 line
I think this solution would be covering all needs.
I thought to add the grading check in the
imx8mm_thermal.cto dynamically set the trip points temp, but it seems hard to do it due to the factof_thermalis used, as no helper API is exported byof_thermal, no better way to override the trip point temp.glad to see any good suggestions.
Right, the driver doesn't handle the trip-points directly. This is all hidden in the framework. So this might not be so easy to implement.
What about this other approach: Adding all the possible trip-points for the different gradings to the SoC-devicetree and then let the thermal driver remove the trip nodes from the dt that are not valid for the detected grading, just before the driver registers the sensor/zone.
Quoted 83 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 70 lines · Jacky Bai
Quoted 46 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 10 lines · Tim Harvey
Quoted 8 lines · Frieder Schrempf
Quoted 6 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12++++++++++++
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
1 file changed, 12 insertions(+)diff --git
a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsib/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsiindexc769fadbd008..512b76cd7c3b100644arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +7
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; +Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +5
-0+&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for
all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Quoted 1 line
...
Quoted 23 lines
Quoted 9 lines
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
What if we just set the temperature property in the trip nodes in
imx8mm.dtsito zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.Quoted 5 lines
Quoted 1 line
I think this solution would be covering all needs.
I thought to add the grading check in the
imx8mm_thermal.cto dynamically set the trip points temp, but it seems hard to do it due to the factof_thermalis used, as no helper API is exported byof_thermal,no better way to override the trip point temp.
Quoted 2 lines
glad to see any good suggestions.
Quoted 7 lines
Right, the driver doesn't handle the trip-points directly. This is all hidden in the framework. So this might not be so easy to implement.
What about this other approach: Adding all the possible trip-points for the different gradings to the SoC-devicetree and then let the thermal driver remove the trip nodes from the dt that are not valid for the detected grading, just before the driver registers the sensor/zone.
It is more reasonable for the firmware/bootloader to handle this by checking the grading.
BR
Jacky Bai
Quoted 86 lines · Jacky Bai
Quoted 86 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 70 lines · Jacky Bai
Quoted 46 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 10 lines · Tim Harvey
Quoted 8 lines · Frieder Schrempf
Quoted 6 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12++++++++++++
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
1 file changed, 12 insertions(+)diff --git
a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsib/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsiindexc769fadbd008..512b76cd7c3b100644arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +7
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; +Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +5
-0+&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for
all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Quoted 1 line
...
Quoted 23 lines
Quoted 9 lines
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
What if we just set the temperature property in the trip nodes in
imx8mm.dtsito zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.Quoted 5 lines
Quoted 1 line
I think this solution would be covering all needs.
I thought to add the grading check in the
imx8mm_thermal.cto dynamically set the trip points temp, but it seems hard to do it due to the factof_thermalis used, as no helper API is exported byof_thermal,no better way to override the trip point temp.
Quoted 2 lines
glad to see any good suggestions.
Right, the driver doesn't handle the trip-points directly. This is all hidden in the framework. So this might not be so easy to implement.
Quoted 6 lines
Quoted 4 lines
What about this other approach: Adding all the possible trip-points for the different gradings to the SoC-devicetree and then let the thermal driver remove the trip nodes from the dt that are not valid for the detected grading, just before the driver registers the sensor/zone.
It is more reasonable for the
firmware/bootloaderto handle this by checking the grading.
If possible, I would rather like to avoid creating another dependency on bootloader/firmware. I think the kernel should be able to detect the grading by itself and adjust its behavior accordingly. We also do this for the speed grading in cpufreq.
Quoted 88 lines · Frieder Schrempf
Quoted 86 lines · Jacky Bai
Quoted 86 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 70 lines · Jacky Bai
Quoted 46 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 10 lines · Tim Harvey
Quoted 8 lines · Frieder Schrempf
Quoted 6 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12++++++++++++
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
1 file changed, 12 insertions(+)diff --git
a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsib/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsiindexc769fadbd008..512b76cd7c3b100644arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +7
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; +Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +5
-0+&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for
all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Quoted 1 line
...
Quoted 23 lines
Quoted 9 lines
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
What if we just set the temperature property in the trip nodes in
imx8mm.dtsito zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.Quoted 5 lines
Quoted 1 line
I think this solution would be covering all needs.
I thought to add the grading check in the
imx8mm_thermal.cto dynamically set the trip points temp, but it seems hard to do it due to the factof_thermalis used, as no helper API is exported byof_thermal,no better way to override the trip point temp.
Quoted 2 lines
glad to see any good suggestions.
Right, the driver doesn't handle the trip-points directly. This is all hidden in the framework. So this might not be so easy to implement.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
What about this other approach: Adding all the possible trip-points for the different gradings to the SoC-devicetree and then let the thermal driver remove the trip nodes from the dt that are not valid for the detected grading, just before the driver registers the sensor/zone.
It is more reasonable for the
firmware/bootloaderto handle this by checking the grading.If possible, I would rather like to avoid creating another dependency on bootloader/firmware. I think the kernel should be able to detect the grading by itself and adjust its behavior accordingly. We also do this for the speed grading in cpufreq.
Frieder and Jacky,
I'm ok with dropping this dt patch and instead implementing something in boot firmware that automatically detects and adjusts there. I'm not given the time to work through a more complicated or more elegant solution kernel-only approach for this and handling it in the boot firmware will not break anything or create a dependence from where we currently stand. We already have things in boot firmware that populate mac addresses, mtd partition ids, etc in dt during runtime.
Best regards,
Tim
Hi Tim,
Quoted 101 lines · Tim Harvey
Quoted 88 lines · Frieder Schrempf
Quoted 86 lines · Jacky Bai
Quoted 86 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 70 lines · Jacky Bai
Quoted 46 lines
Subject: Re: [PATCH 1/4] arm64: dts: imx8mm-venice-gw700x: override thermal cfg for industrial temp
Quoted 10 lines · Tim Harvey
Quoted 8 lines · Frieder Schrempf
Quoted 6 lines · Tim Harvey
Override the default temperature alert/crit for Industrial temp IMX8M Mini.
Signed-off-by Tim Harvey <[email protected]>--- .../boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 12++++++++++++
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
1 file changed, 12 insertions(+)diff --git
a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsib/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsiindexc769fadbd008..512b76cd7c3b100644arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +7
-0@@ -493,3 +493,15 @@ >; }; }; + +&cpu_alert0 { + temperature = <95000>; + hysteresis = <2000>; + type = "passive"; +}; +Quoted 8 lines
Quoted 8 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi line 507
Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +5
-0+&cpu_crit0 { + temperature = <105000>; + hysteresis = <2000>; + type = "critical"; +};As this is not really board-specific, I think the proper way to handle this for
all boards is to let the thermal driver read the temperature grading from the OTP fuses and set the trip-points accordingly, similar to what is done on i.MX6 [1].
Quoted 1 line
Quoted 1 line
...
Quoted 23 lines
Quoted 9 lines
Frieder,
Yes, I thought about adding that kind of support to
imx8mm_thermal.cbut the difference is that imx8mm has alerts defined by dt and imx6 does not so is it right to override dt alerts on imx8m? What if someone designs a board that they specifically want a lower alert than the cpu grade they are using based on something else on the board?Quoted 3 lines
My approach to this was to eventually actually adjust the imx8m dt alerts in boot firmware based on some boot firmware setting or specific board support and leave the kernel alone.
Allowing board-specific trip points sounds like a valid request, but I still think we need a way to handle the temperature grading in the driver if no board-specific trip-points are given.
What if we just set the temperature property in the trip nodes in
imx8mm.dtsito zero? The thermal driver would detect this and setup the correct values according to the grading. If the dt already provides non-zero temperature values (through the board dts) the driver will just leave the values and disregard the grading.Quoted 5 lines
Quoted 1 line
I think this solution would be covering all needs.
I thought to add the grading check in the
imx8mm_thermal.cto dynamically set the trip points temp, but it seems hard to do it due to the factof_thermalis used, as no helper API is exported byof_thermal,no better way to override the trip point temp.
Quoted 2 lines
glad to see any good suggestions.
Right, the driver doesn't handle the trip-points directly. This is all hidden in the framework. So this might not be so easy to implement.
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
What about this other approach: Adding all the possible trip-points for the different gradings to the SoC-devicetree and then let the thermal driver remove the trip nodes from the dt that are not valid for the detected grading, just before the driver registers the sensor/zone.
It is more reasonable for the
firmware/bootloaderto handle this by checking the grading.If possible, I would rather like to avoid creating another dependency on bootloader/firmware. I think the kernel should be able to detect the grading by itself and adjust its behavior accordingly. We also do this for the speed grading in cpufreq.
Frieder and Jacky,
Quoted 7 lines
I'm ok with dropping this dt patch and instead implementing something in boot firmware that automatically detects and adjusts there. I'm not given the time to work through a more complicated or more elegant solution kernel-only approach for this and handling it in the boot firmware will not break anything or create a dependence from where we currently stand. We already have things in boot firmware that populate mac addresses, mtd partition ids, etc in dt during runtime.
From my point of view you can also keep this patch until this is solved properly. Still, in the long run I think we need a solution that automatically handles the different SoC temperature gradings even if of_thermal is used and there is only a single devicetree to describe the SoC variants. It's similar to the case of the CPU's frequency/voltage setpoints in cpufreq.
I'm Cc-ing people from the thermal subsystem. Maybe they have some suggestion or this case has already been discussed elsewhere.
Best regards
Frieder