powerpc/stacktrace: Include linux/delay.h
PATCH 1/1 powerpc/stacktrace: Include linux/delay.h
commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the functionshould be included nonetheless.
--- arch/powerpc/kernel/stacktrace.c | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/kernel/stacktrace.c +1 -0
@@ -12,6 +12,7 @@#include <linux/kallsyms.h> #include <linux/module.h> #include <linux/nmi.h> +#include <linux/delay.h> #include <linux/sched.h> #include <linux/sched/debug.h> #include <linux/sched/task_stack.h>
Signature · 1 line
2.26.2
Quoted 16 lines · Michal Suchanek
commit
7c6986ade69e("powerpc/stacktrace: Fix spurious "stale" traces inraise_backtrace_ipi()") introducesudelay()call without including thelinux/delay.hheader.
This may happen to work on master but the header that declares the functionshould be included nonetheless.Fixes 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")Signed-off-by Michal Suchanek <[email protected]>--- arch/powerpc/kernel/stacktrace.c | 1 + 1 file changed, 1 insertion(+)arch/powerpc/kernel/stacktrace.c +0
-0
arch/powerpc/kernel/stacktrace.c line 18
Quoted 7 lines
arch/powerpc/kernel/stacktrace.c +1
-0@@ -12,6 +12,7 @@#include <linux/kallsyms.h> #include <linux/module.h> #include <linux/nmi.h> +#include <linux/delay.h> #include <linux/sched.h> #include <linux/sched/debug.h> #include <linux/sched/task_stack.h>
Hmm, I believe we try to keep the list of includes sorted in alphabetical order.
Gabriel
PATCH 1/1 powerpc/stacktrace: Include linux/delay.h
In reply to Michal Suchanekcommit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the functionshould be included nonetheless.
---
V2: Add header in alphabetical order.
--- arch/powerpc/kernel/stacktrace.c | 1 + 1 file changed, 1 insertion(+)
arch/powerpc/kernel/stacktrace.c +1 -0
@@ -8,6 +8,7 @@* Copyright 2018 Nick Piggin, Michael Ellerman, IBM Corp. */ +#include <linux/delay.h> #include <linux/export.h> #include <linux/kallsyms.h> #include <linux/module.h>
Signature · 1 line
2.26.2
Michael Ellerman
AppliedQuoted 4 lines · Michal Suchanek
commit
7c6986ade69e("powerpc/stacktrace: Fix spurious "stale" traces inraise_backtrace_ipi()") introducesudelay()call without including thelinux/delay.hheader.
This may happen to work on master but the header that declares the functionshould be included nonetheless.
Applied to powerpc/next.
[1/1] powerpc/stacktrace: Include linux/delay.h
https://git.kernel.org/powerpc/c/135462ae7692a824e5b63299178684fca3a366e6
cheers