Skip to contentSkip to conversation

powerpc/stacktrace: Include linux/delay.h

PATCH In review Michal Suchanek 3 participants 4 messages Jul 26, 2021 – Aug 3, 2021 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/stacktrace: Include linux/delay.h

commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the functionshould be included nonetheless.

Fixes 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
---
 arch/powerpc/kernel/stacktrace.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/stacktrace.c +1 -0
index 2b0d04a1b7d2..a17ac10f86b1 100644
@@ -12,6 +12,7 @@
 #include <linux/kallsyms.h>
 #include <linux/module.h>
 #include <linux/nmi.h>
+#include <linux/delay.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task_stack.h>
Signature · 1 line
2.26.2
#1 lore raw
Quoted 16 lines · Michal Suchanek

commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the functionshould be included nonetheless.

Fixes 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")
---
 arch/powerpc/kernel/stacktrace.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/stacktrace.c +0 -0
index 2b0d04a1b7d2..a17ac10f86b1 100644

arch/powerpc/kernel/stacktrace.c line 18

Quoted 7 lines
arch/powerpc/kernel/stacktrace.c +1 -0
@@ -12,6 +12,7 @@
 #include <linux/kallsyms.h>
 #include <linux/module.h>
 #include <linux/nmi.h>
+#include <linux/delay.h>
 #include <linux/sched.h>
 #include <linux/sched/debug.h>
 #include <linux/sched/task_stack.h>

Hmm, I believe we try to keep the list of includes sorted in alphabetical order.

Gabriel

#2 lore raw

PATCH 1/1 powerpc/stacktrace: Include linux/delay.h

In reply to Michal Suchanek

commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the functionshould be included nonetheless.

Fixes 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()")

---
V2: Add header in alphabetical order.

---
 arch/powerpc/kernel/stacktrace.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/kernel/stacktrace.c +1 -0
index 2b0d04a1b7d2..9e4a4a7af380 100644
@@ -8,6 +8,7 @@
  * Copyright 2018 Nick Piggin, Michael Ellerman, IBM Corp.
  */
 
+#include <linux/delay.h>
 #include <linux/export.h>
 #include <linux/kallsyms.h>
 #include <linux/module.h>
Signature · 1 line
2.26.2
#3 lore raw
Quoted 4 lines · Michal Suchanek

commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in raise_backtrace_ipi()") introduces udelay() call without including the linux/delay.h header.
This may happen to work on master but the header that declares the functionshould be included nonetheless.

Applied to powerpc/next.

[1/1] powerpc/stacktrace: Include linux/delay.h

      https://git.kernel.org/powerpc/c/135462ae7692a824e5b63299178684fca3a366e6

cheers