f2fs: do not submit NEW_ADDR to read node block
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: do not submit NEW_ADDR to read node block
After the below patch, give cp is errored, we drop dirty node pages. This can give NEW_ADDR to read node pages. Don't do WARN_ON() which gives generic/475 failure.
Fixes 28607bf3aa6f ("f2fs: drop dirty node pages when cp is in error status")
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/f2fs/node.c +2 -1
@@ -1330,7 +1330,8 @@ static int read_node_page(struct page *page, int op_flags)if (err)return err; -if (unlikely (ni.blk_addr ==NULL_ADDR ) || +/* NEW_ADDR can be seen, after cp_error drops some dirty node pages */ +if (unlikely (ni.blk_addr ==NULL_ADDR || ni.blk_addr ==NEW_ADDR ) ||is_sbi_flag_set (sbi,SBI_IS_SHUTDOWN )) {ClearPageUptodate (page);return -ENOENT ;
Signature · 8 lines
2.32.0.432.gabb21c7263-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 6 lines · Jaegeuk Kim
After the below patch, give cp is errored, we drop dirty node pages. This can give
NEW_ADDRto read node pages. Don't doWARN_ON()which gives generic/475 failure.Fixes 28607bf3aa6f ("f2fs: drop dirty node pages when cp is in error status")Signed-off-by Jaegeuk Kim <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,