Skip to contentSkip to conversation

python3: remove no longer needed bbappend

PATCH In review Ruslan Babayev (fib) 3 participants 8 messages Jul 26, 2021 – Sep 8, 2021

lore
Share & tools
lore
#0 lore raw

Bruce, I am resending the v3 which completely removes the bbappend when virtualization is found in DISTRO_FEATURES. As you mentioned the bbappend originates all the way from python2 days and is no longer required. More importantly, it causes the breakage of python3-native recipe.

Thanks,
Ruslan

#1 lore raw

PATCH v3 1/1 python3: remove the no-longer required bbappend

It has been carried over from python2 and is no longer required. More importantly it breaks the python3-native build due to ${STAGING_DIR_TARGET} being "" for native recipes.

---
 recipes-devtools/python/python3_3.%.bbappend       | 1 -
 recipes-devtools/python/python3_virtualization.inc | 8 --------
 2 files changed, 9 deletions(-)
 delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
 delete mode 100644 recipes-devtools/python/python3_virtualization.inc
recipes-devtools/python/python3_3.%.bbappend deleted +0 -1
deleted file mode 100644
index 617cacc..0000000
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', '${BPN}_virtualization.inc', '', d)}
recipes-devtools/python/python3_virtualization.inc deleted +0 -8
deleted file mode 100644
index 55301c7..0000000
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
-	export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
Signature · 1 line
2.26.2.Cisco
#2 lore raw

Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

merged.

Bruce

In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

Quoted 36 lines · on 26/07/2021 Ruslan Babayev wrote:

It has been carried over from python2 and is no longer required. More importantly it breaks the python3-native build due to ${STAGING_DIR_TARGET} being "" for native recipes.

---
 recipes-devtools/python/python3_3.%.bbappend       | 1 -
 recipes-devtools/python/python3_virtualization.inc | 8 --------
 2 files changed, 9 deletions(-)
 delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
 delete mode 100644 recipes-devtools/python/python3_virtualization.inc
recipes-devtools/python/python3_3.%.bbappend deleted +0 -1
deleted file mode 100644
index 617cacc..0000000
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', '${BPN}_virtualization.inc', '', d)}
recipes-devtools/python/python3_virtualization.inc deleted +0 -8
deleted file mode 100644
index 55301c7..0000000
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
-	export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
Signature · 1 line
2.26.2.Cisco
#3 lore raw

Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

Can this be cherry-picked into dunfell please?

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Bruce Ashfield
Sent: Thursday, July 29, 2021 7:57 AM
To: Ruslan Babayev (fib) <[email protected]>
Cc: [email protected]
Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

merged.

Bruce

Quoted 39 lines · In message: [meta-virtualization][PATCH v3] python3: remove the no-longer…

It has been carried over from python2 and is no longer required. More importantly it breaks the python3-native build due to ${STAGING_DIR_TARGET} being "" for native recipes.

---
 recipes-devtools/python/python3_3.%.bbappend       | 1 -
 recipes-devtools/python/python3_virtualization.inc | 8 --------
 2 files changed, 9 deletions(-)
 delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
 delete mode 100644 recipes-devtools/python/python3_virtualization.inc
recipes-devtools/python/python3_3.%.bbappend deleted +0 -1
deleted file mode 100644
index 617cacc..0000000
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', 

'${BPN}_virtualization.inc', '', d)} diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc deleted file mode 100644
index 55301c7..0000000

recipes-devtools/python/python3_virtualization.inc deleted +0 -9
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
-	export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
--

2.26.2.Cisco

#4 lore raw

Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

In message: RE: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

Quoted 1 line · on 31/07/2021 Ruslan Babayev (fib) wrote:

Can this be cherry-picked into dunfell please?

No problem.

It is now on dunfell as well.

Bruce

Quoted 53 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Bruce Ashfield
Sent: Thursday, July 29, 2021 7:57 AM
To: Ruslan Babayev (fib) <[email protected]>
Cc: [email protected]
Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

merged.

Bruce

Quoted 39 lines · In message: [meta-virtualization][PATCH v3] python3: remove the no-longer…

It has been carried over from python2 and is no longer required. More importantly it breaks the python3-native build due to ${STAGING_DIR_TARGET} being "" for native recipes.

---
 recipes-devtools/python/python3_3.%.bbappend       | 1 -
 recipes-devtools/python/python3_virtualization.inc | 8 --------
 2 files changed, 9 deletions(-)
 delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
 delete mode 100644 recipes-devtools/python/python3_virtualization.inc
recipes-devtools/python/python3_3.%.bbappend deleted +0 -1
deleted file mode 100644
index 617cacc..0000000
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', 

'${BPN}_virtualization.inc', '', d)} diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc deleted file mode 100644
index 55301c7..0000000

recipes-devtools/python/python3_virtualization.inc deleted +0 -9
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
-	export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
--

2.26.2.Cisco

#5 lore raw

Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

Quoted 11 lines · Bruce Ashfield

[Please note: This e-mail is from an EXTERNAL e-mail address]

In message: RE: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

Quoted 1 line · on 31/07/2021 Ruslan Babayev (fib) wrote:

Can this be cherry-picked into dunfell please?

No problem.

It is now on dunfell as well.

Bruce

Hi,  Bruce

Can this be cherry-picked into hardnott please?  python3-native build also failed on hardnott.

Thanks

//Changqing

Quoted 55 lines
Quoted 55 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Bruce Ashfield
Sent: Thursday, July 29, 2021 7:57 AM
To: Ruslan Babayev (fib) <[email protected]>
Cc: [email protected]
Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

merged.

Bruce

Quoted 42 lines · In message: [meta-virtualization][PATCH v3] python3: remove the no-longer…

It has been carried over from python2 and is no longer required. More importantly it breaks the python3-native build due to ${STAGING_DIR_TARGET} being "" for native recipes.

---
  recipes-devtools/python/python3_3.%.bbappend       | 1 -
  recipes-devtools/python/python3_virtualization.inc | 8 --------
  2 files changed, 9 deletions(-)

delete mode 100644 recipes-devtools/python/python3_3.%.bbappend delete mode 100644 recipes-devtools/python/python3_virtualization.inc

recipes-devtools/python/python3_3.%.bbappend deleted +0 -1
deleted file mode 100644
index 617cacc..0000000
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization',

'${BPN}_virtualization.inc', '', d)} diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc deleted file mode 100644
index 55301c7..0000000

recipes-devtools/python/python3_virtualization.inc deleted +0 -9
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
-   export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
--

2.26.2.Cisco

#6 lore raw

Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

Quoted 13 lines · Changqing Li

On 8/2/21 11:45 AM, Bruce Ashfield wrote:

[Please note: This e-mail is from an EXTERNAL e-mail address]

In message: RE: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend on 31/07/2021 Ruslan Babayev (fib) wrote:

Can this be cherry-picked into dunfell please?

No problem.

Quoted 8 lines

It is now on dunfell as well.

Bruce

Hi, Bruce

Can this be cherry-picked into hardnott please? python3-native build also failed on hardnott.

Cherry-picked and pushed.

Bruce

Quoted 59 lines

Thanks

//Changqing

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Bruce Ashfield
Sent: Thursday, July 29, 2021 7:57 AM
To: Ruslan Babayev (fib) <[email protected]>
Cc: [email protected]
Subject: Re: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend

merged.

Bruce

In message: [meta-virtualization][PATCH v3] python3: remove the no-longer required bbappend on 26/07/2021 Ruslan Babayev wrote:

It has been carried over from python2 and is no longer required. More importantly it breaks the python3-native build due to ${STAGING_DIR_TARGET} being "" for native recipes.

---
 recipes-devtools/python/python3_3.%.bbappend       | 1 -
 recipes-devtools/python/python3_virtualization.inc | 8 --------
 2 files changed, 9 deletions(-)
 delete mode 100644 recipes-devtools/python/python3_3.%.bbappend
 delete mode 100644 recipes-devtools/python/python3_virtualization.inc
recipes-devtools/python/python3_3.%.bbappend deleted +0 -1
deleted file mode 100644
index 617cacc..0000000
@@ -1 +0,0 @@
-require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization',

'${BPN}_virtualization.inc', '', d)} diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc deleted file mode 100644
index 55301c7..0000000

recipes-devtools/python/python3_virtualization.inc deleted +0 -9
@@ -1,8 +0,0 @@
-FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
-
-DEPENDS += " ncurses"
-
-do_compile_prepend() {
-   export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
-}
-
--

2.26.2.Cisco

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
#7 lore raw
In reply to Ruslan Babayev (fib)
Quoted 7 lines · Ruslan Babayev

Bruce, I am resending the v3 which completely removes the bbappend when virtualization is found in DISTRO_FEATURES. As you mentioned the bbappend originates all the way from python2 days and is no longer required. More importantly, it causes the breakage of python3-native recipe.

Yup, that's the right thing to do. I've queued it for my local testing now.

Bruce

Quoted 7 lines

Thanks,
Ruslan

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II