Skip to contentSkip to conversation

package/bluez5_utils: hid needs hog

PATCH In review Fabrice Fontaine 3 participants 4 messages Jul 27, 2021 – Jul 28, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/bluez5_utils: hid needs hog

Build of hid without hog is broken since commit
fb9fc969d91f69851b4c70dba512b607e52bda7b:

/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i586-buildroot-linux-musl/9.3.0/../../../../i586-buildroot-linux-musl/bin/ld: profiles/input/bluetoothd-manager.o: in function `input_init':
manager.c:(.text+0x2fd): undefined reference to `input_set_auto_sec'

Fixes:
- http://autobuild.buildroot.org/results/9222879c9fe958e01e33f69531270355ea016d17

---
 package/bluez5_utils/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/bluez5_utils/Config.in +1 -0
index 9f20bf83ac..f2b63b0a1c 100644
@@ -78,6 +78,7 @@ config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH
 config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HID
 	bool "build hid plugin"
 	default y
+	select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HOG
 	help
 	  Build plugin for HID (input) profiles.
 
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · On Tue, 27 Jul 2021 09:20:11 +0200 Fabrice Fontaine…

Build of hid without hog is broken since commit
fb9fc969d91f69851b4c70dba512b607e52bda7b:

/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i586-buildroot-linux-musl/9.3.0/../../../../i586-buildroot-linux-musl/bin/ld: profiles/input/bluetoothd-manager.o: in function `input_init':
manager.c:(.text+0x2fd): undefined reference to `input_set_auto_sec'

Fixes:
- http://autobuild.buildroot.org/results/9222879c9fe958e01e33f69531270355ea016d17

This should also be probably be reported as a bug to upstream bluez, it is not normal that a combination of ./configure options leads to a build that fails.

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
Reviewed-by Michael Nosthoff on v1 1/1
#2 lore raw
In reply to Fabrice Fontaine
Quoted 19 lines · Fabrice Fontaine

Build of hid without hog is broken since commit
fb9fc969d91f69851b4c70dba512b607e52bda7b:

/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i586-buildroot-linux-musl/9.3.0/../../../../i586-buildroot-linux-musl/bin/ld: profiles/input/bluetoothd-manager.o: in function `input_init':
manager.c:(.text+0x2fd): undefined reference to `input_set_auto_sec'

Fixes:
- http://autobuild.buildroot.org/results/9222879c9fe958e01e33f69531270355ea016d17

---
  package/bluez5_utils/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/bluez5_utils/Config.in +0 -0
index 9f20bf83ac..f2b63b0a1c 100644

package/bluez5_utils/Config.in config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH · line 84

Quoted 7 lines
package/bluez5_utils/Config.in +1 -0
@@ -78,6 +78,7 @@ config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HEALTH
  config BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HID
  	bool "build hid plugin"
  	default y
+	select BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_HOG
  	help
  	  Build plugin for HID (input) profiles.
 

argh, missed that... thanks for fixing!

_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot

#3 lore raw
In reply to Fabrice Fontaine
Quoted 6 lines · On Tue, 27 Jul 2021 09:20:11 +0200 Fabrice Fontaine…

Build of hid without hog is broken since commit
fb9fc969d91f69851b4c70dba512b607e52bda7b:

/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i586-buildroot-linux-musl/9.3.0/../../../../i586-buildroot-linux-musl/bin/ld: profiles/input/bluetoothd-manager.o: in function `input_init':
manager.c:(.text+0x2fd): undefined reference to `input_set_auto_sec'

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/9222879c9fe958e01e33f69531270355ea016d17

---
 package/bluez5_utils/Config.in | 1 +
 1 file changed, 1 insertion(+)

I have applied, but as I said earlier, I think this should be fixed upstream, and depending on the upstream fix, perhaps this needs to be reverted in Buildroot, or changed.

Thanks,

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot