Skip to contentSkip to conversation

net/ice: fix wrong bandwidth config size in memory copy

PATCH Applied Ting Xu 2 participants 2 messages Jul 27, 2021 – Aug 2, 2021 Network drivers

lore
Share & tools
lore

Ting Xu

author
#0 lore raw

PATCH 1/1 net/ice: fix wrong bandwidth config size in memory copy

The memory size of bandwidth config parameters is not set correctly in memory copy process, which leads to the wrong values. This patch fixed the size to the correct value.

Fixes 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
---
 drivers/net/ice/ice_dcf_sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_dcf_sched.c +2 -2
index 090988c6e1..dcf2723494 100644
@@ -833,7 +833,7 @@ static int ice_dcf_hierarchy_commit(struct rte_eth_dev *dev,
 			goto fail_clear;
 		}
 		/* store the bandwidth information for replay */
-		ice_memcpy(hw->qos_bw_cfg[vf_id], vf_bw, sizeof(*vf_bw),
+		ice_memcpy(hw->qos_bw_cfg[vf_id], vf_bw, size,
 			   ICE_NONDMA_TO_NONDMA);
 		ice_memset(vf_bw, 0, size, ICE_NONDMA_MEM);
 	}
@@ -859,7 +859,7 @@ static int ice_dcf_hierarchy_commit(struct rte_eth_dev *dev,
 		ret_val = ICE_ERR_NO_MEMORY;
 		goto fail_clear;
 	}
-	ice_memcpy(hw->qos_bw_cfg[ICE_DCF_VFID], tc_bw, sizeof(*tc_bw),
+	ice_memcpy(hw->qos_bw_cfg[ICE_DCF_VFID], tc_bw, size,
 		   ICE_NONDMA_TO_NONDMA);
 
 	hw->tm_conf.committed = true;
Signature · 1 line
2.17.1
Acked-by Qi Zhang on v1 1/1 Applied
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: Xu, Ting <[email protected]>
Sent: Tuesday, July 27, 2021 6:55 PM
To: [email protected]
Cc: Zhang, Qi Z <[email protected]>; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ting <[email protected]>
Subject: [PATCH v1] net/ice: fix wrong bandwidth config size in memory copy

Quoted 7 lines

The memory size of bandwidth config parameters is not set correctly in memory copy process, which leads to the wrong values. This patch fixed the size to the correct value.

Fixes 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")

Applied to dpdk-next-net-intel.

Thanks
Qi