Skip to contentSkip to conversation

mm: change fault_in_pages_* to have an unsigned size parameter

PATCH Applied Greg Kroah-Hartman 1 participant 1 message Jul 27, 2021 Page cache

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: change fault_in_pages_* to have an unsigned size parameter

fault_in_pages_writeable() and fault_in_pages_readable() treat the size parameter as unsigned, doing pointer math with the value, so make this explicit and set it to be a size_t type which all callers currently treat it as anyway.

This solves the issue where static checkers get nervous seeing pointer arithmetic happening with a signed value.

Cc Matthew Wilcox <[email protected]>
Cc Andrew Morton <[email protected]>
Cc David Howells <[email protected]>
Cc William Kucharski <[email protected]>
Cc "Darrick J. Wong" <[email protected]>
Cc Hugh Dickins <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 include/linux/pagemap.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/pagemap.h +2 -2
index ed02aa522263..5dcf446f42e5 100644
@@ -736,7 +736,7 @@ extern void add_page_wait_queue(struct page *page, wait_queue_entry_t *waiter);
 /*
  * Fault everything in given userspace address range in.
  */
-static inline int fault_in_pages_writeable(char __user *uaddr, int size)
+static inline int fault_in_pages_writeable(char __user *uaddr, size_t size)
 {
 	char __user *end = uaddr + size - 1;
 
@@ -763,7 +763,7 @@ static inline int fault_in_pages_writeable(char __user *uaddr, int size)
 	return 0;
 }
 
-static inline int fault_in_pages_readable(const char __user *uaddr, int size)
+static inline int fault_in_pages_readable(const char __user *uaddr, size_t size)
 {
 	volatile char c;
 	const char __user *end = uaddr + size - 1;
Signature · 1 line
2.32.0