Skip to contentSkip to conversation

libtracefs: Do not use "or" as function parameter name

PATCH New Yordan Karadzhov (VMware) 1 participant 1 message Jul 27, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtracefs: Do not use "or" as function parameter name

"or" is a keyword in C++. Using it as a function argument name in the public header of the library makes it impossible to include this header from C++ code.

---

Hi Steven,

This patch is optional. Us it only if it makes sense to you. Note that this fix is not needed by KernelShark.

Thanks,
Yordan

 include/tracefs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/tracefs.h +2 -2
index 9cfd257..877e03a 100644
@@ -355,12 +355,12 @@ int tracefs_synth_add_start_filter(struct tracefs_synth *synth,
 				   const char *field,
 				   enum tracefs_synth_compare compare,
 				   const char *val,
-				   bool neg, bool or);
+				   bool neg, bool do_OR);
 int tracefs_synth_add_end_filter(struct tracefs_synth *synth,
 				 const char *field,
 				 enum tracefs_synth_compare compare,
 				 const char *val,
-				 bool neg, bool or);
+				 bool neg, bool do_OR);
 int tracefs_synth_create(struct tracefs_instance *instance,
 			 struct tracefs_synth *synth);
 int tracefs_synth_destroy(struct tracefs_instance *instance,
Signature · 1 line
2.30.2