Mediatek MT8195 SCP support
Subsystems (3)
cover Mediatek MT8195 SCP support
Changes since v2:
- Add compatible for mt8192
- Convert mtk,scp.txt to mtk,scp.yaml
- Refine clock checking method
Changes since v1:
- Fix missing 'compatible' line in binding document
Tinghan Shen (4):
dt-bindings: remoteproc: mediatek: Add binding for mt8195 scp
dt-bindings: remoteproc: mediatek: Add binding for mt8192 scp
dt-bindings: remoteproc: mediatek: Convert mtk,scp to json-schema
remoteproc: mediatek: Support mt8195 scp
.../bindings/remoteproc/mtk,scp.txt | 36 -------- .../bindings/remoteproc/mtk,scp.yaml | 85 +++++++++++++++++++ drivers/remoteproc/mtk_scp.c | 3 +- 3 files changed, 87 insertions(+), 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
Signature · 1 line
2.18.0
PATCH 1/4 dt-bindings: remoteproc: mediatek: Add binding for mt8195 scp
Add mt8195 compatible to binding document. The description of required properties are also modified to reflect the hardware change between mt8183 and mt8195. The mt8195 doesn't have to control the scp clock on kernel side.
--- Documentation/devicetree/bindings/remoteproc/mtk,scp.txt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/remoteproc/mtk,scp.txt +5 -3
@@ -5,13 +5,15 @@ This binding provides support for ARM Cortex M4 Co-processor found on some Mediatek SoCs. Required properties: -- compatible Should be "mediatek,mt8183-scp" +- compatible Should be one of: + "mediatek,mt8183-scp" + "mediatek,mt8195-scp" - reg Should contain the address ranges for memory regions: SRAM, CFG, and L1TCM. - reg-names Contains the corresponding names for the memory regions: "sram", "cfg", and "l1tcm". -- clocks Clock for co-processor (See: ../clock/clock-bindings.txt) -- clock-names Contains the corresponding name for the clock. This +- clocks Required by mt8183. Clock for co-processor (See: ../clock/clock-bindings.txt) +- clock-names Required by mt8183. Contains the corresponding name for the clock. This should be named "main". Subnodes
Signature · 1 line
2.18.0
PATCH 2/4 dt-bindings: remoteproc: mediatek: Add binding for mt8192 scp
In reply to Tinghan ShenAdd mt8192 compatible to binding document.
--- Documentation/devicetree/bindings/remoteproc/mtk,scp.txt | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/remoteproc/mtk,scp.txt +6 -3
@@ -7,14 +7,17 @@ Mediatek SoCs. Required properties: - compatible Should be one of: "mediatek,mt8183-scp" + "mediatek,mt8192-scp" "mediatek,mt8195-scp" - reg Should contain the address ranges for memory regions: SRAM, CFG, and L1TCM. - reg-names Contains the corresponding names for the memory regions: "sram", "cfg", and "l1tcm". -- clocks Required by mt8183. Clock for co-processor (See: ../clock/clock-bindings.txt) -- clock-names Required by mt8183. Contains the corresponding name for the clock. This - should be named "main". +- clocks Required by mt8183 and mt8192. Clock for co-processor + (See: ../clock/clock-bindings.txt) +- clock-names Required by mt8183 and mt8192. Contains the + corresponding name for the clock. This should be + named "main". Subnodes --------
Signature · 1 line
2.18.0
PATCH 3/4 dt-bindings: remoteproc: mediatek: Convert mtk,scp to json-schema
In reply to Tinghan ShenConvert the mtk,scp binding to DT schema format using json-schema.
--- .../bindings/remoteproc/mtk,scp.txt | 41 --------- .../bindings/remoteproc/mtk,scp.yaml | 85 +++++++++++++++++++ 2 files changed, 85 insertions(+), 41 deletions(-) delete mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.txt create mode 100644 Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
Documentation/devicetree/bindings/remoteproc/mtk,scp.txt deleted +0 -41
@@ -1,41 +0,0 @@ -Mediatek SCP Bindings ----------------------------------------- - -This binding provides support for ARM Cortex M4 Co-processor found on some -Mediatek SoCs. - -Required properties: -- compatible Should be one of: - "mediatek,mt8183-scp" - "mediatek,mt8192-scp" - "mediatek,mt8195-scp" -- reg Should contain the address ranges for memory regions: - SRAM, CFG, and L1TCM. -- reg-names Contains the corresponding names for the memory regions: - "sram", "cfg", and "l1tcm". -- clocks Required by mt8183 and mt8192. Clock for co-processor - (See: ../clock/clock-bindings.txt) -- clock-names Required by mt8183 and mt8192. Contains the - corresponding name for the clock. This should be - named "main". - -Subnodes --------- - -Subnodes of the SCP represent rpmsg devices. The names of the devices are not -important. The properties of these nodes are defined by the individual bindings -for the rpmsg devices - but must contain the following property: - -- mtk,rpmsg-name Contains the name for the rpmsg device. Used to match - the subnode to rpmsg device announced by SCP. - -Example: - - scp: scp@10500000 { - compatible = "mediatek,mt8183-scp"; - reg = <0 0x10500000 0 0x80000>, - <0 0x105c0000 0 0x5000>; - reg-names = "sram", "cfg"; - clocks = <&infracfg CLK_INFRA_SCPSYS>; - clock-names = "main"; - };
Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml new file +85 -0
85 lines not on this page · raw message
Signature · 1 line
2.18.0
PATCH 4/4 remoteproc: mediatek: Support mt8195 scp
In reply to Tinghan ShenThe SCP clock design is changed on mt8195 that doesn't need to control SCP clock on kernel side.
--- drivers/remoteproc/mtk_scp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/remoteproc/mtk_scp.c +2 -1
@@ -785,7 +785,7 @@ static int scp_probe(struct platform_device *pdev)if (ret) goto destroy_mutex; - scp->clk =devm_clk_get (dev,"main" ); + scp->clk =devm_clk_get_optional (dev,"main" );if (IS_ERR (scp->clk)) {dev_err (dev,"Failed to get clock\n" ); ret =PTR_ERR (scp->clk);
@@ -877,6 +877,7 @@ static const struct mtk_scp_of_data mt8192_of_data = {static const struct of_device_id mtk_scp_of_match[] = { { .compatible ="mediatek,mt8183-scp" , .data = &mt8183_of_data }, { .compatible ="mediatek,mt8192-scp" , .data = &mt8192_of_data }, + { .compatible ="mediatek,mt8195-scp" , .data = &mt8192_of_data }, {}, };MODULE_DEVICE_TABLE (of, mtk_scp_of_match);
Signature · 1 line
2.18.0