Skip to contentSkip to conversation

net/mlx5: limit implicitly MPLS RSS expansion

PATCH In review Suanming Mou 2 participants 2 messages Jul 28, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: limit implicitly MPLS RSS expansion

As [1] optimized the MPLS RSS expansion before, this commit limits the implicitly MPLS RSS expansion for MPLSoGRE as well. For the RSS flow matcher to GRE level only, it will not expand the MPLS match item for the sub flows due to performance consideration.

The original RSS flow match item:
ETH VLAN IPV6 GRE GRE_KEY END

The previous RSS expansion:
ETH VLAN IPV6 GRE GRE_KEY END
ETH VLAN IPV6 GRE GRE_KEY IPV4 END
ETH VLAN IPV6 GRE GRE_KEY MPLS IPV4 END
ETH VLAN IPV6 GRE GRE_KEY MPLS ETH IPV4 END

New RSS expansion:
ETH VLAN IPV6 GRE GRE_KEY END
ETH VLAN IPV6 GRE GRE_KEY IPV4 END

[1]
commit a26cc30fa046 ("net/mlx5: limit inner RSS expansion for MPLS")

---
 drivers/net/mlx5/mlx5_flow.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/mlx5/mlx5_flow.c +1 -0
index a3fdce685e..999f39e042 100644
@@ -581,6 +581,7 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = {
 						  MLX5_EXPANSION_IPV6,
 						  MLX5_EXPANSION_ETH),
 		.type = RTE_FLOW_ITEM_TYPE_MPLS,
+		.optional = 1,
 	},
 	[MLX5_EXPANSION_ETH] = {
 		.next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_IPV4,
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 26 lines

-----Original Message-----
From: Suanming Mou <[email protected]>
Sent: Wednesday, July 28, 2021 11:24 AM
To: Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>
Cc: Raslan Darawsheh <[email protected]>; [email protected]
Subject: [PATCH] net/mlx5: limit implicitly MPLS RSS expansion

As [1] optimized the MPLS RSS expansion before, this commit limits the implicitly MPLS RSS expansion for MPLSoGRE as well. For the RSS flow matcher to GRE level only, it will not expand the MPLS match item for the sub flows due to performance consideration.

The original RSS flow match item:
ETH VLAN IPV6 GRE GRE_KEY END

The previous RSS expansion:
ETH VLAN IPV6 GRE GRE_KEY END
ETH VLAN IPV6 GRE GRE_KEY IPV4 END
ETH VLAN IPV6 GRE GRE_KEY MPLS IPV4 END
ETH VLAN IPV6 GRE GRE_KEY MPLS ETH IPV4 END

New RSS expansion:
ETH VLAN IPV6 GRE GRE_KEY END
ETH VLAN IPV6 GRE GRE_KEY IPV4 END

Quoted 7 lines

[1]
commit a26cc30fa046 ("net/mlx5: limit inner RSS expansion for MPLS")

---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh