Skip to contentSkip to conversation

net/mlx5: fix typo in flow engine type

PATCH In review Asaf Penso 3 participants 3 messages Jul 28, 2021 – Jul 29, 2021 Network drivers

lore
Share & tools
lore

Asaf Penso

author
#0 lore raw

PATCH 1/1 net/mlx5: fix typo in flow engine type

The concrete function names have a prefix for flow_dv. This emphasizes the flow engine is direct verbs.

The function flow_get_aged_flows doesn’t have this prefix. It creates an inconsistency with the other functions.

Update the function name to include dv.

Fixes fa2d01c87d2 ("net/mlx5: support flow aging")
---
 drivers/net/mlx5/mlx5_flow_dv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/mlx5/mlx5_flow_dv.c +2 -2
index 736227bc0c..4b569b0bdb 100644
@@ -17231,7 +17231,7 @@ flow_dv_counter_query(struct rte_eth_dev *dev, uint32_t counter, bool clear,
  * @note: only stub for now
  */
 static int
-flow_get_aged_flows(struct rte_eth_dev *dev,
+flow_dv_get_aged_flows(struct rte_eth_dev *dev,
 		    void **context,
 		    uint32_t nb_contexts,
 		    struct rte_flow_error *error)
@@ -17854,7 +17854,7 @@ const struct mlx5_flow_driver_ops mlx5_flow_dv_drv_ops = {
 	.counter_alloc = flow_dv_counter_allocate,
 	.counter_free = flow_dv_counter_free,
 	.counter_query = flow_dv_counter_query,
-	.get_aged_flows = flow_get_aged_flows,
+	.get_aged_flows = flow_dv_get_aged_flows,
 	.action_validate = flow_dv_action_validate,
 	.action_create = flow_dv_action_create,
 	.action_destroy = flow_dv_action_destroy,
Signature · 1 line
2.18.2
Acked-by on v1 1/1
#1 lore raw

From: Asaf Penso

Quoted 6 lines

The concrete function names have a prefix for flow_dv. This emphasizes the flow engine is direct verbs.

The function flow_get_aged_flows doesn’t have this prefix. It creates an inconsistency with the other functions.

Quoted 6 lines

Update the function name to include dv.

Fixes fa2d01c87d2 ("net/mlx5: support flow aging")
#2 lore raw
In reply to Asaf Penso

Hi,

Quoted 15 lines

-----Original Message-----
From: Asaf Penso <[email protected]>
Sent: Wednesday, July 28, 2021 12:40 PM
To: [email protected]
Cc: NBU-Contact-Thomas Monjalon <[email protected]>; Slava Ovsiienko <[email protected]>; Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; [email protected]
Subject: [PATCH 1/1] net/mlx5: fix typo in flow engine type

The concrete function names have a prefix for flow_dv. This emphasizes the flow engine is direct verbs.

The function flow_get_aged_flows doesn’t have this prefix. It creates an inconsistency with the other functions.

Quoted 7 lines

Update the function name to include dv.

Fixes fa2d01c87d2 ("net/mlx5: support flow aging")

---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh