Skip to contentSkip to conversation

crypto/mlx5: fix driver probing error flow

PATCH Applied Michael Baum 3 participants 3 messages Jul 29, 2021 – Jul 31, 2021 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto/mlx5: fix driver probing error flow

In crypto driver probing, there are two validations after context allocation.

When one of them fails, the context structure was not freed what caused a memory leak.

Free it.

Fixes debb27ea3442 ("crypto/mlx5: create login object using DevX")
Fixes e8db4413cba5 ("crypto/mlx5: add keytag configuration")
---
 drivers/crypto/mlx5/mlx5_crypto.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/crypto/mlx5/mlx5_crypto.c +2 -0
index ea734f4d5c..b3d5200ca3 100644
@@ -1021,12 +1021,14 @@ mlx5_crypto_dev_probe(struct rte_device *dev)
 	ret = mlx5_crypto_parse_devargs(dev->devargs, &devarg_prms);
 	if (ret) {
 		DRV_LOG(ERR, "Failed to parse devargs.");
+		claim_zero(mlx5_glue->close_device(ctx));
 		return -rte_errno;
 	}
 	login = mlx5_devx_cmd_create_crypto_login_obj(ctx,
 						      &devarg_prms.login_attr);
 	if (login == NULL) {
 		DRV_LOG(ERR, "Failed to configure login.");
+		claim_zero(mlx5_glue->close_device(ctx));
 		return -rte_errno;
 	}
 	crypto_dev = rte_cryptodev_pmd_create(ibv->name, dev,
Signature · 1 line
2.25.1
Applied
#1 lore raw
Quoted 8 lines

In crypto driver probing, there are two validations after context allocation.

When one of them fails, the context structure was not freed what caused a memory leak.

Free it.

Quoted 7 lines
Fixes debb27ea3442 ("crypto/mlx5: create login object using DevX")
Fixes e8db4413cba5 ("crypto/mlx5: add keytag configuration")

---

Applied to dpdk-next-crypto
@Thomas Monjalon: I do not think title and patch description are inline. You may fix it while pulling on main branch.

#2 lore raw

30/07/2021 21:23, Akhil Goyal:

Quoted 12 lines
Quoted 12 lines

In crypto driver probing, there are two validations after context allocation.

When one of them fails, the context structure was not freed what caused a memory leak.

Free it.

Fixes debb27ea3442 ("crypto/mlx5: create login object using DevX")
Fixes e8db4413cba5 ("crypto/mlx5: add keytag configuration")
Quoted 6 lines
Quoted 3 lines

---

Applied to dpdk-next-crypto
@Thomas Monjalon: I do not think title and patch description are inline. You may fix it while pulling on main branch.

New title:
crypto/mlx5: fix leaks on probing failure