ipmi: rate limit ipmi smi_event failure message
PATCH 1/1 ipmi: rate limit ipmi smi_event failure message
Sometimes we can't get a valid si_sm_data, and we print an error message accordingly. But the ipmi module seem to like retrying a lot, in which case we flood the kernel log with a lot of messages, eg:
[46318019.164726] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318020.109700] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318021.158677] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318022.212598] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318023.258564] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318024.210455] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318025.260473] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318026.308445] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318027.356389] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318028.298288] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318029.363302] ipmi_si IPI0001:00: Could not set the global enables: 0xc1.
Signed-off-by Wen Yang <[email protected]>
Cc Baoyou Xie <[email protected]>
Cc Corey Minyard <[email protected]>
--- drivers/char/ipmi/ipmi_si_intf.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +8 -7
@@ -591,7 +591,7 @@ static void handle_transaction_done(struct smi_info *smi_info) smi_info->handlers->get_result (smi_info->si_sm, msg,3 );if (msg[2 ] !=0 ) {/* Error clearing flags */ -dev_warn (smi_info->io.dev, +dev_warn_ratelimited (smi_info->io.dev,"Error clearing flags: %2.2x\n" , msg[2 ]); } smi_info->si_state =SI_NORMAL ;
@@ -683,10 +683,11 @@ static void handle_transaction_done(struct smi_info *smi_info)/* We got the flags from the SMI, now handle them. */ smi_info->handlers->get_result (smi_info->si_sm, msg,4 );if (msg[2 ] !=0 ) { -dev_warn (smi_info->io.dev, -"Couldn't get irq info: %x.\n" , msg[2 ]); -dev_warn (smi_info->io.dev, -"Maybe ok, but ipmi might run very slowly.\n" ); +#define IPMI_WARN_CHECKING_ENABLES "Maybe ok, but ipmi might run very slowly." + +dev_warn_ratelimited (smi_info->io.dev, +"Couldn't get irq info: %x, %s\n" , + msg[2 ],IPMI_WARN_CHECKING_ENABLES ); smi_info->si_state =SI_NORMAL ;break ; }
@@ -721,7 +722,7 @@ static void handle_transaction_done(struct smi_info *smi_info) smi_info->handlers->get_result (smi_info->si_sm, msg,4 );if (msg[2 ] !=0 ) -dev_warn (smi_info->io.dev, +dev_warn_ratelimited (smi_info->io.dev,"Could not set the global enables: 0x%x.\n" , msg[2 ]);
@@ -1343,7 +1344,7 @@ static int try_get_dev_id(struct smi_info *smi_info)if (cc !=IPMI_CC_NO_ERROR && ++retry_count <=GET_DEVICE_ID_MAX_RETRY ) { -dev_warn (smi_info->io.dev, +dev_warn_ratelimited (smi_info->io.dev,"BMC returned 0x%2.2x, retry get bmc device id\n" , cc); goto retry;
Signature · 1 line
1.8.3.1
Quoted 3 lines · Wen Yang
Sometimes we can't get a valid
si_sm_data, and we print an error message accordingly. But the ipmi module seem to like retrying a lot, in which case we flood the kernel log with a lot of messages, eg:
This is reasonable. I moved the #define into the dev_warn_ratelimited because that looked a little strange, and having the #define really didn't add any value. But that's it, queued for next release.
Thanks,
-corey
Quoted 72 lines
[46318019.164726] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318020.109700] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318021.158677] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318022.212598] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318023.258564] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318024.210455] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318025.260473] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318026.308445] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318027.356389] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318028.298288] ipmi_si IPI0001:00: Could not set the global enables: 0xc1. [46318029.363302] ipmi_si IPI0001:00: Could not set the global enables: 0xc1.Signed-off-by Wen Yang <[email protected]>Cc Baoyou Xie <[email protected]>Cc Corey Minyard <[email protected]>--- drivers/char/ipmi/ipmi_si_intf.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)drivers/char/ipmi/ipmi_si_intf.c +8
-7@@ -591,7 +591,7 @@ static void handle_transaction_done(struct smi_info *smi_info) smi_info->handlers->get_result (smi_info->si_sm, msg,3 );if (msg[2 ] !=0 ) {/* Error clearing flags */ -dev_warn (smi_info->io.dev, +dev_warn_ratelimited (smi_info->io.dev,"Error clearing flags: %2.2x\n" , msg[2 ]); } smi_info->si_state =SI_NORMAL ;@@ -683,10 +683,11 @@ static void handle_transaction_done(struct smi_info *smi_info)/* We got the flags from the SMI, now handle them. */ smi_info->handlers->get_result (smi_info->si_sm, msg,4 );if (msg[2 ] !=0 ) { -dev_warn (smi_info->io.dev, -"Couldn't get irq info: %x.\n" , msg[2 ]); -dev_warn (smi_info->io.dev, -"Maybe ok, but ipmi might run very slowly.\n" ); +#define IPMI_WARN_CHECKING_ENABLES "Maybe ok, but ipmi might run very slowly." + +dev_warn_ratelimited (smi_info->io.dev, +"Couldn't get irq info: %x, %s\n" , + msg[2 ],IPMI_WARN_CHECKING_ENABLES ); smi_info->si_state =SI_NORMAL ;break ; }@@ -721,7 +722,7 @@ static void handle_transaction_done(struct smi_info *smi_info) smi_info->handlers->get_result (smi_info->si_sm, msg,4 );if (msg[2 ] !=0 ) -dev_warn (smi_info->io.dev, +dev_warn_ratelimited (smi_info->io.dev,"Could not set the global enables: 0x%x.\n" , msg[2 ]);@@ -1343,7 +1344,7 @@ static int try_get_dev_id(struct smi_info *smi_info)if (cc !=IPMI_CC_NO_ERROR && ++retry_count <=GET_DEVICE_ID_MAX_RETRY ) { -dev_warn (smi_info->io.dev, +dev_warn_ratelimited (smi_info->io.dev,"BMC returned 0x%2.2x, retry get bmc device id\n" , cc); goto retry;Signature · 1 line
1.8.3.1