Skip to contentSkip to conversation

staging: vt665X: remove unused CONFIG_PATH

PATCH In review Greg Kroah-Hartman 2 participants 2 messages Jul 29, 2021 Staging

lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/1 staging: vt665X: remove unused CONFIG_PATH

The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating around in the code, but it is never used. Remove it as drivers should never be reading from config files anyway, even if these were valid files.

---
 drivers/staging/vt6655/device_cfg.h | 3 ---
 drivers/staging/vt6656/device.h     | 2 --
 2 files changed, 5 deletions(-)
drivers/staging/vt6655/device_cfg.h +0 -3
index db0304f6e21c..2d647a3619ba 100644
@@ -38,9 +38,6 @@
 
 #include <linux/fs.h>
 #include <linux/fcntl.h>
-#ifndef CONFIG_PATH
-#define CONFIG_PATH            "/etc/vntconfiguration.dat"
-#endif
 
 #define PKT_BUF_SZ          2390
 
drivers/staging/vt6656/device.h +0 -2
index 947530fefe94..2c93a2e66c8a 100644
@@ -77,8 +77,6 @@
 #define FIRMWARE_NAME			"vntwusb.fw"
 #define FIRMWARE_CHUNK_SIZE		0x400
 
-#define CONFIG_PATH			"/etc/vntconfiguration.dat"
-
 #define MAX_UINTS			8
 #define OPTION_DEFAULT			{ [0 ... MAX_UINTS - 1] = -1}
 
Signature · 1 line
2.32.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Greg Kroah-Hartman

The vt6655 and vt6656 drivers have an unused CONFIG_PATH define floating around in the code, but it is never used. Remove it as drivers should never be reading from config files anyway, even if these were valid files.

Thanks.

Quoted 33 lines
---
 drivers/staging/vt6655/device_cfg.h | 3 ---
 drivers/staging/vt6656/device.h     | 2 --
 2 files changed, 5 deletions(-)
drivers/staging/vt6655/device_cfg.h +0 -3
index db0304f6e21c..2d647a3619ba 100644
@@ -38,9 +38,6 @@
 
 #include <linux/fs.h>
 #include <linux/fcntl.h>
-#ifndef CONFIG_PATH
-#define CONFIG_PATH            "/etc/vntconfiguration.dat"
-#endif
 
 #define PKT_BUF_SZ          2390
 
drivers/staging/vt6656/device.h +0 -2
index 947530fefe94..2c93a2e66c8a 100644
@@ -77,8 +77,6 @@
 #define FIRMWARE_NAME			"vntwusb.fw"
 #define FIRMWARE_CHUNK_SIZE		0x400
 
-#define CONFIG_PATH			"/etc/vntconfiguration.dat"
-
 #define MAX_UINTS			8
 #define OPTION_DEFAULT			{ [0 ... MAX_UINTS - 1] = -1}
 
Signature · 1 line
~Randy