mm: delete unused get_kernel_page()
Subsystems (2)
PATCH 1/1 mm: delete unused get_kernel_page()
get_kernel_page() was added in 2012 by [1]. It was used for a while for NFS, but then in 2014, a refactoring [2] removed all callers, and it has apparently not been used since.
Remove get_kernel_page() because it has no callers.
[1] commit 18022c5d8627 ("mm: add get_kernel_page[s] for pinning of kernel addresses for I/O")
[2] commit 91f79c43d1b5 ("new helper: iov_iter_get_pages_alloc()")
---
Hi,
Just a minor decluttering: I ran across this while looking for something else entirely, and then noticed that it's been orphaned for quite a long time. It seems like only the plural form of this function is needed these days, and probably in the coming days as well.
thanks,
John Hubbard
NVIDIA
include/linux/mm.h | 1 - mm/swap.c | 22 ---------------------- 2 files changed, 23 deletions(-)
include/linux/mm.h +0 -1
@@ -1847,7 +1847,6 @@ int __account_locked_vm(struct mm_struct *mm, unsigned long pages, bool inc,struct kvec ;int get_kernel_pages (const struct kvec *iov,int nr_pages,int write,struct page **pages); -int get_kernel_page (unsigned long start,int write,struct page **pages);struct page *get_dump_page (unsigned long addr);extern int try_to_release_page (struct page * page,gfp_t gfp_mask);
mm/swap.c +0 -22
@@ -179,28 +179,6 @@ int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write, }EXPORT_SYMBOL_GPL (get_kernel_pages); -/* -* get_kernel_page() - pin a kernel page in memory -* @start: starting kernel address -* @write: pinning for read/write, currently ignored -* @pages: array that receives pointer to the page pinned. -* Must be at least nr_segs long. -* -* Returns 1 if page is pinned. If the page was not pinned, returns -* -errno. The page returned must be released with a put_page() call -* when it is finished with. -*/ -int get_kernel_page (unsigned long start,int write,struct page **pages) -{ -const struct kvec kiov = { - .iov_base = (void *)start, - .iov_len =PAGE_SIZE - }; - -return get_kernel_pages (&kiov,1 , write, pages); -} -EXPORT_SYMBOL_GPL (get_kernel_page); -static void pagevec_lru_move_fn (struct pagevec *pvec,void (*move_fn)(struct page *page,struct lruvec *lruvec)) {
Signature · 1 line
2.32.0
Quoted 3 lines · John Hubbard
get_kernel_page()was added in 2012 by [1]. It was used for a while for NFS, but then in 2014, a refactoring [2] removed all callers, and it has apparently not been used since.
Looks good, pinnining by kernel virtual address doesn't really make much sense.
Quoted 29 lines · John Hubbard
get_kernel_page()was added in 2012 by [1]. It was used for a while for NFS, but then in 2014, a refactoring [2] removed all callers, and it has apparently not been used since.Remove
get_kernel_page()because it has no callers.[1] commit
18022c5d8627("mm: add get_kernel_page[s] for pinning of kernel addresses for I/O")
[2] commit91f79c43d1b5("new helper:iov_iter_get_pages_alloc()")Cc Mel Gorman <[email protected]>Cc Rik van Riel <[email protected]>Cc Christoph Hellwig <[email protected]>Cc David S. Miller <[email protected]>Cc Eric B Munson <[email protected]>Cc Eric Paris <[email protected]>Cc James Morris <[email protected]>Cc Mike Christie <[email protected]>Cc Neil Brown <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Sebastian Andrzej Siewior <[email protected]>Cc Trond Myklebust <[email protected]>Cc Xiaotian Feng <[email protected]>Cc Mark Salter <[email protected]>Signed-off-by John Hubbard <[email protected]>---
Hi,
Quoted 8 lines
Just a minor decluttering: I ran across this while looking for something else entirely, and then noticed that it's been orphaned for quite a long time. It seems like only the plural form of this function is needed these days, and probably in the coming days as well.
thanks,
John Hubbard
NVIDIA
Signature · 3 lines
Thanks, David / dhildenb