watchdog: meson_gxbb_wdt: improve
Subsystems (2)
v4 cover watchdog: meson_gxbb_wdt: improve
* Added nowayout module parameter
* Added timeout module parameter
* Removed watchdog_stop_on_reboot
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
Artem Lapkin (3):
watchdog: meson_gxbb_wdt: add nowayout parameter
watchdog: meson_gxbb_wdt: add timeout parameter
watchdog: meson_gxbb_wdt: remove stop_on_reboot
drivers/watchdog/meson_gxbb_wdt.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH v4 1/3 watchdog: meson_gxbb_wdt: add nowayout parameter
Add nowayout module parameter
--- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/watchdog/meson_gxbb_wdt.c +6 -0
@@ -29,6 +29,11 @@#define GXBB_WDT_TCNT_SETUP_MASK (BIT(16) - 1)#define GXBB_WDT_TCNT_CNT_SHIFT 16 +static bool nowayout =WATCHDOG_NOWAYOUT ; +module_param (nowayout, bool,0 ); +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +struct meson_gxbb_wdt {void __iomem *reg_base;struct watchdog_device wdt_dev;
@@ -175,6 +180,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms =GXBB_WDT_TCNT_SETUP_MASK ; data->wdt_dev.min_timeout =1 ; data->wdt_dev.timeout =DEFAULT_TIMEOUT ; +watchdog_set_nowayout (&data->wdt_dev, nowayout);watchdog_set_drvdata (&data->wdt_dev, data);/* Setup with 1ms timebase */
Signature · 1 line
2.25.1
Re: [PATCH v4 1/3] watchdog: meson_gxbb_wdt: add nowayout parameter
Quoted 4 lines · Artem Lapkin
Add nowayout module parameter
Signed-off-by Artem Lapkin <[email protected]>---
<Formletter>
Change log goes here. If it is missing, I won't know what changed. That means I will have to dig out older patch versions to compare. That costs time and would hold up both this patch as well as all other patches which I still have to review.
For this reason, I will not review patches without change log. </Formletter>
The change is small and recent enough that I remember, so
but please keep this in mind for future submissions.
Thanks,
Guenter
Quoted 30 lines
drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/watchdog/meson_gxbb_wdt.c +6
-0@@ -29,6 +29,11 @@#define GXBB_WDT_TCNT_SETUP_MASK (BIT(16) - 1)#define GXBB_WDT_TCNT_CNT_SHIFT 16 +static bool nowayout =WATCHDOG_NOWAYOUT ; +module_param (nowayout, bool,0 ); +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +struct meson_gxbb_wdt {void __iomem *reg_base;struct watchdog_device wdt_dev;@@ -175,6 +180,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms =GXBB_WDT_TCNT_SETUP_MASK ; data->wdt_dev.min_timeout =1 ; data->wdt_dev.timeout =DEFAULT_TIMEOUT ; +watchdog_set_nowayout (&data->wdt_dev, nowayout);watchdog_set_drvdata (&data->wdt_dev, data);/* Setup with 1ms timebase */ Signature · 1 line
2.25.1
Re: [PATCH v4 1/3] watchdog: meson_gxbb_wdt: add nowayout parameter
hi Guenter Roeck
why still not merged to upstream ?
Quoted 55 lines · Guenter Roeck
Quoted 4 lines · Artem Lapkin
Add nowayout module parameter
Signed-off-by Artem Lapkin <[email protected]>---
<Formletter>
Change log goes here. If it is missing, I won't know what changed. That means I will have to dig out older patch versions to compare. That costs time and would hold up both this patch as well as all other patches which I still have to review.For this reason, I will not review patches without change log. </Formletter>
The change is small and recent enough that I remember, so
Reviewed-by Guenter Roeck <[email protected]>but please keep this in mind for future submissions.
Thanks,
GuenterQuoted 30 lines
drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/watchdog/meson_gxbb_wdt.c +6
-1@@ -29,6 +29,11 @@#define GXBB_WDT_TCNT_SETUP_MASK (BIT(16) - 1)#define GXBB_WDT_TCNT_CNT_SHIFT 16 +static bool nowayout =WATCHDOG_NOWAYOUT ; +module_param (nowayout, bool,0 ); +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +struct meson_gxbb_wdt {void __iomem *reg_base;struct watchdog_device wdt_dev;@@ -175,6 +180,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms =GXBB_WDT_TCNT_SETUP_MASK ; data->wdt_dev.min_timeout =1 ; data->wdt_dev.timeout =DEFAULT_TIMEOUT ; +watchdog_set_nowayout (&data->wdt_dev, nowayout);watchdog_set_drvdata (&data->wdt_dev, data);/* Setup with 1ms timebase */ --2.25.1
PATCH v4 2/3 watchdog: meson_gxbb_wdt: add timeout parameter
In reply to Artem LapkinAdd timeout module parameter
--- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/watchdog/meson_gxbb_wdt.c +6 -0
@@ -34,6 +34,11 @@ module_param(nowayout, bool, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +static unsigned int timeout; +module_param (timeout, uint,0 ); +MODULE_PARM_DESC(timeout, "Watchdog heartbeat in seconds=" + __MODULE_STRING(DEFAULT_TIMEOUT) ")"); +struct meson_gxbb_wdt {void __iomem *reg_base;struct watchdog_device wdt_dev;
@@ -180,6 +185,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms =GXBB_WDT_TCNT_SETUP_MASK ; data->wdt_dev.min_timeout =1 ; data->wdt_dev.timeout =DEFAULT_TIMEOUT ; +watchdog_init_timeout (&data->wdt_dev, timeout, dev);watchdog_set_nowayout (&data->wdt_dev, nowayout);watchdog_set_drvdata (&data->wdt_dev, data);
Signature · 1 line
2.25.1
Re: [PATCH v4 2/3] watchdog: meson_gxbb_wdt: add timeout parameter
Quoted 4 lines · Artem Lapkin
Add timeout module parameter
Signed-off-by Artem Lapkin <[email protected]>---
<Formletter>
Change log goes here. If it is missing, I won't know what changed. That means I will have to dig out older patch versions to compare. That costs time and would hold up both this patch as well as all other patches which I still have to review.
For this reason, I will not review patches without change log. </Formletter>
As before, the change log is small and recent enough that I remember, so you are lucky.
Thanks,
Guenter
Quoted 30 lines
drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/watchdog/meson_gxbb_wdt.c +6
-0@@ -34,6 +34,11 @@ module_param(nowayout, bool, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +static unsigned int timeout; +module_param (timeout, uint,0 ); +MODULE_PARM_DESC(timeout, "Watchdog heartbeat in seconds=" + __MODULE_STRING(DEFAULT_TIMEOUT) ")"); +struct meson_gxbb_wdt {void __iomem *reg_base;struct watchdog_device wdt_dev;@@ -180,6 +185,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms =GXBB_WDT_TCNT_SETUP_MASK ; data->wdt_dev.min_timeout =1 ; data->wdt_dev.timeout =DEFAULT_TIMEOUT ; +watchdog_init_timeout (&data->wdt_dev, timeout, dev);watchdog_set_nowayout (&data->wdt_dev, nowayout);watchdog_set_drvdata (&data->wdt_dev, data);Signature · 1 line
2.25.1
Re: [PATCH v4 2/3] watchdog: meson_gxbb_wdt: add timeout parameter
In reply to Artem Lapkinhi Guenter Roeck
why still not merged to upstream ?
Quoted 35 lines · Artem Lapkin
Add timeout module parameter
Signed-off-by Artem Lapkin <[email protected]>--- drivers/watchdog/meson_gxbb_wdt.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/watchdog/meson_gxbb_wdt.c +6
-1@@ -34,6 +34,11 @@ module_param(nowayout, bool, 0); MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); +static unsigned int timeout; +module_param (timeout, uint,0 ); +MODULE_PARM_DESC(timeout, "Watchdog heartbeat in seconds=" + __MODULE_STRING(DEFAULT_TIMEOUT) ")"); +struct meson_gxbb_wdt {void __iomem *reg_base;struct watchdog_device wdt_dev;@@ -180,6 +185,7 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) data->wdt_dev.max_hw_heartbeat_ms =GXBB_WDT_TCNT_SETUP_MASK ; data->wdt_dev.min_timeout =1 ; data->wdt_dev.timeout =DEFAULT_TIMEOUT ; +watchdog_init_timeout (&data->wdt_dev, timeout, dev);watchdog_set_nowayout (&data->wdt_dev, nowayout);watchdog_set_drvdata (&data->wdt_dev, data); --2.25.1
PATCH v4 3/3 watchdog: meson_gxbb_wdt: remove stop_on_reboot
In reply to Artem LapkinRemove watchdog_stop_on_reboot()
Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)
drivers/watchdog/meson_gxbb_wdt.c +0 -1
@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); }
Signature · 1 line
2.25.1
Guenter Roeck
maintainerRe: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
Quoted 6 lines · Artem Lapkin
Remove
watchdog_stop_on_reboot()Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
Quoted 9 lines
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
A much better description would be something like
"The Meson platform still has some hardware drivers problems for some
configurations which can freeze devices on shutdown/reboot. Remove watchdog_stop_on_reboot() to catch this situation and ensure that the reboot happens anyway.
Users who still want to stop the watchdog on reboot can still do so using the watchdog.stop_on_reboot=1 module parameter.
"
That leaves the personal opinion out of the picture and provides both a rationale for the change and an alternative for people who want to stop the watchdog on reboot anyway.
Quoted 1 line
Signed-off-by Artem Lapkin <[email protected]>
As mentioned, I'd still like to get an opinion from the driver author and/or some other users of this platform. However, I'll accept the patch with the above description change if I don't get additional feedback.
Thanks,
Guenter
Quoted 19 lines
--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/meson_gxbb_wdt.c +0
-1@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); }Signature · 1 line
2.25.1
Re: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
Thank you very much for the helpful and detailed comments
Artem
Quoted 61 lines · Guenter Roeck
Quoted 6 lines · Artem Lapkin
Remove
watchdog_stop_on_reboot()Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
Quoted 9 lines
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
A much better description would be something like
"The Meson platform still has some hardware drivers problems for some
configurations which can freeze devices on shutdown/reboot. Removewatchdog_stop_on_reboot()to catch this situation and ensure that the reboot happens anyway.
Users who still want to stop the watchdog on reboot can still do so using the watchdog.stop_on_reboot=1 module parameter.
"That leaves the personal opinion out of the picture and provides both a rationale for the change and an alternative for people who want to stop the watchdog on reboot anyway.
Quoted 1 line
Signed-off-by Artem Lapkin <[email protected]>As mentioned, I'd still like to get an opinion from the driver author and/or some other users of this platform. However, I'll accept the patch with the above description change if I don't get additional feedback.
Thanks,
GuenterQuoted 19 lines
--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/meson_gxbb_wdt.c +0
-2@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); } --2.25.1
Re: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
In reply to Guenter RoeckHi Guenter,
Quoted 31 lines · Guenter Roeck
Quoted 6 lines · Artem Lapkin
Remove
watchdog_stop_on_reboot()Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
Quoted 9 lines
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
A much better description would be something like
"The Meson platform still has some hardware drivers problems for some
configurations which can freeze devices on shutdown/reboot. Removewatchdog_stop_on_reboot()to catch this situation and ensure that the reboot happens anyway.
Users who still want to stop the watchdog on reboot can still do so using the watchdog.stop_on_reboot=1 module parameter.
"That leaves the personal opinion out of the picture and provides both a rationale for the change and an alternative for people who want to stop the watchdog on reboot anyway.
Quoted 6 lines
Quoted 1 line
Signed-off-by Artem Lapkin <[email protected]>As mentioned, I'd still like to get an opinion from the driver author and/or some other users of this platform. However, I'll accept the patch with the above description change if I don't get additional feedback.
Sorry for the reply delay and thanks a lot for your review.
The rationale from Artem is OK for me.
Please add my Acked-by for the whole patchset.
Neil
Quoted 23 lines
Thanks,
GuenterQuoted 19 lines
--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/meson_gxbb_wdt.c +0
-1@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); }Signature · 1 line
2.25.1
Re: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
In reply to Artem Lapkinhi Guenter Roeck
why still not merged to upstream ?
Quoted 36 lines · Artem Lapkin
Remove
watchdog_stop_on_reboot()Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
Signed-off-by Artem Lapkin <[email protected]>--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/meson_gxbb_wdt.c +0
-2@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); } --2.25.1
Guenter Roeck
maintainerRe: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
Quoted 3 lines · Art Nikpal
hi Guenter Roeck
why still not merged to upstream ?
I had asked you to provide an updated description, without the "personal opinion" part which does not belong into a commit log. The other two patches wait for Wim to send them upstream.
Guenter
Quoted 37 lines · Artem Lapkin
Quoted 36 lines
Remove
watchdog_stop_on_reboot()Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
Signed-off-by Artem Lapkin <[email protected]>--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/meson_gxbb_wdt.c +0
-2@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); } --2.25.1
Re: [PATCH v4 3/3] watchdog: meson_gxbb_wdt: remove stop_on_reboot
Quoted 10 lines · Guenter Roeck
Quoted 3 lines · Art Nikpal
hi Guenter Roeck
why still not merged to upstream ?I had asked you to provide an updated description, without the "personal opinion" part which does not belong into a commit log. The other two patches wait for Wim to send them upstream.
ok i have send this patch with new description again
Quoted 41 lines
Guenter
Quoted 37 lines · Artem Lapkin
Quoted 36 lines
Remove
watchdog_stop_on_reboot()Meson platform still have some hardware drivers problems for some configurations which can freeze device on shutdown/reboot stage and i think better to have reboot warranty by default.
I feel that it is important to keep the watchdog running during the reboot sequence, in the event that an abnormal driver freezes the reboot process.
This is my personal opinion and I hope the driver authors will agree with my proposal, or just ignore this commit if not.
https://lore.kernel.org/linux-watchdog/[email protected]/T/#t
Signed-off-by Artem Lapkin <[email protected]>--- drivers/watchdog/meson_gxbb_wdt.c | 1 - 1 file changed, 1 deletion(-)drivers/watchdog/meson_gxbb_wdt.c +0
-2@@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev)meson_gxbb_wdt_set_timeout (&data->wdt_dev, data->wdt_dev.timeout); -watchdog_stop_on_reboot (&data->wdt_dev);return devm_watchdog_register_device (dev, &data->wdt_dev); } --2.25.1
hi Guenter Roeck
why still not merged to upstream ?
Quoted 18 lines · Artem Lapkin
* Added nowayout module parameter
* Added timeout module parameter
* Removedwatchdog_stop_on_reboothttps://lore.kernel.org/linux-watchdog/[email protected]/T/#t
Artem Lapkin (3):
watchdog:meson_gxbb_wdt: add nowayout parameter
watchdog:meson_gxbb_wdt: add timeout parameter
watchdog:meson_gxbb_wdt: removestop_on_rebootdrivers/watchdog/meson_gxbb_wdt.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)--
2.25.1