Skip to contentSkip to conversation

kernel/auditsc: remove unused header file

PATCH In review Hui Su 2 participants 2 messages Jul 30, 2021 – Aug 2, 2021 Audit

lore
Share & tools
lore

Hui Su

author
#0 lore raw

PATCH 1/1 kernel/auditsc: remove unused header file

Since commit c72051d5778a ("audit: use ktime_get_coarse_ts64() for time access"), the linux/time.h is unused.

---
 kernel/auditsc.c | 1 -
 1 file changed, 1 deletion(-)
kernel/auditsc.c +0 -1
index 8dd73a64f921..33bb6a83baf1 100644
@@ -57,7 +57,6 @@
 #include <linux/mqueue.h>
 #include <linux/audit.h>
 #include <linux/personality.h>
-#include <linux/time.h>
 #include <linux/netlink.h>
 #include <linux/compiler.h>
 #include <asm/unistd.h>
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 14 lines · Hui Su

Since commit c72051d5778a ("audit: use ktime_get_coarse_ts64() for time access"), the linux/time.h is unused.

---
 kernel/auditsc.c | 1 -
 1 file changed, 1 deletion(-)
kernel/auditsc.c +0 -0
index 8dd73a64f921..33bb6a83baf1 100644

kernel/auditsc.c line 62

Quoted 7 lines
kernel/auditsc.c +0 -1
@@ -57,7 +57,6 @@
 #include <linux/mqueue.h>
 #include <linux/audit.h>
 #include <linux/personality.h>
-#include <linux/time.h>
 #include <linux/netlink.h>
 #include <linux/compiler.h>
 #include <asm/unistd.h>

At the very least the kernel/auditsc.c file still makes use of the timespec64 struct which is defined in include/linux/time64.h which is brought in by include/linux/time.h and *not* by include/linux/timekeeping.h. As long as we make use of the timespec64 struct and the definition remains in time64.h let's keep the time.h include.

Signature · 7 lines
paul moore
www.paul-moore.com

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit