Skip to contentSkip to conversation

net/i40e: fix clang warning on non-x86

PATCH Applied Ruifeng Wang 2 participants 2 messages Jul 30, 2021 – Aug 10, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: fix clang warning on non-x86

Build on aarch64 with clang-10 has warning:
i40e_rxtx.c:3228:1: warning: unused function 'get_avx_supported' [-Wunused-function]

The function is used in x86 specific path. Moved it into ifdef to fix build on non-x86.

Fixes c30751afc360 ("net/i40e: fix data path selection in secondary process")
---
 drivers/net/i40e/i40e_rxtx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/i40e/i40e_rxtx.c +2 -4
index 026cda948c..8329cbdd4e 100644
@@ -3224,10 +3224,10 @@ i40e_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,
 	qinfo->conf.offloads = txq->offloads;
 }
 
+#ifdef RTE_ARCH_X86
 static inline bool
 get_avx_supported(bool request_avx512)
 {
-#ifdef RTE_ARCH_X86
 	if (request_avx512) {
 		if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_512 &&
 		rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) == 1 &&
@@ -3251,12 +3251,10 @@ get_avx_supported(bool request_avx512)
 		return false;
 #endif
 	}
-#else
-	RTE_SET_USED(request_avx512);
-#endif /* RTE_ARCH_X86 */
 
 	return false;
 }
+#endif /* RTE_ARCH_X86 */
 
 
 void __rte_cold
Signature · 1 line
2.25.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 15 lines

-----Original Message-----
From: Ruifeng Wang <[email protected]>
Sent: Friday, July 30, 2021 5:33 PM
To: Xing, Beilei <[email protected]>; Yu, DapengX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Ruifeng Wang <[email protected]>
Subject: [PATCH] net/i40e: fix clang warning on non-x86

Build on aarch64 with clang-10 has warning:
i40e_rxtx.c:3228:1: warning: unused function 'get_avx_supported' [-Wunused-function]

Quoted 7 lines

The function is used in x86 specific path. Moved it into ifdef to fix build on non-x86.

Fixes c30751afc360 ("net/i40e: fix data path selection in secondary process")

Applied to dpdk-next-net-intel.

Thanks
Qi