Skip to contentSkip to conversation

arm64/sve: Make fpsimd_bind_task_to_cpu() static

PATCH Applied Mark Brown 3 participants 5 messages Jul 30, 2021 – Aug 2, 2021 arm64

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 arm64/sve: Make fpsimd_bind_task_to_cpu() static

This function is not referenced outside fpsimd.c so can be static, making it that little bit easier to follow what is called from where.

---
 arch/arm64/include/asm/fpsimd.h | 1 -
 arch/arm64/kernel/fpsimd.c      | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm64/include/asm/fpsimd.h +0 -1
index c072161d5c65..9a62884183e5 100644
@@ -45,7 +45,6 @@ extern void fpsimd_preserve_current_state(void);
 extern void fpsimd_restore_current_state(void);
 extern void fpsimd_update_current_state(struct user_fpsimd_state const *state);
 
-extern void fpsimd_bind_task_to_cpu(void);
 extern void fpsimd_bind_state_to_cpu(struct user_fpsimd_state *state,
 				     void *sve_state, unsigned int sve_vl);
 
arch/arm64/kernel/fpsimd.c +3 -1
index e57b23f95284..eb8d972ad3d2 100644
@@ -162,6 +162,8 @@ extern void __percpu *efi_sve_state;
 DEFINE_PER_CPU(bool, fpsimd_context_busy);
 EXPORT_PER_CPU_SYMBOL(fpsimd_context_busy);
 
+static void fpsimd_bind_task_to_cpu(void);
+
 static void __get_cpu_fpsimd_context(void)
 {
 	bool busy = __this_cpu_xchg(fpsimd_context_busy, true);
@@ -1112,7 +1114,7 @@ void fpsimd_signal_preserve_current_state(void)
  * The caller must have ownership of the cpu FPSIMD context before calling
  * this function.
  */
-void fpsimd_bind_task_to_cpu(void)
+static void fpsimd_bind_task_to_cpu(void)
 {
 	struct fpsimd_last_state_struct *last =
 		this_cpu_ptr(&fpsimd_last_state);
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Mark Brown

This function is not referenced outside fpsimd.c so can be static, making it that little bit easier to follow what is called from where.

Otherwise, this seems sensible, since by definition no code that isn't switching task contexts should be calling this directly.

Rather makes me wonder
why it wasn't static in the first place. This might have arisen from splitting out a backend function from something else that isn't static, or maybe I was trying to do this directy from KVM. The notion of non- task context that the KVM now uses is newer than the original SVE code.

Anyway, assuming you've grepped and tried to build with KVM at least (so, defconfig):

Quoted 47 lines
---
 arch/arm64/include/asm/fpsimd.h | 1 -
 arch/arm64/kernel/fpsimd.c      | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm64/include/asm/fpsimd.h +0 -1
index c072161d5c65..9a62884183e5 100644
@@ -45,7 +45,6 @@ extern void fpsimd_preserve_current_state(void);
 extern void fpsimd_restore_current_state(void);
 extern void fpsimd_update_current_state(struct user_fpsimd_state const *state);
 
-extern void fpsimd_bind_task_to_cpu(void);
 extern void fpsimd_bind_state_to_cpu(struct user_fpsimd_state *state,
 				     void *sve_state, unsigned int sve_vl);
 
arch/arm64/kernel/fpsimd.c +3 -1
index e57b23f95284..eb8d972ad3d2 100644
@@ -162,6 +162,8 @@ extern void __percpu *efi_sve_state;
 DEFINE_PER_CPU(bool, fpsimd_context_busy);
 EXPORT_PER_CPU_SYMBOL(fpsimd_context_busy);
 
+static void fpsimd_bind_task_to_cpu(void);
+
 static void __get_cpu_fpsimd_context(void)
 {
 	bool busy = __this_cpu_xchg(fpsimd_context_busy, true);
@@ -1112,7 +1114,7 @@ void fpsimd_signal_preserve_current_state(void)
  * The caller must have ownership of the cpu FPSIMD context before calling
  * this function.
  */
-void fpsimd_bind_task_to_cpu(void)
+static void fpsimd_bind_task_to_cpu(void)
 {
 	struct fpsimd_last_state_struct *last =
 		this_cpu_ptr(&fpsimd_last_state);
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#2 lore raw
Quoted 5 lines · Dave Martin

Rather makes me wonder
why it wasn't static in the first place. This might have arisen from splitting out a backend function from something else that isn't static, or maybe I was trying to do this directy from KVM. The notion of non- task context that the KVM now uses is newer than the original SVE code.

IIRC there was something like that in the older KVM SVE stuff but I didn't go spelunking enough to figure it out specifically.

Quoted 2 lines

Anyway, assuming you've grepped and tried to build with KVM at least (so, defconfig):

grepped and my standard development builds include KVM.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 10 lines · Mark Brown
Quoted 5 lines · Dave Martin

Rather makes me wonder
why it wasn't static in the first place. This might have arisen from splitting out a backend function from something else that isn't static, or maybe I was trying to do this directy from KVM. The notion of non- task context that the KVM now uses is newer than the original SVE code.

IIRC there was something like that in the older KVM SVE stuff but I didn't go spelunking enough to figure it out specifically.

Probably best not to ;)

Quoted 5 lines
Quoted 3 lines

Anyway, assuming you've grepped and tried to build with KVM at least (so, defconfig):

grepped and my standard development builds include KVM.

Fair enough, I would have been very surprised if you hadn't already done that.

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Applied
#4 lore raw
In reply to Mark Brown
Quoted 2 lines · Mark Brown

This function is not referenced outside fpsimd.c so can be static, making it that little bit easier to follow what is called from where.

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64/sve: Make fpsimd_bind_task_to_cpu() static

      https://git.kernel.org/arm64/c/b24b5205099a
Signature · 7 lines
Catalin


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel