Skip to contentSkip to conversation

gcc-runtime: do_check should execute before do_build

PATCH In review [email protected] 3 participants 4 messages Jul 30, 2021 – Jul 31, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-runtime: do_check should execute before do_build

Otherwise, when rm_work is used, do_check may not execute before rm_work causing do_check failures if the workdir has been removed underneath it.

---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-runtime.inc +1 -1
index 59d9a24686..607971adca 100644
@@ -314,5 +314,5 @@ do_check() {
 
     oe_runmake -i ${MAKE_CHECK_TARGETS} RUNTESTFLAGS="${MAKE_CHECK_RUNTESTFLAGS}"
 }
-addtask check after do_compile do_populate_sysroot
+addtask check after do_compile do_populate_sysroot before do_build
 
Signature · 1 line
2.25.1
#1 lore raw

This will result in a behavior change, making it so bitbake gcc-runtime will run the check task. Are there implications to this?

Quoted 28 lines · On Fri, Jul 30, 2021 at 12:04 PM <[email protected]> wrote:

Otherwise, when rm_work is used, do_check may not execute before rm_work causing do_check failures if the workdir has been removed underneath it.

---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/gcc/gcc-runtime.inc +0 -0
index 59d9a24686..607971adca 100644
@@ -314,5 +314,5 @@ do_check() {
 
     oe_runmake -i ${MAKE_CHECK_TARGETS}

RUNTESTFLAGS="${MAKE_CHECK_RUNTESTFLAGS}"
}

meta/recipes-devtools/gcc/gcc-runtime.inc +1 -2
-addtask check after do_compile do_populate_sysroot
+addtask check after do_compile do_populate_sysroot before do_build
 
--

2.25.1

Signature · 4 lines
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
#2 lore raw
Quoted 2 lines · Christopher Larson

This will result in a behavior change, making it so bitbake gcc-runtime will run the check task. Are there implications to this?

We definitely do not want to do that. This is used to run the testsuite which isn't part of a normal build.

Cheers,

Richard

#3 lore raw

I see. I had forgotten that the autobuilders don't run do_check as part of the normal build.

We have a customization in our distro layer to run do_check on normal builds. Internally, we use that as a hook to allow per-package test suites to fail our integration pipeline during our normal builds. Maybe there's a way we can prevent this conflict with rm_work from our own layer.

Sorry for the confusion,

Kyle

Quoted 14 lines · Richard Purdie
Quoted 1 line · Christopher Larson

This will result in a behavior change, making it so `bitbake

gcc-runtime` will

Quoted 1 line

run the check task. Are there implications to this?

We definitely do not want to do that. This is used to run the testsuite which
isn't part of a normal build.

Cheers,

Richard