x86: tangier: Fix DMA controller IRQ polarity in CSRT
PATCH 1/1 x86: tangier: Fix DMA controller IRQ polarity in CSRT
IRQ polarity in CSRT has the same definition as by ACPI specification chapter 19.6.64 "Interrupt (Interrupt Resource Descriptor Macro)", i.e. ActiveHigh is 0, and ActiveLow is 1. On Intel Tangier the DMA controller IRQ polarity is ActiveHigh.
Note, in DSDT (see southcluster.asl) it's described correctly.
--- arch/x86/cpu/tangier/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/cpu/tangier/acpi.c +2 -2
@@ -89,8 +89,8 @@ static u32 acpi_fill_csrt_dma(struct acpi_csrt_group *grp) si->mmio_base_low =0xff192000 ; si->mmio_base_high =0 ; si->gsi_interrupt =32 ; - si->interrupt_polarity =1 ; - si->interrupt_mode =0 ; + si->interrupt_polarity =0 ;/* Active High */ + si->interrupt_mode =0 ;/* Level triggered */ si->num_channels =8 ; si->dma_address_width =32 ; si->base_request_line =0 ;
Signature · 1 line
2.30.2
Quoted 6 lines · Andy Shevchenko
IRQ polarity in CSRT has the same definition as by ACPI specification chapter 19.6.64 "Interrupt (Interrupt Resource Descriptor Macro)", i.e. ActiveHigh is 0, and ActiveLow is 1. On Intel Tangier the DMA controller IRQ polarity is ActiveHigh.
Quoted 8 lines
Note, in DSDT (see southcluster.asl) it's described correctly.
Fixes 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 11 lines · Bin Meng
Quoted 8 lines · Andy Shevchenko
IRQ polarity in CSRT has the same definition as by ACPI specification chapter 19.6.64 "Interrupt (Interrupt Resource Descriptor Macro)", i.e. ActiveHigh is 0, and ActiveLow is 1. On Intel Tangier the DMA controller IRQ polarity is ActiveHigh.
Note, in DSDT (see southcluster.asl) it's described correctly.
Quoted 8 lines
Quoted 6 lines
Fixes 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Reviewed-by Bin Meng <[email protected]>
applied to u-boot-x86, thanks!
Quoted 6 lines · Andy Shevchenko
IRQ polarity in CSRT has the same definition as by ACPI specification chapter 19.6.64 "Interrupt (Interrupt Resource Descriptor Macro)", i.e. ActiveHigh is 0, and ActiveLow is 1. On Intel Tangier the DMA controller IRQ polarity is ActiveHigh.
Quoted 7 lines
Note, in DSDT (see southcluster.asl) it's described correctly.
Fixes 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Hi Simon,
Quoted 11 lines · Simon Glass
Quoted 8 lines · Andy Shevchenko
IRQ polarity in CSRT has the same definition as by ACPI specification chapter 19.6.64 "Interrupt (Interrupt Resource Descriptor Macro)", i.e. ActiveHigh is 0, and ActiveLow is 1. On Intel Tangier the DMA controller IRQ polarity is ActiveHigh.
Note, in DSDT (see southcluster.asl) it's described correctly.
Quoted 7 lines
Quoted 5 lines
Fixes 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller")Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/cpu/tangier/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Reviewed-by Simon Glass <[email protected]>
Oops, this was applied 1 minute earlier :-)
I've added your RB tag manually.
Regards,
Bin