Skip to contentSkip to conversation

net/bnxt: fix seg fault on Thor

PATCH In review Ajit Khaparde 1 participant 2 messages Jul 30, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: fix seg fault on Thor

In a few cases with Thor device, PMD can segfault when VF representors are specified. Temporarily fix it by preventing VF reps for Thor device. This will be addressed in next release.

Fixes 3fe124d2536c ("net/bnxt: support Thor platform")
---
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/bnxt/tf_ulp/bnxt_ulp.c +5 -0
index fa2148ead7..dbf85e4eda 100644
@@ -815,6 +815,11 @@ ulp_ctx_init(struct bnxt *bp,
 		goto error_deinit;
 	}
 
+	if (devid == BNXT_ULP_DEVICE_ID_THOR) {
+		ulp_data->ulp_flags &= ~BNXT_ULP_VF_REP_ENABLED;
+		BNXT_TF_DBG(ERR, "Enabled non-VFR mode\n");
+	}
+
 	/*
 	 * Shared session must be created before first regular session but after
 	 * the ulp_ctx is valid.
Signature · 1 line
2.21.1 (Apple Git-122.3)
#1 lore raw
Quoted 9 lines · Ajit Khaparde

In a few cases with Thor device, PMD can segfault when VF representors are specified. Temporarily fix it by preventing VF reps for Thor device. This will be addressed in next release.

Fixes 3fe124d2536c ("net/bnxt: support Thor platform")

Updated the commit headline to
"net/bnxt: disable VF representors on Thor"
Merged to dpdk-next-net-brcm.

Quoted 23 lines
---
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/bnxt/tf_ulp/bnxt_ulp.c +5 -1
index fa2148ead7..dbf85e4eda 100644
@@ -815,6 +815,11 @@ ulp_ctx_init(struct bnxt *bp,
                goto error_deinit;
        }
 
+       if (devid == BNXT_ULP_DEVICE_ID_THOR) {
+               ulp_data->ulp_flags &= ~BNXT_ULP_VF_REP_ENABLED;
+               BNXT_TF_DBG(ERR, "Enabled non-VFR mode\n");
+       }
+
        /*
         * Shared session must be created before first regular session but after
         * the ulp_ctx is valid.
--

2.21.1 (Apple Git-122.3)