two bsg fixes
Subsystems (2)
Hi Martin,
this series contains two small fixes for commands without data transfer for the recent bsg changes.
PATCH 1/2 scsi: bsg: fix commands without data transfer in scsi_bsg_sg_io_fn
Set ret to 0 after the initial permission checks to avoid leaking -EPERM for commands without data transfer.
Fixes 75ca56409e5b ("scsi: bsg: Move the whole request execution into the SCSI/transport handlers")
Signed-off-by Christoph Hellwig <[email protected]>
--- drivers/scsi/scsi_bsg.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/scsi_bsg.c +1 -0
@@ -47,6 +47,7 @@ static int scsi_bsg_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr,if (!scsi_cmd_allowed (sreq->cmd, mode)) goto out_free_cmd; + ret =0 ;if (hdr->dout_xfer_len) { ret =blk_rq_map_user (rq->q, rq,NULL ,uptr64 (hdr->dout_xferp), hdr->dout_xfer_len,GFP_KERNEL );
Signature · 1 line
2.30.2
PATCH 2/2 bsg-lib: fix commands without data transfer in bsg_transport_sg_io_fn
In reply to Christoph HellwigSet ret to 0 after the initial permission checks to avoid leaking -EPERM for commands without data transfer.
Fixes 75ca56409e5b ("scsi: bsg: Move the whole request execution into the SCSI/transport
handlers")
Signed-off-by Christoph Hellwig <[email protected]>
--- block/bsg-lib.c | 1 + 1 file changed, 1 insertion(+)
block/bsg-lib.c +1 -0
@@ -72,6 +72,7 @@ static int bsg_transport_sg_io_fn(struct request_queue *q, struct sg_io_v4 *hdr, job->bidi_bio =NULL ; } + ret =0 ;if (hdr->dout_xfer_len) { ret =blk_rq_map_user (rq->q, rq,NULL ,uptr64 (hdr->dout_xferp), hdr->dout_xfer_len,GFP_KERNEL );
Signature · 1 line
2.30.2
Martin K. Petersen
AppliedChristoph,
Quoted 2 lines
this series contains two small fixes for commands without data transfer for the recent bsg changes.
Applied to 5.15/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering