Skip to contentSkip to conversation

netfilter: nf_conntrack_bridge: Fix memory leak when error

PATCH Applied Yajun Deng 2 participants 2 messages Jul 29, 2021 – Aug 1, 2021

Subsystems (4)
lore
Share & tools
lore

Yajun Deng

author
#0 lore raw

PATCH v3 1/1 netfilter: nf_conntrack_bridge: Fix memory leak when error

It should be added kfree_skb_list() when err is not equal to zero in nf_br_ip_fragment().

v2: keep this aligned with IPv6.
v3: modify iter.frag_list to iter.frag.

Fixes 3c171f496ef5 ("netfilter: bridge: add connection tracking system")
---
 net/bridge/netfilter/nf_conntrack_bridge.c | 5 +++++
 1 file changed, 5 insertions(+)
net/bridge/netfilter/nf_conntrack_bridge.c +5 -0
index 8d033a75a766..d184306e1ba8 100644
@@ -88,6 +88,11 @@ static int nf_br_ip_fragment(struct net *net, struct sock *sk,
 
 			skb = ip_fraglist_next(&iter);
 		}
+
+		if (!err)
+			return 0;
+
+		kfree_skb_list(iter.frag);
 		return err;
 	}
 slow_path:
Signature · 1 line
2.32.0
maintainer Applied
#1 lore raw
Quoted 2 lines · Yajun Deng

It should be added kfree_skb_list() when err is not equal to zero in nf_br_ip_fragment().

Applied, thanks.