Skip to contentSkip to conversation

drivers: mtd: ubi: fixed a semicolon style issue in block.c

PATCH In review Rahul Balaji 2 participants 4 messages Aug 1, 2021 – Aug 2, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: mtd: ubi: fixed a semicolon style issue in block.c

fixed a small coding style issue in using semicolon.

---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/block.c +1 -1
index e003b4b44ffa..e0402c2f8959 100644
@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 	ret = blk_mq_alloc_tag_set(&dev->tag_set);
 	if (ret) {
 		dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed");
-		goto out_free_dev;;
+		goto out_free_dev;
 	}
 
 
Signature · 6 lines
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
#1 lore raw

respected mentor,

I have sent the first patch only as per the task. please do give me your confirmation so that i can proceed further with the other patches too

Thank you,
sincerely,
rahul.

Quoted 22 lines · Rahul Balaji

fixed a small coding style issue in using semicolon.

---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/block.c +1 -2
index e003b4b44ffa..e0402c2f8959 100644
@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
        ret = blk_mq_alloc_tag_set(&dev->tag_set);
        if (ret) {
                dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set
 failed");
-               goto out_free_dev;;
+               goto out_free_dev;
        }
 
 
--
Quoted 3 lines

2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#2 lore raw

sorry for that slight misunderstanding. i thought the first patch meant only a small test patch for the first file. I will send the other changes shortly too.

Thank you for your understanding.

yours sincerely,
Rahul.

Quoted 33 lines · Rahul Balaji

respected mentor,

I have sent the first patch only as per the task. please do give me your confirmation so that i can proceed further with the other patches too

Thank you,
sincerely,
rahul.

Quoted 21 lines · Rahul Balaji

fixed a small coding style issue in using semicolon.

---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/block.c +1 -1
index e003b4b44ffa..e0402c2f8959 100644
@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
        ret = blk_mq_alloc_tag_set(&dev->tag_set);
        if (ret) {
                dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set
 failed");
-               goto out_free_dev;;
+               goto out_free_dev;
        }
 
Quoted 4 lines
Quoted 4 lines

--
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#3 lore raw
In reply to Rahul Balaji

Use imperative: Subject line shall be in imperative form.

Quoted 3 lines · Rahul Balaji

fixed a small coding style issue in using semicolon.

Mention your motivation, i.e., the investigation of the ONE_SEMICOLON rule.

Mention if this change modifies the code's behaviour.

If not, add to the comment message:

"No functional change."

Quoted 1 line

signed-off-by is written as "Signed-off-by:".

Did you run checkpatch on your patch? What is the checkpatch output running your patch? Please share that with us.

Give it another try and create a PATCH v2.

Lukas

Quoted 18 lines
---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/block.c +1 -2
index e003b4b44ffa..e0402c2f8959 100644
@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
        ret = blk_mq_alloc_tag_set(&dev->tag_set);
        if (ret) {
                dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed");
-               goto out_free_dev;;
+               goto out_free_dev;
        }
 
 
--
Quoted 2 lines

2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees