net/ice: remove redundant default RSS field for IP fragment packets
PATCH 2/2 net/ice: remove redundant default RSS field for IP fragment packets
This patch removes redundant default RSS field for IP fragment packets, only src MAC address and dst MAC address are needed.
--- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
@@ -2975,7 +2975,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV4 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV4 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV4 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV4_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV4 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d",
@@ -2984,7 +2984,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV6 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV6 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV6 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV6_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV6 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d",
Signature · 1 line
2.25.1
Quoted 3 lines · Wenjun Wu
This patch removes redundant default RSS field for IP fragment packets, only src MAC address and dst MAC address are needed.
Same comments with first patch.
Impact is not clear, and this patch seems a little different from first path, this clears one flag from 'cfg.hash_flds', why and if this is not causing any impact (that is what I understand from description) can you explain in the commit log why it doesn't change the behavior of the code?
Also again long patch title.
Quoted 28 lines
Signed-off-by Wenjun Wu <[email protected]>--- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ice/ice_ethdev.c +2
-2@@ -2975,7 +2975,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV4 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV4 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV4 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV4_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV4 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d",@@ -2984,7 +2984,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV6 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV6 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV6 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV6_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV6 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d",
PATCH v2 2/2 net/ice: fix default RSS field for IP fragment packets
In reply to Wenjun WuPreviously IP ID field is supported in default RSS for IP fragment packets. Actually it is not expected.
This patch removes redundant default RSS field for IP fragment packets. The default RSS only needs to support the src and dst IP fields.
--- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
@@ -2975,7 +2975,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV4 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV4 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV4 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV4_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV4 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d",
@@ -2984,7 +2984,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV6 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV6 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV6 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV6_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV6 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d",
Signature · 1 line
2.25.1
PATCH v3 2/2 net/ice: fix default RSS field for IP fragment packets
Previously, hash value is calculated by src IP address, dst IP address and IP ID. However, default RSS field only needs src and dst IP address.
This patch removes IP ID from default RSS field for IP fragment packets to improve default RSS configuration.
--- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ice/ice_ethdev.c +2 -2
@@ -2975,7 +2975,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV4 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV4 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV4 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV4_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV4 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d",
@@ -2984,7 +2984,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)if (rss_hf Ð_RSS_FRAG_IPV6 ) { cfg.addl_hdrs =ICE_FLOW_SEG_HDR_IPV6 |ICE_FLOW_SEG_HDR_IPV_FRAG ; - cfg.hash_flds =ICE_FLOW_HASH_IPV6 |BIT_ULL (ICE_FLOW_FIELD_IDX_IPV6_ID ); + cfg.hash_flds =ICE_FLOW_HASH_IPV6 ; ret =ice_add_rss_cfg_wrap (pf, vsi->idx, &cfg);if (ret) PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d",
Signature · 1 line
2.25.1