doc: announce eth queue release callback parameter change
PATCH 1/2 doc: announce eth queue release callback parameter change
This patch announces the parameter change of eth_queue_release_t callback API to eth_dev_ops in DPDK v21.11.
[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215654.html
--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -131,6 +131,9 @@ Deprecation Notices consistent with existing outer header checksum status flag naming, which should help in reducing confusion about its usage. +* ethdev: queue release callback parameter will be changed to device and queue + ID to align with other queue configureation callback. + * i40e: As there are both i40evf and iavf pmd, the functions of them are duplicated. And now more and more advanced features are developed on iavf. To keep consistent with kernel driver's name
Signature · 1 line
2.25.1
PATCH 2/2 doc: announce eth new offload flag and group field
To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11.
[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html
--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -131,6 +131,9 @@ Deprecation Notices consistent with existing outer header checksum status flag naming, which should help in reducing confusion about its usage. +* ethdev: add new Rx queue offload flag ``RTE_ETH_RX_OFFLOAD_SHARED_RXQ`` and + ``shared_group`` field to struct rte_eth_rxconf. + * ethdev: queue release callback parameter will be changed to device and queue ID to align with other queue configureation callback.
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field
Quoted 8 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Monday, August 2, 2021 16:11
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field
Quoted 8 lines
To support shared Rx queue, this patch announces new offload flag
RTE_ETH_RX_OFFLOAD_SHARED_RXQand newshared_groupfield to structrte_eth_rxconfin DPDK v21.11.[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.htmlSigned-off-by Xueming Li <[email protected]>
We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.
Andrew Rybchenko
Acked-byRe: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field
Quoted 15 lines · Slava Ovsiienko
Quoted 15 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Monday, August 2, 2021 16:11
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group fieldTo support shared Rx queue, this patch announces new offload flag
RTE_ETH_RX_OFFLOAD_SHARED_RXQand newshared_groupfield to structrte_eth_rxconfin DPDK v21.11.[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html
Quoted 8 lines
Quoted 1 line
Signed-off-by Xueming Li <[email protected]>We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.
Jerin Jacob
Acked-byRe: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field
Quoted 19 lines · Andrew Rybchenko
Quoted 17 lines · Slava Ovsiienko
Quoted 16 lines
-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Monday, August 2, 2021 16:11
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group fieldTo support shared Rx queue, this patch announces new offload flag
RTE_ETH_RX_OFFLOAD_SHARED_RXQand newshared_groupfield to structrte_eth_rxconfin DPDK v21.11.[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.htmlSigned-off-by Xueming Li <[email protected]>
Quoted 8 lines
Quoted 6 lines
We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.
Acked-by Andrew Rybchenko <[email protected]>
Thomas Monjalon
AppliedRe: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
To support shared Rx queue, this patch announces new offload flag
RTE_ETH_RX_OFFLOAD_SHARED_RXQand newshared_groupfield to structrte_eth_rxconfin DPDK v21.11.[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.htmlSigned-off-by Xueming Li <[email protected]>
Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.
Acked-by Andrew Rybchenko <[email protected]>Acked-by Jerin Jacob <[email protected]>
Applied, thanks.
Quoted 17 lines · Xueming Li
This patch announces the parameter change of
eth_queue_release_tcallback API toeth_dev_opsin DPDK v21.11.[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215654.htmlSigned-off-by Xueming Li <[email protected]>--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)doc/guides/rel_notes/deprecation.rst +0
-0
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 139
Quoted 9 lines
doc/guides/rel_notes/deprecation.rst +3
-0@@ -131,6 +131,9 @@ Deprecation Notices consistent with existing outer header checksum status flag naming, which should help in reducing confusion about its usage. +* ethdev: queue release callback parameter will be changed to device and queue + ID to align with other queue configureation callback. + * i40e: As there are both i40evf and iavf pmd, the functions of them are duplicated. And now more and more advanced features are developed on iavf. To keep consistent with kernel driver's name
Isn't it an internal callback and no deprecation notice required to change it?
"to align with" is a bit weak justification that so huge change is required (really many sources must be fixed). I guess it could be required for shared RxQ. If so, it should be mentioned.
Quoted 30 lines
-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Wednesday, August 4, 2021 8:28 PM
To: Xueming(Steven) Li <[email protected]>
Cc: [email protected]; Ray Kinsella <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce eth queue release callback parameter changeQuoted 20 lines · Xueming Li
This patch announces the parameter change of
eth_queue_release_tcallback API toeth_dev_opsin DPDK v21.11.[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215654.htmlSigned-off-by Xueming Li <[email protected]>--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)doc/guides/rel_notes/deprecation.rst +0
-0@@ -131,6 +131,9 @@ Deprecation Notices consistent with existing outer header checksum status flag naming, which should help in reducing confusion about its usage.
Quoted 10 lines
doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 139
Quoted 8 lines
doc/guides/rel_notes/deprecation.rst +4
-0+* ethdev: queue release callback parameter will be changed to device +and queue + ID to align with other queue configureation callback. + * i40e: As there are both i40evf and iavf pmd, the functions of them are duplicated. And now more and more advanced features are developed on iavf. To keep consistent with kernel driver's nameIsn't it an internal callback and no deprecation notice required to change it?
Agree, let's drop this deprecation notice. Thanks for pointing this out.
Quoted 3 lines
"to align with" is a bit weak justification that so huge change is required (really many sources must be fixed). I guess it could be required for shared RxQ. If so, it should be mentioned.