Skip to contentSkip to conversation

doc: announce eth queue release callback parameter change

PATCH Applied Xueming Li 5 participants 8 messages Aug 2, 2021 – Aug 7, 2021

lore
Share & tools
lore

Xueming Li

author
#0 lore raw

PATCH 1/2 doc: announce eth queue release callback parameter change

This patch announces the parameter change of eth_queue_release_t callback API to eth_dev_ops in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215654.html

---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
index d9c0e65921..c38aebe99d 100644
@@ -131,6 +131,9 @@ Deprecation Notices
   consistent with existing outer header checksum status flag naming, which
   should help in reducing confusion about its usage.
 
+* ethdev: queue release callback parameter will be changed to device and queue
+  ID to align with other queue configureation callback.
+
 * i40e: As there are both i40evf and iavf pmd, the functions of them are
   duplicated. And now more and more advanced features are developed on iavf.
   To keep consistent with kernel driver's name
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 doc: announce eth new offload flag and group field

To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html

---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
index c38aebe99d..14f1f2dca7 100644
@@ -131,6 +131,9 @@ Deprecation Notices
   consistent with existing outer header checksum status flag naming, which
   should help in reducing confusion about its usage.
 
+* ethdev: add new Rx queue offload flag ``RTE_ETH_RX_OFFLOAD_SHARED_RXQ`` and
+  ``shared_group`` field to struct rte_eth_rxconf.
+
 * ethdev: queue release callback parameter will be changed to device and queue
   ID to align with other queue configureation callback.
 
Signature · 1 line
2.25.1
Acked-by on v1 2/2
#2 lore raw

Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

Quoted 8 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Monday, August 2, 2021 16:11
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

Quoted 8 lines

To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html

We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.

#3 lore raw

Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

Quoted 15 lines · Slava Ovsiienko
Quoted 15 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Monday, August 2, 2021 16:11
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html

Quoted 8 lines
Quoted 1 line

We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.

Acked-by
#4 lore raw

Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

Quoted 19 lines · Andrew Rybchenko
Quoted 17 lines · Slava Ovsiienko
Quoted 16 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Xueming Li
Sent: Monday, August 2, 2021 16:11
Cc: [email protected]; Xueming(Steven) Li <[email protected]>; Ray Kinsella <[email protected]>
Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html

Quoted 8 lines
Quoted 6 lines

We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.

#5 lore raw

Re: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and group field

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

To support shared Rx queue, this patch announces new offload flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct rte_eth_rxconf in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html

Quoted 7 lines
Quoted 6 lines
Quoted 5 lines

We need this change to handle shared queues - the same queue object can be shared by multiple ports, and releasing routine should know exactly on which port_id/queue_id object is being released.

Applied, thanks.

#6 lore raw
In reply to Xueming Li
Quoted 17 lines · Xueming Li

This patch announces the parameter change of eth_queue_release_t callback API to eth_dev_ops in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215654.html

---
  doc/guides/rel_notes/deprecation.rst | 3 +++
  1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index d9c0e65921..c38aebe99d 100644

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 139

Quoted 9 lines
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -131,6 +131,9 @@ Deprecation Notices
    consistent with existing outer header checksum status flag naming, which
    should help in reducing confusion about its usage.
 
+* ethdev: queue release callback parameter will be changed to device and queue
+  ID to align with other queue configureation callback.
+
  * i40e: As there are both i40evf and iavf pmd, the functions of them are
    duplicated. And now more and more advanced features are developed on iavf.
    To keep consistent with kernel driver's name

Isn't it an internal callback and no deprecation notice required to change it?

"to align with" is a bit weak justification that so huge change is required (really many sources must be fixed). I guess it could be required for shared RxQ. If so, it should be mentioned.

#7 lore raw
Quoted 30 lines

-----Original Message-----
From: Andrew Rybchenko <[email protected]>
Sent: Wednesday, August 4, 2021 8:28 PM
To: Xueming(Steven) Li <[email protected]>
Cc: [email protected]; Ray Kinsella <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce eth queue release callback parameter change

Quoted 20 lines · Xueming Li

This patch announces the parameter change of eth_queue_release_t callback API to eth_dev_ops in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215654.html

---
  doc/guides/rel_notes/deprecation.rst | 3 +++
  1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +0 -0
index d9c0e65921..c38aebe99d 100644
@@ -131,6 +131,9 @@ Deprecation Notices
    consistent with existing outer header checksum status flag naming, which
    should help in reducing confusion about its usage.
 
Quoted 10 lines

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 139

Quoted 8 lines
doc/guides/rel_notes/deprecation.rst +4 -0
+* ethdev: queue release callback parameter will be changed to device
+and queue
+  ID to align with other queue configureation callback.
+
  * i40e: As there are both i40evf and iavf pmd, the functions of them are
    duplicated. And now more and more advanced features are developed on iavf.
    To keep consistent with kernel driver's name

Isn't it an internal callback and no deprecation notice required to change it?

Agree, let's drop this deprecation notice. Thanks for pointing this out.

Quoted 3 lines

"to align with" is a bit weak justification that so huge change is required (really many sources must be fixed). I guess it could be required for shared RxQ. If so, it should be mentioned.