wifi: Set ieee80211w as required for WPA3-Personal-only mode
PATCH 1/1 wifi: Set ieee80211w as required for WPA3-Personal-only mode
From wpa_supplicant docs [0] section "ieee80211w":
"WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE".
This means that the parameter ieee80211w has to be set to 2 (required) if SAE is used. Fix it.
[0] https://w1.fi/cgit/hostap/plain/wpa_supplicant/wpa_supplicant.conf
--- plugins/wifi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
plugins/wifi.c +6 -1
@@ -2174,7 +2174,12 @@ static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network) security =connman_network_get_string (network,"WiFi.Security" ); ssid->security =network_security (security); ssid->keymgmt = network_data->keymgmt; - ssid->ieee80211w =G_SUPPLICANT_MFP_OPTIONAL ; +/* +* From wpa_supplicant docs: +* "WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE". +* Set ieee80211w as required, which is sent if SAE key is used. +*/ + ssid->ieee80211w =G_SUPPLICANT_MFP_REQUIRED ; ssid->passphrase =connman_network_get_string (network,"WiFi.Passphrase" );
Signature · 1 line
2.30.2
Hi Ariel,
Thanks for tracking this! Just a stupid question:
Quoted 17 lines · Ariel D'Alessandro
From
wpa_supplicantdocs [0] section "ieee80211w":"WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE".
This means that the parameter ieee80211w has to be set to 2 (required) if SAE is used. Fix it.
[0] https://w1.fi/cgit/hostap/plain/wpa_supplicant/wpa_supplicant.conf
--- plugins/wifi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)plugins/wifi.c +0
-0
plugins/wifi.c static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network) · line 2182
Quoted 10 lines
plugins/wifi.c +6
-1@@ -2174,7 +2174,12 @@ static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network) security =connman_network_get_string (network,"WiFi.Security" ); ssid->security =network_security (security); ssid->keymgmt = network_data->keymgmt; - ssid->ieee80211w =G_SUPPLICANT_MFP_OPTIONAL ; +/* +* From wpa_supplicant docs: +* "WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE". +* Set ieee80211w as required, which is sent if SAE key is used. +*/ + ssid->ieee80211w =G_SUPPLICANT_MFP_REQUIRED ;
Should we check the keymgmt is SAE and only then set the ieee80211w value?
Thanks,
Daniel
Hi Daniel,
Quoted 3 lines · Daniel Wagner
Hi Ariel,
Thanks for tracking this! Just a stupid question:
Thanks for the quick feedback :-) see below.
Quoted 24 lines · Ariel D'Alessandro
Quoted 22 lines
From
wpa_supplicantdocs [0] section "ieee80211w":"WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE".
This means that the parameter ieee80211w has to be set to 2 (required) if SAE is used. Fix it.
[0] https://w1.fi/cgit/hostap/plain/wpa_supplicant/wpa_supplicant.conf
--- plugins/wifi.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)plugins/wifi.c +1
-1@@ -2174,7 +2174,12 @@ static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network) security =connman_network_get_string (network,"WiFi.Security" ); ssid->security =network_security (security); ssid->keymgmt = network_data->keymgmt; - ssid->ieee80211w =G_SUPPLICANT_MFP_OPTIONAL ; +/*
Quoted 8 lines
plugins/wifi.c static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network) · line 2182
Quoted 5 lines
plugins/wifi.c +5
-0+* From wpa_supplicant docs: +* "WPA3-Personal-only mode: ieee80211w=2 and key_mgmt=SAE". +* Set ieee80211w as required, which is sent if SAE key is used. +*/ + ssid->ieee80211w =G_SUPPLICANT_MFP_REQUIRED ;Should we check the keymgmt is SAE and only then set the ieee80211w value?
Thanks for asking that, two answers:
* ssid->ieee80211w only gets sent if key management is SAE, so that'd be redundant. See this code block [0]. So, there's no real need to check the keymgmt is SAE here, and required could be the default value.
* On the other hand, my concern now is about supporting SAE transition mode. Let's *drop* this patchset and I'll send an RFC patch implementing WPA3-Personal transition mode.
Thanks!
Ariel
[0]
https://git.kernel.org/pub/scm/network/connman/connman.git/tree/gsupplicant/supplicant.c#n4908
Hi Ariel,
Quoted 8 lines · Ariel D'Alessandro
Quoted 2 lines
Should we check the keymgmt is SAE and only then set the ieee80211w value?
Thanks for asking that, two answers:
*
ssid->ieee80211wonly gets sent if key management is SAE, so that'd be redundant. See this code block [0]. So, there's no real need to check the keymgmt is SAE here, andrequiredcould be the default value.
Ah yes, that filters out the ieee80211w settings if it's not SAE. Didn't see it :)
Quoted 3 lines
* On the other hand, my concern now is about supporting SAE transition mode. Let's *drop* this patchset and I'll send an RFC patch implementing WPA3-Personal transition mode.
Okay :)
Daniel