net: sparx5: fix bitmask on 32-bit targets
Subsystems (3)
PATCH 1/1 net: sparx5: fix bitmask on 32-bit targets
From: Arnd Bergmann <[email protected]>
I saw the build failure that was fixed in commit 6387f65e2acb ("net:
sparx5: fix compiletime_assert for GCC 4.9") and noticed another issue that was introduced in the same patch: Using GENMASK() to create a 64-bit mask does not work on 32-bit architectures.
This probably won't ever happen on this driver since it's specific to a 64-bit SoC, but it's better to write it portably, so use GENMASK_ULL() instead.
--- drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c +1 -1
@@ -32,7 +32,7 @@ static void __ifh_encode_bitfield(void *ifh, u64 value, u32 pos, u32 width)u32 byte = (35 - (pos /8 ));/* Calculate the Start bit position in the Start IFH byte */ u32 bit = (pos %8 ); -u64 encode =GENMASK (bit + width -1 , bit) & (value << bit); +u64 encode =GENMASK_ULL (bit + width -1 , bit) & (value << bit);/* The b0-b7 goes into the start IFH byte */ if (encode &0xFF )
Signature · 1 line
2.29.2
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 8 lines · On Mon, 2 Aug 2021 17:21:53 +0200 you wrote:
From: Arnd Bergmann <[email protected]>
I saw the build failure that was fixed in commit
6387f65e2acb("net:
sparx5: fixcompiletime_assertfor GCC 4.9") and noticed another issue that was introduced in the same patch: UsingGENMASK()to create a 64-bit mask does not work on 32-bit architectures.[...]
Here is the summary with links:
- net: sparx5: fix bitmask on 32-bit targets
https://git.kernel.org/netdev/net/c/f41e57af926a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html