Skip to contentSkip to conversation

selftests/bpf: Test btf__load_vmlinux_btf/btf__load_module_btf APIs

PATCH Superseded Hengqi Chen 2 participants 2 messages Aug 2, 2021

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests/bpf: Test btf__load_vmlinux_btf/btf__load_module_btf APIs

Add test for btf__load_vmlinux_btf/btf__load_module_btf APIs. It first checks that if btrfs module BTF exists, if yes, load module BTF and check symbol existence.

---
 .../selftests/bpf/prog_tests/btf_module.c     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/btf_module.c
tools/testing/selftests/bpf/prog_tests/btf_module.c new file +32 -0
new file mode 100644
index 000000000000..9314a46e001c
@@ -0,0 +1,32 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2021 Hengqi Chen */
+
+#include <test_progs.h>
+#include <bpf/btf.h>
+
+static const char *module_path = "/sys/kernel/btf/btrfs";
+static const char *module_name = "btrfs";
+
+void test_btf_module()
+{
+	struct btf *vmlinux_btf, *module_btf;
+	__s32 type_id;
+
+	if (access(module_path, F_OK))
+		return;
+
+	vmlinux_btf = btf__load_vmlinux_btf();
+	if (!ASSERT_OK_PTR(vmlinux_btf, "could not load vmlinux BTF"))
+		return;
+
+	module_btf = btf__load_module_btf(module_name, vmlinux_btf);
+	if (!ASSERT_OK_PTR(module_btf, "could not load module BTF"))
+		goto cleanup;
+
+	type_id = btf__find_by_name(module_btf, "btrfs_file_open");
+	ASSERT_GT(type_id, 0, "func btrfs_file_open not found");
+
+cleanup:
+	btf__free(module_btf);
+	btf__free(vmlinux_btf);
+}

--
2.25.1

#1 lore raw
Quoted 23 lines · Hengqi Chen

Add test for btf__load_vmlinux_btf/btf__load_module_btf APIs. It first checks that if btrfs module BTF exists, if yes, load module BTF and check symbol existence.

---
 .../selftests/bpf/prog_tests/btf_module.c     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/btf_module.c
tools/testing/selftests/bpf/prog_tests/btf_module.c new file +6 -0
new file mode 100644
index 000000000000..9314a46e001c
@@ -0,0 +1,32 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2021 Hengqi Chen */
+
+#include <test_progs.h>
+#include <bpf/btf.h>
+

tools/testing/selftests/bpf/prog_tests/btf_module.c line 16

Quoted 10 lines
tools/testing/selftests/bpf/prog_tests/btf_module.c new file +10 -0
+static const char *module_path = "/sys/kernel/btf/btrfs";
+static const char *module_name = "btrfs";
+
+void test_btf_module()
+{
+       struct btf *vmlinux_btf, *module_btf;
+       __s32 type_id;
+
+       if (access(module_path, F_OK))
+               return;

we shouldn't use btrfs module, as it might not be mounted in our CI environment. Good news is that selftests uses its own custom module to do various module-related logic. It's already preloaded for all tests, so you can just assume its existence (unless pre-loading fails, then error out). See how "bpf_testmod" is used in selftests.

Quoted 18 lines
tools/testing/selftests/bpf/prog_tests/btf_module.c new file +16 -1
+
+       vmlinux_btf = btf__load_vmlinux_btf();
+       if (!ASSERT_OK_PTR(vmlinux_btf, "could not load vmlinux BTF"))
+               return;
+
+       module_btf = btf__load_module_btf(module_name, vmlinux_btf);
+       if (!ASSERT_OK_PTR(module_btf, "could not load module BTF"))
+               goto cleanup;
+
+       type_id = btf__find_by_name(module_btf, "btrfs_file_open");
+       ASSERT_GT(type_id, 0, "func btrfs_file_open not found");
+
+cleanup:
+       btf__free(module_btf);
+       btf__free(vmlinux_btf);
+}
--

2.25.1