Skip to contentSkip to conversation

meta-arm-toolchain: Convert to new override syntax

PATCH In review Khem Raj 2 participants 3 messages Aug 2, 2021 – Aug 3, 2021

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 meta-arm-toolchain: Convert to new override syntax

---
 meta-arm-toolchain/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-toolchain/conf/layer.conf +1 -1
index 04486d4..41305ee 100644
@@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
 BB_DANGLINGAPPENDS_WARNONLY = "true"
 
 # These variables are used for armcompiler license
-BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
+BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
Signature · 1 line
2.32.0
#1 lore raw

Hi Khem,

Quoted 11 lines · Khem Raj
---
 meta-arm-toolchain/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-toolchain/conf/layer.conf +0 -0
index 04486d4..41305ee 100644

meta-arm-toolchain/conf/layer.conf LAYERSERIES_COMPAT_arm-toolchain = "hardknott" · line 21

Quoted 5 lines
meta-arm-toolchain/conf/layer.conf +1 -1
@@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
 BB_DANGLINGAPPENDS_WARNONLY = "true"
 
 # These variables are used for armcompiler license
-BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
+BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"

This only looks like change for one instance of override and there are many other instances in meta-arm-toolchain. I think the new override syntax brings more clarity. So I would suggest converting all other instances of overrides to new syntax as well.

-Sumit

Quoted 6 lines

--
2.32.0

author
#2 lore raw

yeah ignore this. I have more changes after this

Quoted 34 lines · Sumit Garg

Hi Khem,

Quoted 11 lines · Khem Raj
---
 meta-arm-toolchain/conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arm-toolchain/conf/layer.conf +0 -0
index 04486d4..41305ee 100644

meta-arm-toolchain/conf/layer.conf LAYERSERIES_COMPAT_arm-toolchain = "hardknott" · line 21

Quoted 5 lines
meta-arm-toolchain/conf/layer.conf +1 -1
@@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
 BB_DANGLINGAPPENDS_WARNONLY = "true"
 
 # These variables are used for armcompiler license
-BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
+BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"

This only looks like change for one instance of override and there are many other instances in meta-arm-toolchain. I think the new override syntax brings more clarity. So I would suggest converting all other instances of overrides to new syntax as well.

-Sumit

Quoted 6 lines

--
2.32.0