Skip to contentSkip to conversation

drm/amdgpu: don't enable baco on boco platforms in runpm

PATCH In review Alex Deucher 2 participants 2 messages Aug 2, 2021 – Aug 4, 2021

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu: don't enable baco on boco platforms in runpm

If the platform uses BOCO, don't use BACO in runtime suspend. We could end up executing the BACO path if the platform supports both.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -0
index 91a5ed96bfbe..d96aaa2aa5ba 100644
@@ -1566,6 +1566,8 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev)
 		pci_ignore_hotplug(pdev);
 		pci_set_power_state(pdev, PCI_D3cold);
 		drm_dev->switch_power_state = DRM_SWITCH_POWER_DYNAMIC_OFF;
+	} else if (amdgpu_device_supports_boco(drm_dev)) {
+		/* nothing to do */
 	} else if (amdgpu_device_supports_baco(drm_dev)) {
 		amdgpu_device_baco_enter(drm_dev);
 	}
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only]

Quoted 44 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Tuesday, August 3, 2021 12:46 AM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu: don't enable baco on boco platforms in runpm

If the platform uses BOCO, don't use BACO in runtime suspend. We could end up executing the BACO path if the platform supports both.

Bug:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitla
b.freedesktop.org%2Fdrm%2Famd%2F- %2Fissues%2F1669&amp;data=04%7C01%7Cevan.quan%40amd.com%7Cd65 c86a3b85b452e049708d955d4fe72%7C3dd8961fe4884e608e11a82d994e183d %7C0%7C0%7C637635195555369506%7CUnknown%7CTWFpbGZsb3d8eyJWIj oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 000&amp;sdata=7eXhQgYtlr6ek%2BNtuLQyrCKvyGCePctiD0cKlFjsIhw%3D&a mp;reserved=0

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +2 -0
index 91a5ed96bfbe..d96aaa2aa5ba 100644
@@ -1566,6 +1566,8 @@ static int amdgpu_pmops_runtime_suspend(struct
 device *dev)
 		pci_ignore_hotplug(pdev);
 		pci_set_power_state(pdev, PCI_D3cold);
 		drm_dev->switch_power_state =
 DRM_SWITCH_POWER_DYNAMIC_OFF;
+	} else if (amdgpu_device_supports_boco(drm_dev)) {
+		/* nothing to do */
 	} else if (amdgpu_device_supports_baco(drm_dev)) {
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +0 -1
 		amdgpu_device_baco_enter(drm_dev);
 	}
--

2.31.1