Skip to contentSkip to conversation

binder: Add invalid handle info in user error log

PATCH New Ramji Jiyani 1 participant 1 message Aug 2, 2021 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 binder: Add invalid handle info in user error log

In the case of a failed transaction, only the thread and process id are logged. Add the handle info for the reference to the target node in user error log to aid debugging.

---
v1 -> v2: Rephrased the commit message as per review comment

---
 drivers/android/binder.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/android/binder.c +2 -2
index bcec598b89f2..d9030cb6b1e4 100644
@@ -2547,8 +2547,8 @@ static void binder_transaction(struct binder_proc *proc,
 						ref->node, &target_proc,
 						&return_error);
 			} else {
-				binder_user_error("%d:%d got transaction to invalid handle\n",
-						  proc->pid, thread->pid);
+				binder_user_error("%d:%d got transaction to invalid handle, %u\n",
+						  proc->pid, thread->pid, tr->target.handle);
 				return_error = BR_FAILED_REPLY;
 			}
 			binder_proc_unlock(proc);
Signature · 1 line
2.32.0.554.ge1b32706d8-goog