Skip to contentSkip to conversation

usb: misc: adutux: use swap()

PATCH New Salah Triki 1 participant 1 message Aug 3, 2021 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: misc: adutux: use swap()

Use swap() in order to make code cleaner. Issue found by coccinelle.

---
 drivers/usb/misc/adutux.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/usb/misc/adutux.c +1 -4
index 6d15a097b007..ed6a19254d2f 100644
@@ -394,13 +394,10 @@ static ssize_t adu_read(struct file *file, __user char *buffer, size_t count,
 			spin_lock_irqsave (&dev->buflock, flags);
 			if (dev->read_buffer_length) {
 				/* we secure access to the primary */
-				char *tmp;
 				dev_dbg(&dev->udev->dev,
 					"%s : swap, read_buffer_length = %d\n",
 					__func__, dev->read_buffer_length);
-				tmp = dev->read_buffer_secondary;
-				dev->read_buffer_secondary = dev->read_buffer_primary;
-				dev->read_buffer_primary = tmp;
+				swap(dev->read_buffer_primary, dev->read_buffer_secondary);
 				dev->secondary_head = 0;
 				dev->secondary_tail = dev->read_buffer_length;
 				dev->read_buffer_length = 0;
Signature · 1 line
2.25.1