Enable GuC submission by default on DG1
Subsystems (2)
cover Enable GuC submission by default on DG1
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Tested with the loading the driver and 'live' selftests. Submissions seem to work.
Daniele Ceraolo Spurio (1):
drm/i915/guc: put all guc objects in lmem when available
Matthew Brost (2):
drm/i915/guc: Add DG1 GuC / HuC firmware defs drm/i915/guc: Enable GuC submission by default on DG1
Venkata Sandeep Dhanalakota (1):
drm/i915: Do not define vma on stack
drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 26 +++++++ drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 4 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 9 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 11 ++- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 14 +++- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 90 ++++++++++++++++++++--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 2 + 8 files changed, 138 insertions(+), 20 deletions(-)
Signature · 1 line
2.28.0
PATCH 1/4 drm/i915: Do not define vma on stack
From: Venkata Sandeep Dhanalakota <[email protected]>
Defining vma on stack can cause stack overflow, if vma gets populated with new fields.
--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 18 +++++++++--------- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 2 ++ 2 files changed, 11 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +9 -9
@@ -413,20 +413,20 @@ static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw) {struct drm_i915_gem_object *obj = uc_fw->obj;struct i915_ggtt *ggtt =__uc_fw_to_gt (uc_fw)->ggtt; -struct i915_vma dummy = { - .node.start =uc_fw_ggtt_offset (uc_fw), - .node.size = obj->base.size, - .pages = obj->mm.pages, - .vm = &ggtt->vm, - }; +struct i915_vma *dummy = &uc_fw->dummy; + + dummy->node.start =uc_fw_ggtt_offset (uc_fw); + dummy->node.size = obj->base.size; + dummy->pages = obj->mm.pages; + dummy->vm = &ggtt->vm;GEM_BUG_ON (!i915_gem_object_has_pinned_pages (obj)); -GEM_BUG_ON (dummy.node.size > ggtt->uc_fw.size); +GEM_BUG_ON (dummy->node.size > ggtt->uc_fw.size);/* uc_fw->obj cache domains were not controlled across suspend */ -drm_clflush_sg (dummy.pages); +drm_clflush_sg (dummy->pages); - ggtt->vm.insert_entries (&ggtt->vm, &dummy,I915_CACHE_NONE ,0 ); + ggtt->vm.insert_entries (&ggtt->vm, dummy,I915_CACHE_NONE ,0 ); }static void uc_fw_unbind_ggtt (struct intel_uc_fw *uc_fw)
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h +2 -0
@@ -10,6 +10,7 @@#include "intel_uc_fw_abi.h" #include "intel_device_info.h" #include "i915_gem.h" +#include "i915_vma.h" struct drm_printer ;struct drm_i915_private ;
@@ -75,6 +76,7 @@ struct intel_uc_fw {bool user_overridden;size_t size;struct drm_i915_gem_object *obj; +struct i915_vma dummy;/* * The firmware build process will generate a version header file with major and
Signature · 1 line
2.28.0
Re: [Intel-gfx] [PATCH 1/4] drm/i915: Do not define vma on stack
Quoted 9 lines · Matthew Brost
From: Venkata Sandeep Dhanalakota <[email protected]>
Defining vma on stack can cause stack overflow, if vma gets populated with new fields.
Cc Daniele Ceraolo Spurio <[email protected]>Cc Tvrtko Ursulin <[email protected]>Signed-off-by Venkata Sandeep Dhanalakota <[email protected]>Signef-off-by Matthew Brost <[email protected]>
Quoted 62 lines
--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 18 +++++++++--------- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 2 ++ 2 files changed, 11 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +9
-9@@ -413,20 +413,20 @@ static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw) {struct drm_i915_gem_object *obj = uc_fw->obj;struct i915_ggtt *ggtt =__uc_fw_to_gt (uc_fw)->ggtt; -struct i915_vma dummy = { - .node.start =uc_fw_ggtt_offset (uc_fw), - .node.size = obj->base.size, - .pages = obj->mm.pages, - .vm = &ggtt->vm, - }; +struct i915_vma *dummy = &uc_fw->dummy; + + dummy->node.start =uc_fw_ggtt_offset (uc_fw); + dummy->node.size = obj->base.size; + dummy->pages = obj->mm.pages; + dummy->vm = &ggtt->vm;GEM_BUG_ON (!i915_gem_object_has_pinned_pages (obj)); -GEM_BUG_ON (dummy.node.size > ggtt->uc_fw.size); +GEM_BUG_ON (dummy->node.size > ggtt->uc_fw.size);/* uc_fw->obj cache domains were not controlled across suspend */ -drm_clflush_sg (dummy.pages); +drm_clflush_sg (dummy->pages); - ggtt->vm.insert_entries (&ggtt->vm, &dummy,I915_CACHE_NONE ,0 ); + ggtt->vm.insert_entries (&ggtt->vm, dummy,I915_CACHE_NONE ,0 ); }static void uc_fw_unbind_ggtt (struct intel_uc_fw *uc_fw)drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h +2
-0@@ -10,6 +10,7 @@#include "intel_uc_fw_abi.h" #include "intel_device_info.h" #include "i915_gem.h" +#include "i915_vma.h" struct drm_printer ;struct drm_i915_private ;@@ -75,6 +76,7 @@ struct intel_uc_fw {bool user_overridden;size_t size;struct drm_i915_gem_object *obj; +struct i915_vma dummy;/* * The firmware build process will generate a version header file with major and Signature · 1 line
2.28.0
PATCH 2/4 drm/i915/guc: put all guc objects in lmem when available
In reply to Matthew BrostFrom: Daniele Ceraolo Spurio <[email protected]>
The firmware binary has to be loaded from lmem and the recommendation is to put all other objects in there as well. Note that we don't fall back to system memory if the allocation in lmem fails because all objects are allocated during driver load and if we have issues with lmem at that point something is seriously wrong with the system, so no point in trying to handle it.
--- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 26 ++++++++ drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 4 ++ drivers/gpu/drm/i915/gt/uc/intel_guc.c | 9 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 11 +++- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 14 ++++- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 75 +++++++++++++++++++++-- 6 files changed, 127 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_lmem.c +26 -0
@@ -103,6 +103,32 @@ __i915_gem_object_create_lmem_with_ps(struct drm_i915_private *i915, size, page_size, flags); } +struct drm_i915_gem_object * +i915_gem_object_create_lmem_from_data (struct drm_i915_private *i915, +const void *data,size_t size) +{ +struct drm_i915_gem_object *obj; +void *map; + + obj =i915_gem_object_create_lmem (i915, +round_up (size,PAGE_SIZE ), +I915_BO_ALLOC_CONTIGUOUS ); +if (IS_ERR (obj)) +return obj; + + map =i915_gem_object_pin_map_unlocked (obj,I915_MAP_WC ); +if (IS_ERR (map)) { +i915_gem_object_put (obj); +return map; + } + +memcpy (map, data, size); + +i915_gem_object_unpin_map (obj); + +return obj; +} +struct drm_i915_gem_object * i915_gem_object_create_lmem(struct drm_i915_private *i915, resource_size_t size,
drivers/gpu/drm/i915/gem/i915_gem_lmem.h +4 -0
@@ -23,6 +23,10 @@ bool i915_gem_object_is_lmem(struct drm_i915_gem_object *obj);bool __i915_gem_object_is_lmem (struct drm_i915_gem_object *obj); +struct drm_i915_gem_object * +i915_gem_object_create_lmem_from_data (struct drm_i915_private *i915, +const void *data,size_t size); +struct drm_i915_gem_object * __i915_gem_object_create_lmem_with_ps(struct drm_i915_private *i915, resource_size_t size,
drivers/gpu/drm/i915/gt/uc/intel_guc.c +8 -1
@@ -3,6 +3,7 @@* Copyright © 2014-2019 Intel Corporation */ +#include "gem/i915_gem_lmem.h" #include "gt/intel_gt.h" #include "gt/intel_gt_irq.h" #include "gt/intel_gt_pm_irq.h"
@@ -630,7 +631,13 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size)u64 flags;int ret; - obj =i915_gem_object_create_shmem (gt->i915, size); +if (HAS_LMEM (gt->i915)) + obj =i915_gem_object_create_lmem (gt->i915, size, +I915_BO_ALLOC_CPU_CLEAR | +I915_BO_ALLOC_CONTIGUOUS ); +else + obj =i915_gem_object_create_shmem (gt->i915, size); +if (IS_ERR (obj))return ERR_CAST (obj);
drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c +8 -3
@@ -41,7 +41,7 @@ static void guc_prepare_xfer(struct intel_uncore *uncore) }/* Copy RSA signature from the fw image to HW for verification */ -static void guc_xfer_rsa (struct intel_uc_fw *guc_fw, +static int guc_xfer_rsa (struct intel_uc_fw *guc_fw,struct intel_uncore *uncore) {u32 rsa[UOS_RSA_SCRATCH_COUNT ];
@@ -49,10 +49,13 @@ static void guc_xfer_rsa(struct intel_uc_fw *guc_fw,int i; copied =intel_uc_fw_copy_rsa (guc_fw, rsa,sizeof (rsa)); -GEM_BUG_ON (copied <sizeof (rsa)); +if (copied <sizeof (rsa)) +return -ENOMEM ;for (i =0 ; i <UOS_RSA_SCRATCH_COUNT ; i++)intel_uncore_write (uncore,UOS_RSA_SCRATCH (i), rsa[i]); + +return 0 ; }/*
@@ -141,7 +144,9 @@ int intel_guc_fw_upload(struct intel_guc *guc)* by the DMA engine in one operation, whereas the RSA signature is * loaded via MMIO. */ -guc_xfer_rsa (&guc->fw, uncore); + ret =guc_xfer_rsa (&guc->fw, uncore); +if (ret) + goto out;/* * Current uCode expects the code to be loaded at 8k; locations below
drivers/gpu/drm/i915/gt/uc/intel_huc.c +11 -3
@@ -87,17 +87,25 @@ static int intel_huc_rsa_data_create(struct intel_huc *huc) vma->obj, true));if (IS_ERR (vaddr)) {i915_vma_unpin_and_release (&vma,0 ); -return PTR_ERR (vaddr); + err =PTR_ERR (vaddr); + goto unpin_out; } copied =intel_uc_fw_copy_rsa (&huc->fw, vaddr, vma->size); -GEM_BUG_ON (copied < huc->fw.rsa_size); -i915_gem_object_unpin_map (vma->obj); +if (copied < huc->fw.rsa_size) { + err = -ENOMEM ; + goto unpin_out; + } + huc->rsa_data = vma;return 0 ; + +unpin_out: +i915_vma_unpin_and_release (&vma,0 ); +return err; }static void intel_huc_rsa_data_destroy (struct intel_huc *huc)
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +70 -5
111 lines not on this page · raw message
Signature · 1 line
2.28.0
Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: put all guc objects in lmem when available
Quoted 237 lines · Matthew Brost
From: Daniele Ceraolo Spurio <[email protected]>
The firmware binary has to be loaded from lmem and the recommendation is to put all other objects in there as well. Note that we don't fall back to system memory if the allocation in lmem fails because all objects are allocated during driver load and if we have issues with lmem at that point something is seriously wrong with the system, so no point in trying to handle it.
Cc Matthew Auld <[email protected]>Cc Abdiel Janulgue <[email protected]>Cc Michal Wajdeczko <[email protected]>Cc Vinay Belgaumkar <[email protected]>Cc Radoslaw Szwichtenberg <[email protected]>Signed-off-by Daniele Ceraolo Spurio <[email protected]>Signed-off-by Matthew Brost <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 26 ++++++++ drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 4 ++ drivers/gpu/drm/i915/gt/uc/intel_guc.c | 9 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 11 +++- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 14 ++++- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 75 +++++++++++++++++++++-- 6 files changed, 127 insertions(+), 12 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_lmem.c +26
-0@@ -103,6 +103,32 @@ __i915_gem_object_create_lmem_with_ps(struct drm_i915_private *i915, size, page_size, flags); } +struct drm_i915_gem_object * +i915_gem_object_create_lmem_from_data (struct drm_i915_private *i915, +const void *data,size_t size) +{ +struct drm_i915_gem_object *obj; +void *map; + + obj =i915_gem_object_create_lmem (i915, +round_up (size,PAGE_SIZE ), +I915_BO_ALLOC_CONTIGUOUS ); +if (IS_ERR (obj)) +return obj; + + map =i915_gem_object_pin_map_unlocked (obj,I915_MAP_WC ); +if (IS_ERR (map)) { +i915_gem_object_put (obj); +return map; + } + +memcpy (map, data, size); + +i915_gem_object_unpin_map (obj); + +return obj; +} +struct drm_i915_gem_object * i915_gem_object_create_lmem(struct drm_i915_private *i915, resource_size_t size,drivers/gpu/drm/i915/gem/i915_gem_lmem.h +4
-0@@ -23,6 +23,10 @@ bool i915_gem_object_is_lmem(struct drm_i915_gem_object *obj);bool __i915_gem_object_is_lmem (struct drm_i915_gem_object *obj); +struct drm_i915_gem_object * +i915_gem_object_create_lmem_from_data (struct drm_i915_private *i915, +const void *data,size_t size); +struct drm_i915_gem_object * __i915_gem_object_create_lmem_with_ps(struct drm_i915_private *i915, resource_size_t size,drivers/gpu/drm/i915/gt/uc/intel_guc.c +8
-1@@ -3,6 +3,7 @@* Copyright © 2014-2019 Intel Corporation */ +#include "gem/i915_gem_lmem.h" #include "gt/intel_gt.h" #include "gt/intel_gt_irq.h" #include "gt/intel_gt_pm_irq.h" @@ -630,7 +631,13 @@ struct i915_vma *intel_guc_allocate_vma(struct intel_guc *guc, u32 size)u64 flags;int ret; - obj =i915_gem_object_create_shmem (gt->i915, size); +if (HAS_LMEM (gt->i915)) + obj =i915_gem_object_create_lmem (gt->i915, size, +I915_BO_ALLOC_CPU_CLEAR | +I915_BO_ALLOC_CONTIGUOUS ); +else + obj =i915_gem_object_create_shmem (gt->i915, size); +if (IS_ERR (obj))return ERR_CAST (obj);drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c +8
-3@@ -41,7 +41,7 @@ static void guc_prepare_xfer(struct intel_uncore *uncore) }/* Copy RSA signature from the fw image to HW for verification */ -static void guc_xfer_rsa (struct intel_uc_fw *guc_fw, +static int guc_xfer_rsa (struct intel_uc_fw *guc_fw,struct intel_uncore *uncore) {u32 rsa[UOS_RSA_SCRATCH_COUNT ];@@ -49,10 +49,13 @@ static void guc_xfer_rsa(struct intel_uc_fw *guc_fw,int i; copied =intel_uc_fw_copy_rsa (guc_fw, rsa,sizeof (rsa)); -GEM_BUG_ON (copied <sizeof (rsa)); +if (copied <sizeof (rsa)) +return -ENOMEM ;for (i =0 ; i <UOS_RSA_SCRATCH_COUNT ; i++)intel_uncore_write (uncore,UOS_RSA_SCRATCH (i), rsa[i]); + +return 0 ; }/* @@ -141,7 +144,9 @@ int intel_guc_fw_upload(struct intel_guc *guc)* by the DMA engine in one operation, whereas the RSA signature is * loaded via MMIO. */ -guc_xfer_rsa (&guc->fw, uncore); + ret =guc_xfer_rsa (&guc->fw, uncore); +if (ret) + goto out;/* * Current uCode expects the code to be loaded at 8k; locations below drivers/gpu/drm/i915/gt/uc/intel_huc.c +11
-3@@ -87,17 +87,25 @@ static int intel_huc_rsa_data_create(struct intel_huc *huc) vma->obj, true));if (IS_ERR (vaddr)) {i915_vma_unpin_and_release (&vma,0 ); -return PTR_ERR (vaddr); + err =PTR_ERR (vaddr); + goto unpin_out; } copied =intel_uc_fw_copy_rsa (&huc->fw, vaddr, vma->size); -GEM_BUG_ON (copied < huc->fw.rsa_size); -i915_gem_object_unpin_map (vma->obj); +if (copied < huc->fw.rsa_size) { + err = -ENOMEM ; + goto unpin_out; + } + huc->rsa_data = vma;return 0 ; + +unpin_out: +i915_vma_unpin_and_release (&vma,0 ); +return err; }static void intel_huc_rsa_data_destroy (struct intel_huc *huc)drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +17
-4@@ -7,6 +7,7 @@#include <linux/firmware.h> #include <drm/drm_print.h> +#include "gem/i915_gem_lmem.h" #include "intel_uc_fw.h" #include "intel_uc_fw_abi.h" #include "i915_drv.h" @@ -370,7 +371,11 @@ int intel_uc_fw_fetch(struct intel_uc_fw *uc_fw)if (uc_fw->type ==INTEL_UC_FW_TYPE_GUC ) uc_fw->private_data_size = css->private_data_size; - obj =i915_gem_object_create_shmem_from_data (i915, fw->data, fw->size); +if (HAS_LMEM (i915)) + obj =i915_gem_object_create_lmem_from_data (i915, fw->data, fw->size); +else + obj =i915_gem_object_create_shmem_from_data (i915, fw->data, fw->size); +if (IS_ERR (obj)) { err =PTR_ERR (obj); goto fail;@@ -414,6 +419,7 @@ static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw)struct drm_i915_gem_object *obj = uc_fw->obj;struct i915_ggtt *ggtt =__uc_fw_to_gt (uc_fw)->ggtt;struct i915_vma *dummy = &uc_fw->dummy; +u32 pte_flags =0 ; dummy->node.start =uc_fw_ggtt_offset (uc_fw); dummy->node.size = obj->base.size;@@ -424,9 +430,13 @@ static void uc_fw_bind_ggtt(struct intel_uc_fw *uc_fw)GEM_BUG_ON (dummy->node.size > ggtt->uc_fw.size);/* uc_fw->obj cache domains were not controlled across suspend */ -drm_clflush_sg (dummy->pages); +if (i915_gem_object_has_struct_page (obj)) +drm_clflush_sg (dummy->pages); + +if (i915_gem_object_is_lmem (obj)) + pte_flags |=PTE_LM ; - ggtt->vm.insert_entries (&ggtt->vm, dummy,I915_CACHE_NONE ,0 ); + ggtt->vm.insert_entries (&ggtt->vm, dummy,I915_CACHE_NONE , pte_flags); }static void uc_fw_unbind_ggtt (struct intel_uc_fw *uc_fw)@@ -585,13 +595,68 @@ void intel_uc_fw_cleanup_fetch(struct intel_uc_fw *uc_fw)*/ size_t intel_uc_fw_copy_rsa (struct intel_uc_fw *uc_fw,void *dst,u32 max_len) { -struct sg_table *pages = uc_fw->obj->mm.pages; +struct intel_memory_region *mr = uc_fw->obj->mm.region;u32 size =min_t (u32, uc_fw->rsa_size, max_len);u32 offset =sizeof (struct uc_css_header ) + uc_fw->ucode_size; +struct sgt_iter iter; +size_t count =0 ; +int idx;
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c void intel_uc_fw_cleanup_fetch(struct intel_uc_fw *uc_fw) · line 613
Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +7
-1+/* Called during reset handling, must be atomic [no fs_reclaim] */ GEM_BUG_ON (!intel_uc_fw_is_available (uc_fw)); -return sg_pcopy_to_buffer (pages->sgl, pages->nents, dst, size, offset); + idx = offset >>PAGE_SHIFT ; + offset =offset_in_page (offset); +if (i915_gem_object_has_struct_page (uc_fw->obj)) { +struct page *page; + +for_each_sgt_page (page, iter, uc_fw->obj->mm.pages) {
Why can't this just use 'sg_pcopy_to_buffer' as before?
John.
Quoted 49 lines
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +46
-0+u32 len =min_t (u32, size,PAGE_SIZE - offset); +void *vaddr; + +if (idx >0 ) { + idx--; +continue ; + } + + vaddr =kmap_atomic (page); +memcpy (dst, vaddr + offset, len); +kunmap_atomic (vaddr); + + offset =0 ; + dst += len; + size -= len; + count += len; +if (!size) +break ; + } + }else { +dma_addr_t addr; + +for_each_sgt_daddr (addr, iter, uc_fw->obj->mm.pages) { +u32 len =min_t (u32, size,PAGE_SIZE - offset); +void __iomem *vaddr; + +if (idx >0 ) { + idx--; +continue ; + } + + vaddr =io_mapping_map_atomic_wc (&mr->iomap, + addr - mr->region.start); +memcpy_fromio (dst, vaddr + offset, len); +io_mapping_unmap_atomic (vaddr); + + offset =0 ; + dst += len; + size -= len; + count += len; +if (!size) +break ; + } + } + +return count; }/**
PATCH 3/4 drm/i915/guc: Add DG1 GuC / HuC firmware defs
In reply to Matthew Brost--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +1 -0
@@ -51,6 +51,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,#define INTEL_UC_FIRMWARE_DEFS (fw_def, guc_def, huc_def) \ fw_def(ALDERLAKE_P, 0, guc_def(adlp, 62, 0, 3), huc_def(tgl, 7, 9, 3)) \ fw_def(ALDERLAKE_S, 0, guc_def(tgl, 62, 0, 0), huc_def(tgl, 7, 9, 3)) \ + fw_def(DG1, 0, guc_def(dg1, 62, 0, 0), huc_def(dg1, 7, 9, 3)) \ fw_def(ROCKETLAKE, 0, guc_def(tgl, 62, 0, 0), huc_def(tgl, 7, 9, 3)) \ fw_def(TIGERLAKE, 0, guc_def(tgl, 62, 0, 0), huc_def(tgl, 7, 9, 3)) \ fw_def(JASPERLAKE, 0, guc_def(ehl, 62, 0, 0), huc_def(ehl, 9, 0, 0)) \
Signature · 1 line
2.28.0
Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Add DG1 GuC / HuC firmware defs
Quoted 10 lines · Matthew Brost
Signed-off-by Matthew Brost <[email protected]>--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +0
-0
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw, · line 57
Quoted 7 lines
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c +1
-0@@ -51,6 +51,7 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw,#define INTEL_UC_FIRMWARE_DEFS (fw_def, guc_def, huc_def) \ fw_def(ALDERLAKE_P, 0, guc_def(adlp, 62, 0, 3), huc_def(tgl, 7, 9, 3)) \ fw_def(ALDERLAKE_S, 0, guc_def(tgl, 62, 0, 0), huc_def(tgl, 7, 9, 3)) \ + fw_def(DG1, 0, guc_def(dg1, 62, 0, 0), huc_def(dg1, 7, 9, 3)) \ fw_def(ROCKETLAKE, 0, guc_def(tgl, 62, 0, 0), huc_def(tgl, 7, 9, 3)) \ fw_def(TIGERLAKE, 0, guc_def(tgl, 62, 0, 0), huc_def(tgl, 7, 9, 3)) \ fw_def(JASPERLAKE, 0, guc_def(ehl, 62, 0, 0), huc_def(ehl, 9, 0, 0)) \
PATCH 4/4 drm/i915/guc: Enable GuC submission by default on DG1
In reply to Matthew Brost--- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_uc.c +1 -1
@@ -35,7 +35,7 @@ static void uc_expand_default_options(struct intel_uc *uc) }/* Intermediate platforms are HuC authentication only */ -if (IS_DG1 (i915) ||IS_ALDERLAKE_S (i915)) { +if (IS_ALDERLAKE_S (i915)) { i915->params.enable_guc =ENABLE_GUC_LOAD_HUC ;return ; }
Signature · 1 line
2.28.0
Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Enable GuC submission by default on DG1
Quoted 10 lines · Matthew Brost
Signed-off-by Matthew Brost <[email protected]>--- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/uc/intel_uc.c +0
-0
drivers/gpu/drm/i915/gt/uc/intel_uc.c static void uc_expand_default_options(struct intel_uc *uc) · line 41
Quoted 8 lines
drivers/gpu/drm/i915/gt/uc/intel_uc.c +1
-1@@ -35,7 +35,7 @@ static void uc_expand_default_options(struct intel_uc *uc) }/* Intermediate platforms are HuC authentication only */ -if (IS_DG1 (i915) ||IS_ALDERLAKE_S (i915)) { +if (IS_ALDERLAKE_S (i915)) { i915->params.enable_guc =ENABLE_GUC_LOAD_HUC ;return ; }
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable GuC submission by default on DG1
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 9d575da473a3 drm/i915: Do not define vma on stack -:12: WARNING:BAD_SIGN_OFF: Non-standard signature: 'Signef-off-by:' - perhaps 'Signed-off-by:'? #12: Signef-off-by: Matthew Brost <[email protected]>
total: 0 errors, 1 warnings, 0 checks, 43 lines checked d90a57170211 drm/i915/guc: put all guc objects in lmem when available -:110: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #110: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c:45:
+static int guc_xfer_rsa(struct intel_uc_fw *guc_fw,
struct intel_uncore *uncore)
total: 0 errors, 0 warnings, 1 checks, 234 lines checked dab0f2596b90 drm/i915/guc: Add DG1 GuC / HuC firmware defs
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 7 lines checkeda06cd563cc84 drm/i915/guc: Enable GuC submission by default on DG1 -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable GuC submission by default on DG1
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1901:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1901:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1901:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_context.c:1410:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1410:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1410:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: expected struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: got struct i915_address_space * +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1392:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1268:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1442:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1496:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'xehp_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'xehp_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'xehp_fwtable_write8' - different lock contexts for basic block +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Enable GuC submission by default on DG1
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10440 -> Patchwork_20763
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/index.html
Known issues
------------
Here are the changes found in Patchwork_20763 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2] ([i915#155])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/fi-kbl-soraka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/fi-kbl-soraka/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
Participating hosts (37 -> 33)
------------------------------
Missing (4): fi-bdw-samus fi-bsw-cyan bat-jsl-1 fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10440 -> Patchwork_20763
CI-20190529: 20190529
CI_DRM_10440: 95b785be5ff0413ff419b30da574a7e3d353b33b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6159: 6135b9cc319ed965e3aafb5b2ae2abf4762a06b2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20763: a06cd563cc84d8dc74dd7ca041e09f3d410e229e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a06cd563cc84 drm/i915/guc: Enable GuC submission by default on DG1 dab0f2596b90 drm/i915/guc: Add DG1 GuC / HuC firmware defs d90a57170211 drm/i915/guc: put all guc objects in lmem when available 9d575da473a3 drm/i915: Do not define vma on stack
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/index.html
Quoted 7 lines · Matthew Brost
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Matt Auld has an igt series which fixes a lot of this stuff, would be good to do at least a Test-With run with that.
Also I'm assuming that for ADL-P we'll get this equivalent patch set soon, and there we should be able to get real results? -Daniel
Quoted 29 lines
Tested with the loading the driver and 'live' selftests. Submissions seem to work.
Signed-off-by Matthew Brost <[email protected]>Daniele Ceraolo Spurio (1):
drm/i915/guc: put all guc objects in lmem when availableMatthew Brost (2):
drm/i915/guc: Add DG1 GuC / HuC firmware defs drm/i915/guc: Enable GuC submission by default on DG1Venkata Sandeep Dhanalakota (1):
drm/i915: Do not define vma on stackdrivers/gpu/drm/i915/gem/i915_gem_lmem.c | 26 +++++++ drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 4 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 9 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 11 ++- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 14 +++- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 90 ++++++++++++++++++++--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 2 + 8 files changed, 138 insertions(+), 20 deletions(-)--
2.28.0
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Quoted 5 lines · Daniel Vetter
Quoted 4 lines · Matthew Brost
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
Quoted 7 lines
Quoted 3 lines
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Matt Auld has an igt series which fixes a lot of this stuff, would be good to do at least a Test-With run with that.
If I'm understanding his series correct it only fixes the mmap issues not relocs so I don't think it will help all that much. I probably could send a trybot series letting relocs work on DG1 + his series and that might work? I guess I'll find out.
Quoted 1 line
Also I'm assuming that for ADL-P we'll get this equivalent patch set
GuC submission is enabled by default on ADL-P. We don't have ADL-P in pre-merge CI currently though :(, just offline runs of about 1800 tests. Still a awaiting results for that though.
For what it is worth I've run all 1800 locally, via a script, and gotten solid results back with my IGT updates. There are some failures but I believe I understand all of them as either test issues or known differences in behavior between execlists and GuC submission with are opens (e.g. persistence, semaphores, SUBMIT fence, etc...).
Matt
Quoted 38 lines
soon, and there we should be able to get real results? -Daniel
Quoted 29 lines
Tested with the loading the driver and 'live' selftests. Submissions seem to work.
Signed-off-by Matthew Brost <[email protected]>Daniele Ceraolo Spurio (1):
drm/i915/guc: put all guc objects in lmem when availableMatthew Brost (2):
drm/i915/guc: Add DG1 GuC / HuC firmware defs drm/i915/guc: Enable GuC submission by default on DG1Venkata Sandeep Dhanalakota (1):
drm/i915: Do not define vma on stackdrivers/gpu/drm/i915/gem/i915_gem_lmem.c | 26 +++++++ drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 4 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 9 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 11 ++- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 14 +++- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2 +- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 90 ++++++++++++++++++++--- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 2 + 8 files changed, 138 insertions(+), 20 deletions(-)--
2.28.0Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Hi,
Quoted 11 lines · Matthew Brost
Quoted 10 lines · Daniel Vetter
Quoted 6 lines · Matthew Brost
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Matt Auld has an igt series which fixes a lot of this stuff, would be good to do at least a Test-With run with that.
It looks like Maarten now merged Matt's series to IGT.
There is a series on IGT trybot with pending work to have some igt tests support relocations,
https://patchwork.freedesktop.org/series/92043/
One of the tests that have WIP fixes is gem_exec_whisper, and that particular test has historically shown occasional hangs with GuC submission on DG1 so it would be very desirable if we could make that test in particular work (I haven't verified that that's the case) reliably.
Also the following series:
https://patchwork.freedesktop.org/series/93455/
tries a bit harder to get some more tests running, squashing the above series on top of latest IGT.
Thanks,
/Thomas
Quoted 22 lines · Thomas Hellström (Intel)
Hi,
Quoted 11 lines · Matthew Brost
Quoted 10 lines · Daniel Vetter
Quoted 6 lines · Matthew Brost
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Matt Auld has an igt series which fixes a lot of this stuff, would be good to do at least a Test-With run with that.
It looks like Maarten now merged Matt's series to IGT.
There is a series on IGT trybot with pending work to have some igt tests support relocations,
https://patchwork.freedesktop.org/series/92043/
One of the tests that have WIP fixes is
gem_exec_whisper, and that particular test has historically shown occasional hangs with GuC submission on DG1 so it would be very desirable if we could make that test in particular work (I haven't verified that that's the case) reliably.
Quoted 9 lines
Also the following series:
https://patchwork.freedesktop.org/series/93455/
tries a bit harder to get some more tests running, squashing the above series on top of latest IGT.
Thanks,
/Thomas
And also while we're working on getting igt adapted to uapi changes and to get more LMEM coverage in there, an IMO relevant test case to run manually is "piglit quick"on top of DG1-enabled OpenGL checking for regressions and significant changes in execution time.
/Thomas
Quoted 22 lines · Thomas Hellström (Intel)
Hi,
Quoted 11 lines · Matthew Brost
Quoted 10 lines · Daniel Vetter
Quoted 6 lines · Matthew Brost
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Matt Auld has an igt series which fixes a lot of this stuff, would be good to do at least a Test-With run with that.
It looks like Maarten now merged Matt's series to IGT.
There is a series on IGT trybot with pending work to have some igt tests support relocations,
https://patchwork.freedesktop.org/series/92043/
One of the tests that have WIP fixes is
gem_exec_whisper, and that particular test has historically shown occasional hangs with GuC submission on DG1 so it would be very desirable if we could make that test in particular work (I haven't verified that that's the case) reliably.
Quoted 10 lines
Also the following series:
https://patchwork.freedesktop.org/series/93455/
tries a bit harder to get some more tests running, squashing the above series on top of latest IGT.
Thanks,
/Thomas
Just verified that gem-exec-whisper is running now on DG1 on latest igt and the above series. Haven't tried with GuC submission, though.
/Thomas
Quoted 8 lines · Thomas Hellström (Intel)
Hi,
Quoted 5 lines · Matthew Brost
Quoted 4 lines · Daniel Vetter
Quoted 3 lines · Matthew Brost
Minimum set of patches to enable GuC submission on DG1 and enable it by default.
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
A little difficult to test as IGTs do not work with DG1 due to a bunch of uAPI features being disabled (e.g. relocations, caching memory options, etc...).
Matt Auld has an igt series which fixes a lot of this stuff, would be good to do at least a Test-With run with that.
It looks like Maarten now merged Matt's series to IGT.
Great.
Quoted 6 lines
There is a series on IGT trybot with pending work to have some igt tests support relocations,
Will take a look but at the moment we are blocked because SLPC won't init on the DG1 in CI but it works just fine on all other parts I've tried in RIL. We suspect the DG1 in CI is an early stepping and we may be missing workarounds. Have a possible fix, just need to try it out. We also might just want to replace the DG1 part in CI with a newer stepping so we don't have to upstream WAs for non-shipping parts.
Quoted 5 lines
One of the tests that have WIP fixes is
gem_exec_whisper, and that particular test has historically shown occasional hangs with GuC submission on DG1 so it would be very desirable if we could make that test in particular work (I haven't verified that that's the case) reliably.
I just ran gem_exec_whisper on DG1, with GuC submission, and kernel hacked to allow relocs. It passed for me. Only 1 run though so it is possible there are still intermittent issues. We really need to get CI up and running ASAP on all platforms where GuC submission is POR. Perhaps on all gen11+ platforms as well because GuC submission is supported and the more coverage we can get, the better.
Quoted 3 lines
Also the following series:
I'll check this series out too.
Matt
Quoted 8 lines
tries a bit harder to get some more tests running, squashing the above series on top of latest IGT.
Thanks,
/Thomas
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for Enable GuC submission by default on DG1
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Enable GuC submission by default on DG1
URL : https://patchwork.freedesktop.org/series/93325/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10440_full -> Patchwork_20763_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20763_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-snb5/igt@[email protected]
* igt@gem_eio@in-flight-contexts-1us:
- shard-tglb: [PASS][2] -> [TIMEOUT][3] ([i915#3063])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-tglb2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb1/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][4] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl3/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-tglb3/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb6/igt@gem_exec_fair@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#3323])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][10] ([i915#3002])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl6/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][11] ([i915#3318])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl7/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-kbl: NOTRUN -> [DMESG-WARN][12] ([i915#180])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl7/igt@[email protected]
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][13] ([fdo#109271]) +214 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-snb2/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1937])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl3/igt@i915_pm_lpsp@[email protected]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> [SKIP][15] ([fdo#109271]) +140 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl7/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#180])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-apl1/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl3/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][18] ([i915#3722])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl10/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#3777])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][20] ([i915#3763])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#3689]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb8/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +10 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl7/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-negative:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +16 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +5 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][25] ([fdo#109284] / [fdo#111827])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb8/igt@[email protected]
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +10 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-snb7/igt@[email protected]
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][27] ([i915#1319])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl2/igt@[email protected]
* igt@kms_content_protection@legacy:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#111828])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: NOTRUN -> [FAIL][31] ([i915#2346] / [i915#533])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: NOTRUN -> [FAIL][32] ([i915#79])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][33] -> [FAIL][34] ([i915#79])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-glk6/igt@kms_flip@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: NOTRUN -> [FAIL][35] ([i915#2122])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-skl: NOTRUN -> [INCOMPLETE][36] ([i915#3699])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#2587])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb8/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt:
- shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271]) +234 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111825]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271]) +64 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][41] ([fdo#108145] / [i915#265]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][42] ([fdo#108145] / [i915#265]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][43] ([fdo#108145] / [i915#265])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][44] ([i915#265])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][45] -> [FAIL][46] ([fdo#108145] / [i915#265])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl10/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl1/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#658]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl6/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#658]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl6/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][49] -> [SKIP][50] ([fdo#109441])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][51] ([i915#180] / [i915#295])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl1/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2437])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl10/igt@[email protected]
* igt@nouveau_crc@pipe-a-ctx-flip-skip-current-frame:
- shard-tglb: NOTRUN -> [SKIP][53] ([i915#2530])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb8/igt@[email protected]
* igt@perf_pmu@module-unload:
- shard-skl: [PASS][54] -> [DMESG-WARN][55] ([i915#1982] / [i915#262])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl6/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl9/igt@[email protected]
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2994])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl8/igt@[email protected]
* igt@sysfs_clients@split-10:
- shard-kbl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2994])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl2/igt@[email protected]
* igt@sysfs_clients@split-25:
- shard-skl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl10/igt@[email protected]
#### Possible fixes ####
* igt@fbdev@write:
- {shard-rkl}: [SKIP][59] ([i915#2582]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][61] ([i915#658]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb2/igt@[email protected]
* igt@gem_create@create-clear:
- shard-glk: [FAIL][63] ([i915#1888] / [i915#3160]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-glk5/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-glk7/igt@[email protected]
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][65] ([i915#2410]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-tglb3/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb6/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-apl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-apl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-apl2/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][69] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb5/igt@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][71] ([i915#2842]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-glk7/igt@gem_exec_fair@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [FAIL][73] ([i915#2842]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl1/igt@gem_exec_fair@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb7/igt@gem_exec_fair@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [FAIL][77] ([i915#2842]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-tglb7/igt@gem_exec_fair@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-sync@rcs0:
- shard-kbl: [SKIP][79] ([fdo#109271]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl6/igt@gem_exec_fair@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- {shard-rkl}: [FAIL][81] ([i915#2842]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-2/igt@gem_exec_fair@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-1/igt@gem_exec_fair@[email protected]
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][83] ([i915#307]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb8/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb3/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [DMESG-WARN][85] ([i915#180]) -> [PASS][86] +3 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl4/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl1/igt@[email protected]
* igt@i915_pm_backlight@bad-brightness:
- {shard-rkl}: [SKIP][87] ([i915#3012]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@i915_selftest@live@execlists:
- {shard-rkl}: [DMESG-FAIL][89] ([i915#1993]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@i915_selftest@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-5/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- {shard-rkl}: [SKIP][91] ([i915#3638]) -> [PASS][92] +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180:
- {shard-rkl}: [SKIP][93] ([i915#3721]) -> [PASS][94] +4 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@y-tiled-16bpp-rotate-90:
- {shard-rkl}: [SKIP][95] ([fdo#111614]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- {shard-rkl}: [FAIL][97] ([i915#3678]) -> [PASS][98] +4 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_color@pipe-c-ctm-max:
- {shard-rkl}: [SKIP][99] ([i915#1149] / [i915#1849]) -> [PASS][100] +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
- {shard-rkl}: [SKIP][101] ([fdo#112022]) -> [PASS][102] +9 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipa-atomic:
- {shard-rkl}: [SKIP][103] ([fdo#111825]) -> [PASS][104] +6 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][105] ([i915#2346]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl6/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl3/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- {shard-rkl}: [SKIP][107] ([fdo#111314]) -> [PASS][108] +2 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- {shard-rkl}: [SKIP][109] ([i915#1849]) -> [PASS][110] +33 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack-mmap-gtt:
- {shard-rkl}: [SKIP][111] ([i915#1849] / [i915#3180]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [FAIL][113] ([i915#1188]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl5/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][115] ([fdo#108145] / [i915#265]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl9/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl10/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-none:
- {shard-rkl}: [SKIP][117] ([i915#3558]) -> [PASS][118] +2 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][119] ([fdo#109441]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@sprite_render:
- {shard-rkl}: [SKIP][121] ([i915#1072]) -> [PASS][122] +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-5/igt@kms_psr@sprite_render.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@kms_psr@sprite_render.html
* igt@kms_vblank@pipe-b-query-forked-hang:
- {shard-rkl}: [SKIP][123] ([i915#1845]) -> [PASS][124] +18 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-rkl-1/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-rkl-6/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][125] ([i915#1542]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl9/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl10/igt@[email protected]
- shard-tglb: [FAIL][127] ([i915#1542]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-tglb1/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-tglb5/igt@[email protected]
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [FAIL][129] ([i915#1731]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-skl4/igt@sysfs_heartbeat_interval@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-skl3/igt@sysfs_heartbeat_interval@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][131] ([i915#1804] / [i915#2684]) -> [WARN][132] ([i915#2684])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb3/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb5/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][133] ([i915#658]) -> [SKIP][134] ([i915#2920]) +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][135] ([i915#2920]) -> [SKIP][136] ([i915#658]) +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-iclb2/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-iclb8/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl4/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl6/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl1/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl4/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl4/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl4/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl7/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl7/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10440/shard-kbl4/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl4/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl4/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl4/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl1/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/shard-kbl4/igt@[email protected]
[151]: htt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20763/index.html