ethdev: announce change to action modify data
PATCH 1/2 ethdev: announce change to action modify data
From: Ori Kam <[email protected]>
In the current implementation,
the action rte_flow_action_modify_field is not well defined for fields larger than 64 bits (for example IPv6 source) In addtion, the byte order is also not well defined.
Both of those issue should be fixed.
--- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +4 -0
@@ -158,3 +158,7 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. + +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified + to support modifying larger fields than 64 bits. + In addition, documentation will be updated to clarify byte order.
Signature · 1 line
2.25.1
PATCH 2/2 ethdev: announce moving to general modify function
From: Ori Kam <[email protected]>
Currently there is a dedicated modify function for each field that the application wants to change.
For example:rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
A new function rte_flow_action_modif_field DPDK added the ability to use the same function to modify any field, in addtion to be able to modify the value based on different field and not just immediate value.
--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -162,3 +162,6 @@ Deprecation Notices * ethdev: The struct ``rte_flow_action_modify_data`` will be modified to support modifying larger fields than 64 bits. In addition, documentation will be updated to clarify byte order. + +* ethdev: Announce moving from dedicated modify function for each field, + to using the general ``rte_flow_modify_field`` action.
Signature · 1 line
2.25.1
PATCH v2 1/2 ethdev: announce change to action modify data
In reply to Matan AzradIn the current implementation,
the action rte_flow_action_modify_field is not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined.
Both of those issue should be fixed.
---
V2:
Fix typo.
--- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+)
doc/guides/rel_notes/deprecation.rst +4 -0
@@ -158,3 +158,7 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. + +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified + to support modifying larger fields than 64 bits. + In addition, documentation will be updated to clarify byte order.
Signature · 1 line
2.25.1
PATCH v2 2/2 ethdev: announce moving to general modify function
Currently there is a dedicated modify function for each field that the application wants to change.
For example:rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP. rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
A new function rte_flow_action_modify_field DPDK added the ability to use the same function to modify any field, in addition to be able to modify the value based on different field and not just immediate value.
---
V2:
Fix typo.
--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -162,3 +162,6 @@ Deprecation Notices * ethdev: The struct ``rte_flow_action_modify_data`` will be modified to support modifying larger fields than 64 bits. In addition, documentation will be updated to clarify byte order. + +* ethdev: Announce moving from dedicated modify function for each field, + to using the general ``rte_flow_modify_field`` action.
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function
Quoted 7 lines · Ori Kam
Currently there is a dedicated modify function for each field that the application wants to change.
For example:rte_flow_action_type_set_tp_portto modify destination port of UDP/TCP.rte_flow_action_type_set_ipv4_dstto modify destination of IPv4.
Quoted 6 lines
A new function
rte_flow_action_modify_fieldDPDK added the ability to use the same function to modify any field, in addition to be able to modify the value based on different field and not just immediate value.Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>
Quoted 21 lines
---
V2:
Fix typo.--- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+)doc/guides/rel_notes/deprecation.rst +3
-1@@ -162,3 +162,6 @@ Deprecation Notices * ethdev: The struct ``rte_flow_action_modify_data`` will be modified to support modifying larger fields than 64 bits. In addition, documentation will be updated to clarify byte order. + +* ethdev: Announce moving from dedicated modify function for each field, + to using the general ``rte_flow_modify_field`` action. --2.25.1
Jerin Jacob
Acked-byRe: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function
Quoted 9 lines · Ajit Khaparde
Quoted 7 lines · Ori Kam
Currently there is a dedicated modify function for each field that the application wants to change.
For example:rte_flow_action_type_set_tp_portto modify destination port of UDP/TCP.rte_flow_action_type_set_ipv4_dstto modify destination of IPv4.
Quoted 7 lines
Quoted 6 lines
A new function
rte_flow_action_modify_fieldDPDK added the ability to use the same function to modify any field, in addition to be able to modify the value based on different field and not just immediate value.Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>Acked-by Ajit Khaparde <[email protected]>
Quoted 7 lines
Quoted 7 lines
---
V2:
Fix typo.--- doc/guides/rel_notes/deprecation.rst | 3 +++1 file chanAcked-by: Jerin Jacob <[email protected]>
ed, 3 insertions(+)
Quoted 15 lines
Quoted 15 lines
doc/guides/rel_notes/deprecation.rst +3
-1@@ -162,3 +162,6 @@ Deprecation Notices * ethdev: The struct ``rte_flow_action_modify_data`` will be modified to support modifying larger fields than 64 bits. In addition, documentation will be updated to clarify byte order. + +* ethdev: Announce moving from dedicated modify function for each field, + to using the general ``rte_flow_modify_field`` action. --2.25.1
Thomas Monjalon
AppliedRe: [dpdk-dev] [PATCH v2 2/2] ethdev: announce moving to general modify function
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Currently there is a dedicated modify function for each field that the application wants to change.
For example:rte_flow_action_type_set_tp_portto modify destination port of UDP/TCP.rte_flow_action_type_set_ipv4_dstto modify destination of IPv4.
Quoted 11 lines
Quoted 7 lines
Quoted 6 lines
A new function
rte_flow_action_modify_fieldDPDK added the ability to use the same function to modify any field, in addition to be able to modify the value based on different field and not just immediate value.Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>Acked-by Ajit Khaparde <[email protected]>Acked-by Jerin Jacob <[email protected]>Quoted 2 lines
Quoted 2 lines
doc/guides/rel_notes/deprecation.rst +2
-0+* ethdev: Announce moving from dedicated modify function for each field, + to using the general ``rte_flow_modify_field`` action.
This is a very vague announce.
OK we can replace a lot of actions with rte_flow_modify_field, but it doesn't say when and which functions will be removed.
I think we should make a more precise announce for removal of some actions in DPDK 22.11.
In the meantime, let's introduce this hint that something is changing as it is acked.
Applied.
Quoted 10 lines · Ori Kam
In the current implementation,
the actionrte_flow_action_modify_fieldis not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined.Both of those issue should be fixed.
Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>
Quoted 22 lines
---
V2:
Fix typo.--- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+)doc/guides/rel_notes/deprecation.rst +4
-1@@ -158,3 +158,7 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. + +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified + to support modifying larger fields than 64 bits. + In addition, documentation will be updated to clarify byte order. --2.25.1
Andrew Rybchenko
Acked-byQuoted 7 lines · Ajit Khaparde
Quoted 6 lines · Ori Kam
In the current implementation,
the actionrte_flow_action_modify_fieldis not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined.
Quoted 5 lines
Quoted 4 lines
Both of those issue should be fixed.
Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>Acked-by Ajit Khaparde <[email protected]>
Jerin Jacob
Acked-byQuoted 9 lines · Andrew Rybchenko
Quoted 7 lines · Ajit Khaparde
Quoted 6 lines · Ori Kam
In the current implementation,
the actionrte_flow_action_modify_fieldis not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined.
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
Both of those issue should be fixed.
Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>Acked-by Ajit Khaparde <[email protected]>Acked-by Andrew Rybchenko <[email protected]>
Quoted 1 line
Thomas Monjalon
AppliedQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
In the current implementation,
the actionrte_flow_action_modify_fieldis not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined.
Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
Both of those issue should be fixed.
Signed-off-by Ori Kam <[email protected]>Acked-by Matan Azrad <[email protected]>Acked-by Ajit Khaparde <[email protected]>Acked-by Andrew Rybchenko <[email protected]>Acked-by Jerin Jacob <[email protected]>
Applied, thanks.