drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()
Subsystems (3)
PATCH 1/1 drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate()
The varialbe gtt in the function amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. Thus the null-pointer checks are redundant and can be dropped.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -2
@@ -1121,7 +1121,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_device *bdev,struct amdgpu_ttm_tt *gtt = (void *)ttm;/* user pages are bound by amdgpu_ttm_tt_pin_userptr() */ -if (gtt && gtt->userptr) { +if (gtt->userptr) { ttm->sg =kzalloc (sizeof (struct sg_table ),GFP_KERNEL );if (!ttm->sg)return -ENOMEM ;
@@ -1146,7 +1146,7 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_device *bdev,struct amdgpu_ttm_tt *gtt = (void *)ttm;struct amdgpu_device *adev; -if (gtt && gtt->userptr) { +if (gtt->userptr) {amdgpu_ttm_tt_set_user_pages (ttm,NULL );kfree (ttm->sg); ttm->sg =NULL ;
Signature · 1 line
2.25.1
Am 04.08.21 um 03:51 schrieb Tuo Li:
Quoted 6 lines
The varialbe gtt in the function
amdgpu_ttm_tt_populate()andamdgpu_ttm_tt_unpopulate()is guaranteed to be not NULL in the context. Thus the null-pointer checks are redundant and can be dropped.Reported-by TOTE Robot <[email protected]>Signed-off-by Tuo Li <[email protected]>
Quoted 26 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2
-2@@ -1121,7 +1121,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_device *bdev,struct amdgpu_ttm_tt *gtt = (void *)ttm;/* user pages are bound by amdgpu_ttm_tt_pin_userptr() */ -if (gtt && gtt->userptr) { +if (gtt->userptr) { ttm->sg =kzalloc (sizeof (struct sg_table ),GFP_KERNEL );if (!ttm->sg)return -ENOMEM ;@@ -1146,7 +1146,7 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_device *bdev,struct amdgpu_ttm_tt *gtt = (void *)ttm;struct amdgpu_device *adev; -if (gtt && gtt->userptr) { +if (gtt->userptr) {amdgpu_ttm_tt_set_user_pages (ttm,NULL );kfree (ttm->sg); ttm->sg =NULL ;
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 38 lines · Christian König
Am 04.08.21 um 03:51 schrieb Tuo Li:
Quoted 6 lines
The varialbe gtt in the function
amdgpu_ttm_tt_populate()andamdgpu_ttm_tt_unpopulate()is guaranteed to be not NULL in the context. Thus the null-pointer checks are redundant and can be dropped.Reported-by TOTE Robot <[email protected]>Signed-off-by Tuo Li <[email protected]>Reviewed-by Christian König <[email protected]>Quoted 26 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2
-2@@ -1121,7 +1121,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_device *bdev,struct amdgpu_ttm_tt *gtt = (void *)ttm;/* user pages are bound by amdgpu_ttm_tt_pin_userptr() */ -if (gtt && gtt->userptr) { +if (gtt->userptr) { ttm->sg =kzalloc (sizeof (struct sg_table ),GFP_KERNEL );if (!ttm->sg)return -ENOMEM ;@@ -1146,7 +1146,7 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_device *bdev,struct amdgpu_ttm_tt *gtt = (void *)ttm;struct amdgpu_device *adev; -if (gtt && gtt->userptr) { +if (gtt->userptr) {amdgpu_ttm_tt_set_user_pages (ttm,NULL );kfree (ttm->sg); ttm->sg =NULL ;