Skip to contentSkip to conversation

drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

PATCH In review Jiawei Gu 3 participants 7 messages Aug 4, 2021 – Aug 5, 2021

Subsystems (3)
lore
Share & tools
lore

Jiawei Gu

author
#0 lore raw

PATCH 1/1 drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +4 -4
index 769f58d5ae1a..04c7d82f8b89 100644
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
 static struct amdgpu_device_attr amdgpu_device_attrs[] = {
 	AMDGPU_DEVICE_ATTR_RW(power_dpm_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,	ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC),
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
Signature · 1 line
2.17.1
#1 lore raw

[AMD Official Use Only]

Add Alex.

-----Original Message-----
From: Jiawei Gu <[email protected]>
Sent: Wednesday, August 4, 2021 3:50 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +4 -5
index 769f58d5ae1a..04c7d82f8b89 100644
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_  static struct amdgpu_device_attr amdgpu_device_attrs[] = {
 	AMDGPU_DEVICE_ATTR_RW(power_dpm_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,	ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC),
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
--

2.17.1

#2 lore raw

[AMD Official Use Only]

Ping.

-----Original Message-----
From: Gu, JiaWei (Will) <[email protected]>
Sent: Wednesday, August 4, 2021 4:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only]

Add Alex.

-----Original Message-----
From: Jiawei Gu <[email protected]>
Sent: Wednesday, August 4, 2021 3:50 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +4 -5
index 769f58d5ae1a..04c7d82f8b89 100644
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_  static struct amdgpu_device_attr amdgpu_device_attrs[] = {
 	AMDGPU_DEVICE_ATTR_RW(power_dpm_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,	ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC),
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
 	AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
--

2.17.1

Acked-by
#3 lore raw
Quoted 81 lines

-----Original Message-----
From: Gu, JiaWei (Will) <[email protected]>
Sent: Thursday, August 5, 2021 2:32 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only]

Ping.

-----Original Message-----
From: Gu, JiaWei (Will) <[email protected]>
Sent: Wednesday, August 4, 2021 4:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only]

Add Alex.

-----Original Message-----
From: Jiawei Gu <[email protected]>
Sent: Wednesday, August 4, 2021 3:50 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----

1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -0
index 769f58d5ae1a..04c7d82f8b89 100644
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct

amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = {
AMDGPU_DEVICE_ATTR_RW(power_dpm_state,
ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level, ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,

ATTR_FLAG_BASIC),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,

ATTR_FLAG_BASIC),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,

ATTR_FLAG_BASIC),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
-	AMDGPU_DEVICE_ATTR_RW(pp_table,

ATTR_FLAG_BASIC),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RW(pp_table,

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,
ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,
ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,
ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
--
2.17.1

#4 lore raw
In reply to Gu, JiaWei (Will)
Quoted 34 lines · JiaWei (Will)

[AMD Official Use Only]

Ping.

-----Original Message-----
From: Gu, JiaWei (Will) <[email protected]>
Sent: Wednesday, August 4, 2021 4:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only]

Add Alex.

-----Original Message-----
From: Jiawei Gu <[email protected]>
Sent: Wednesday, August 4, 2021 3:50 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -0
index 769f58d5ae1a..04c7d82f8b89 100644

drivers/gpu/drm/amd/pm/amdgpu_pm.c static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = { · line 2010

Quoted 10 lines
drivers/gpu/drm/amd/pm/amdgpu_pm.c +3 -4
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_  static struct amdgpu_device_attr amdgpu_device_attrs[] = {
  	AMDGPU_DEVICE_ATTR_RW(power_dpm_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
  	AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,	ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC),
 
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Which ASIC is this for? As far as I see from the current implementation, power state is not supported in swsmu projects.

Thanks,
Lijo

drivers/gpu/drm/amd/pm/amdgpu_pm.c static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = { · line 2011

Quoted 1 line
drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF) >   	AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,			 

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Quoted 5 lines
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
  	AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
  	AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
--

2.17.1

#5 lore raw

[AMD Official Use Only]

Hi Lijo,

It's for Navi12 asic as far as I know.

Best regards,
Jiawei

-----Original Message-----
From: Lazar, Lijo <[email protected]>
Sent: Thursday, August 5, 2021 5:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Quoted 40 lines · JiaWei (Will)

[AMD Official Use Only]

Ping.

-----Original Message-----
From: Gu, JiaWei (Will) <[email protected]>
Sent: Wednesday, August 4, 2021 4:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only]

Add Alex.

-----Original Message-----
From: Jiawei Gu <[email protected]>
Sent: Wednesday, August 4, 2021 3:50 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
  drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -0
index 769f58d5ae1a..04c7d82f8b89 100644

drivers/gpu/drm/amd/pm/amdgpu_pm.c static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = { · line 2010

Quoted 10 lines
drivers/gpu/drm/amd/pm/amdgpu_pm.c +3 -4
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_  static struct amdgpu_device_attr amdgpu_device_attrs[] = {
  	AMDGPU_DEVICE_ATTR_RW(power_dpm_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
  	AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,	ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC),
 
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Which ASIC is this for? As far as I see from the current implementation, power state is not supported in swsmu projects.

Thanks,
Lijo

drivers/gpu/drm/amd/pm/amdgpu_pm.c static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = { · line 2011

Quoted 1 line
drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF) >   	AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,			 

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Quoted 5 lines
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
  	AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
  	AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
--

2.17.1

#6 lore raw

Navi12 is swsmu based. Suggest you to check the implementation of below sys nodes and decide what you want to do. Not able to figure out how it worked for you, did you really try this on any 1VF system?

+ AMDGPU_DEVICE_ATTR_RO(pp_num_states, ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+ AMDGPU_DEVICE_ATTR_RO(pp_cur_state, ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+ AMDGPU_DEVICE_ATTR_RW(pp_force_state, ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Thanks,
Lijo

Quoted 82 lines · JiaWei (Will)

[AMD Official Use Only]

Hi Lijo,

It's for Navi12 asic as far as I know.

Best regards,
Jiawei

-----Original Message-----
From: Lazar, Lijo <[email protected]>
Sent: Thursday, August 5, 2021 5:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Quoted 40 lines · JiaWei (Will)

[AMD Official Use Only]

Ping.

-----Original Message-----
From: Gu, JiaWei (Will) <[email protected]>
Sent: Wednesday, August 4, 2021 4:08 PM
To: Gu, JiaWei (Will) <[email protected]>; [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Deucher, Alexander <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

[AMD Official Use Only]

Add Alex.

-----Original Message-----
From: Jiawei Gu <[email protected]>
Sent: Wednesday, August 4, 2021 3:50 PM
To: [email protected]
Cc: Nieto, David M <[email protected]>; Deng, Emily <[email protected]>; Gu, JiaWei (Will) <[email protected]>
Subject: [PATCH] drm/amdgpu: enable more pm sysfs under SRIOV 1-VF mode

Enable pp_num_states, pp_cur_state, pp_force_state, pp_table sysfs under SRIOV 1-VF scenario.

---
   drivers/gpu/drm/amd/pm/amdgpu_pm.c | 8 ++++----
   1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -0
index 769f58d5ae1a..04c7d82f8b89 100644

drivers/gpu/drm/amd/pm/amdgpu_pm.c static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = { · line 2010

Quoted 10 lines
drivers/gpu/drm/amd/pm/amdgpu_pm.c +3 -4
@@ -2005,10 +2005,10 @@ static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_  static struct amdgpu_device_attr amdgpu_device_attrs[] = {
   	AMDGPU_DEVICE_ATTR_RW(power_dpm_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
   	AMDGPU_DEVICE_ATTR_RW(power_dpm_force_performance_level,	ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
-	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC),
-	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC),
 
+	AMDGPU_DEVICE_ATTR_RO(pp_num_states,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RO(pp_cur_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
+	AMDGPU_DEVICE_ATTR_RW(pp_force_state,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Which ASIC is this for? As far as I see from the current implementation, power state is not supported in swsmu projects.

Thanks,
Lijo

drivers/gpu/drm/amd/pm/amdgpu_pm.c static int ss_bias_attr_update(struct amdgpu_device *adev, struct amdgpu_device_ static struct amdgpu_device_attr amdgpu_device_attrs[] = { · line 2011

Quoted 1 line
drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -0
+	AMDGPU_DEVICE_ATTR_RW(pp_table,					ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF) >   	AMDGPU_DEVICE_ATTR_RW(pp_dpm_sclk,			

ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),

Quoted 5 lines
drivers/gpu/drm/amd/pm/amdgpu_pm.c +0 -1
   	AMDGPU_DEVICE_ATTR_RW(pp_dpm_mclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
   	AMDGPU_DEVICE_ATTR_RW(pp_dpm_socclk,				ATTR_FLAG_BASIC|ATTR_FLAG_ONEVF),
--

2.17.1