brcmfmac: uninitialized variable in brcmf_fw_get_firmwares()

The "ret" variable is used without being initialized when "alt_path" is false.

---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index adfdfc654b10..4f387e868120 100644
@@ -680,7 +680,7 @@ int brcmf_fw_get_firmwares(struct device *dev, struct brcmf_fw_request *req,
 	struct brcmf_fw_item *first = &req->items[0];
 	struct brcmf_fw *fwctx;
 	char *alt_path;
-	int ret;
+	int ret = 0;
 
 	brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(dev));
 	if (!fw_cb)

2.20.1

Thanks Dan!

But yesterday I sent another patch which incidentally fixes this too:
https://lore.kernel.org/linux-wireless/[email protected]/T/#u

As you can see in the last hunk of that patch ret is now unconditionally assigned on both forks of the if/else-clause.

Yours,
Linus Walleij