riscv: dts: microchip: Use 'local-mac-address' for emac1
Subsystems (3)
PATCH v2 1/2 riscv: dts: microchip: Use 'local-mac-address' for emac1
From: Bin Meng <[email protected]>
Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.
---
(no changes since v1)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1 -1
@@ -317,7 +317,7 @@ emac1: ethernet@20112000 { reg = <0x0 0x20112000 0x0 0x2000>; interrupt-parent = <&plic>; interrupts = <70 71 72 73>; - mac-address = [00 00 00 00 00 00]; + local-mac-address = [00 00 00 00 00 00]; clocks = <&clkcfg 5>, <&clkcfg 2>; status = "disabled"; clock-names = "pclk", "hclk";
Signature · 1 line
2.25.1
PATCH v2 2/2 riscv: dts: microchip: Add ethernet0 to the aliases node
From: Bin Meng <[email protected]>
U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node.
Note on the Icicle Kit board, currently only emac1 is enabled so it becomes the 'ethernet0'.
---
Changes in v2:
- move the aliases node to board dts
arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 4 ++++ 1 file changed, 4 insertions(+)
arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts +4 -0
@@ -14,6 +14,10 @@ / { model = "Microchip PolarFire-SoC Icicle Kit"; compatible = "microchip,mpfs-icicle-kit"; + aliases { + ethernet0 = &emac1; + }; + chosen { stdout-path = &serial0; };
Signature · 1 line
2.25.1
Re: [PATCH v2 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node
Hi Bin,
Quoted 8 lines · Bin Meng
From: Bin Meng <[email protected]>
U-Boot expects this alias to be in place in order to fix up the mac address of the ethernet node.
Note on the Icicle Kit board, currently only emac1 is enabled so it becomes the 'ethernet0'.
Quoted 6 lines
Signed-off-by Bin Meng <[email protected]>---
Changes in v2:
- move the aliases node to board dts
Thanks for the update!
arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts / { · line 23
Quoted 13 lines
arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts +4
-0@@ -14,6 +14,10 @@ / { model = "Microchip PolarFire-SoC Icicle Kit"; compatible = "microchip,mpfs-icicle-kit"; + aliases { + ethernet0 = &emac1; + }; + chosen { stdout-path = &serial0; };
BTW, is Ethernet working in Linux for you?
IP-Config is always timing out for me.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 9 lines · Bin Meng
From: Bin Meng <[email protected]>
Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.
Quoted 9 lines
Signed-off-by Bin Meng <[email protected]>Reviewed-by conor dooley <[email protected]>---
(no changes since v1)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Ping?
It looks like these dts patches are still not applied...
Regards,
Bin
Hi Bin,
Quoted 10 lines · Bin Meng
From: Bin Meng <[email protected]>
Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.
Signed-off-by Bin Meng <[email protected]>Reviewed-by conor dooley <[email protected]>
Thanks for your patch!
Quoted 12 lines
---
(no changes since v1)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0
-0
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi emac1: ethernet@20112000 { · line 320
Quoted 5 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1
-1@@ -317,7 +317,7 @@ emac1: ethernet@20112000 { reg = <0x0 0x20112000 0x0 0x2000>; interrupt-parent = <&plic>; interrupts = <70 71 72 73>; - mac-address = [00 00 00 00 00 00]; + local-mac-address = [00 00 00 00 00 00];
Is there any point in providing an all-zeros MAC address at all? Can't it just be removed?
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi emac1: ethernet@20112000 { · line 323
Quoted 3 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0
-0clocks = <&clkcfg 5>, <&clkcfg 2>; status = "disabled"; clock-names = "pclk", "hclk";
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Palmer Dabbelt
maintainerQuoted 22 lines · On Wed, 04 Aug 2021 05:30:14 PDT (-0700), [email protected] wrote:
From: Bin Meng <[email protected]>
Per the DT spec, 'local-mac-address' is used to specify MAC address that was assigned to the network device, while 'mac-address' is used to specify the MAC address that was last used by the boot program, and shall be used only if the value differs from 'local-mac-address' property value.
Signed-off-by Bin Meng <[email protected]>Reviewed-by conor dooley <[email protected]>---
(no changes since v1)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0
-0
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi emac1: ethernet@20112000 { · line 323
Quoted 8 lines
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1
-1@@ -317,7 +317,7 @@ emac1: ethernet@20112000 { reg = <0x0 0x20112000 0x0 0x2000>; interrupt-parent = <&plic>; interrupts = <70 71 72 73>; - mac-address = [00 00 00 00 00 00]; + local-mac-address = [00 00 00 00 00 00]; clocks = <&clkcfg 5>, <&clkcfg 2>; status = "disabled"; clock-names = "pclk", "hclk";
Thanks, these are on fixes.