Skip to contentSkip to conversation

drm/amd/display: Fix ASSR regression on embedded panels

PATCH RESEND In review Alex Deucher 2 participants 2 messages Aug 4, 2021 – Aug 6, 2021

Subsystems (4)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH RESEND 1/1 drm/amd/display: Fix ASSR regression on embedded panels

From: Stylon Wang <[email protected]>

[Why]
Regression found in some embedded panels traces back to the earliest upstreamed ASSR patch. The changed code flow are causing problems with some panels.

[How]
- Change ASSR enabling code while preserving original code flow as much as possible
- Simplify the code on guarding with internal display flag

---

This is a backport of this patch to 5.13. I originally sent this out as a follow up to the reply that the original patch failed to apply to 5.13, but it hasn't been applied yet. Resending to make sure it didn't get lost.

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 ---

 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +0 -3
index ae6830ff1cf7..774e825e5aab 100644
@@ -1675,9 +1675,6 @@ static enum dp_panel_mode try_enable_assr(struct dc_stream_state *stream)
 	} else
 		panel_mode = DP_PANEL_MODE_DEFAULT;
 
-#else
-	/* turn off ASSR if the implementation is not compiled in */
-	panel_mode = DP_PANEL_MODE_DEFAULT;
 #endif
 	return panel_mode;
 }
Signature · 1 line
2.31.1
maintainer
#1 lore raw
Quoted 19 lines · Alex Deucher

From: Stylon Wang <[email protected]>

[Why]
Regression found in some embedded panels traces back to the earliest upstreamed ASSR patch. The changed code flow are causing problems with some panels.

[How]
- Change ASSR enabling code while preserving original code flow as much as possible
- Simplify the code on guarding with internal display flag

Quoted 6 lines

---

This is a backport of this patch to 5.13. I originally sent this out as a follow up to the reply that the original patch failed to apply to 5.13, but it hasn't been applied yet. Resending to make sure it didn't get lost.

Not lost, just not caught up on yet. Now queued up, thanks.

greg k-h